From ce8c78c6baf35c086b8a47235bd0fcaee7f1de94 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 25 Jul 2023 14:29:42 +0000 Subject: [PATCH] Bug 34373: Improve layout of curbside pickups items ready list This patch adds fieldset + list markup around the list of titles ready for pickup on the staff interface curbside pickup page. - Properly testing requires testing data. You can run this command to REPLACE your curbside pickup data with sample data: bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh) - Apply the patch and restart services. - Place multiple holds for a single patron and check them in to mark them waiting. - Under Circulation -> Curbside pickups, click the "Schedule pickup" tab. - Search for the patron you placed the holds for. - When the patron information comes up, the list of items ready for pickup should be well-formatted. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- .../prog/en/modules/circ/curbside_pickups.tt | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt index b2ea7786b9..962002e704 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt @@ -452,17 +452,19 @@
  • - - [% IF waiting_holds.count %] - [% FOREACH h IN waiting_holds %] -

    - [% h.biblio.title | html %] ([% h.biblio.author | html %], [% h.item.barcode | html %]) -

    +
    +
      + [% IF waiting_holds.count %] + [% FOREACH h IN waiting_holds %] +
    • + [% h.biblio.title | html %] ([% h.biblio.author | html %], [% h.item.barcode | html %]) +
      • + [% END %] + [% ELSE %] +
    • There are no waiting holds for this patron at this library.
      • [% END %] - [% ELSE %] - There are no waiting holds for this patron at this library. - [% END %] - +
    +
  • -- 2.39.5