From 14df91408da10906288d337bfcc5c96880f2e825 Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Mon, 13 Jun 2022 22:54:54 +0000 Subject: [PATCH] Bug 30958: OPAC overdrive search result page broken for translations Note: You will need a valid OverDrive subscription to test this. This patch fixes a JavaScript error thrown on the OPAC overdrive search results page for libraries using translation templates and who don't have the OverDrivePasswordRequired system preference = 'Required'. Test plan: 1. Install the en-NZ translation: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client 2. Enable the en-NZ language: - In the OPACLanguages system preference -> tick 'English New Zealand (en-NZ)' checkbox and untick 'English (en)' 3. Fill in the OverDrive system preferences: - Make sure you set: OverDrivePasswordRequired = "Not required" 4. Perform an OPAC search 5. Click on the Overdrive results link 6. Open the browser console and notice there is a JS error, and the OverDrive results do not load 7. Apply patch 8. Update the en_NZ translation: 9. Repeat steps 4, 5 and 6 and notice there is no JavaScript error and the OverDrive results do display Sponsored-by: Melbourne Athenaeum Library, Australia Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit ade61b5e0c185fd7263ab6f101b1a4082d0ea0dd) Signed-off-by: Lucas Gass (cherry picked from commit 3f5c43cf2636e3e59d58b6ea739491dea192a51d) Signed-off-by: Arthur Suzuki (cherry picked from commit 6fb34f0d66d6b0882225c5edf099cdf79cdcc617) Signed-off-by: Victor Grousset/tuxayo --- .../opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt index 9b7233cfb6..082a9e5b5f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt @@ -68,7 +68,11 @@ [% BLOCK jsinclude %] [% Asset.js("js/overdrive.js") | $raw %]