From 207e10b81aacd3d28ef2afdbc65d0e0c01d20137 Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Thu, 4 Apr 2024 09:04:47 +0300 Subject: [PATCH] Bug 33849: Do not reset new patrons home library when error occurs While adding new patron, if patron is flagged as duplicate or another error occurs and their home library differs from library user is logged in, patrons home library resets as logged in users library. This happens with all patrons expect those with category type C. This patch removes checking if patrons category type is C from code so that all category types use previously chosen home library even if error occurs. To test: 1. Add new patron and set their library to a different library than the one you're logged in. 2. Cause an error (wrong age, duplicate etc) while saving. 3. Attempt to save. => Note that patrons home library is set as one you're logged in. 4. Apply this patch. 5. Repeat steps 1 to 3. => Note that patrons home library hasn't changed. Sponsored-by: Koha-Suomi Oy Signed-off-by: Esther Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer (cherry picked from commit d2f41df188c3d8e8d8705c6a5ceb583e3e29e629) Signed-off-by: Fridolin Somers (cherry picked from commit 3c52b89167018f79456a3308cdd5f7266856ef5f) Signed-off-by: Lucas Gass --- members/memberentry.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/members/memberentry.pl b/members/memberentry.pl index 7e96130b7d..83ca59df17 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -671,7 +671,7 @@ if (C4::Context->userenv && C4::Context->userenv->{'branch'}) { $userbranch = C4::Context->userenv->{'branch'}; } -if (defined ($data{'branchcode'}) and ( $op eq 'modify' || $op eq 'duplicate' || ( $op eq 'add' && $category->category_type eq 'C' ) )) { +if (defined ($data{'branchcode'}) and ( $op eq 'modify' || $op eq 'duplicate' || $op eq 'add' )) { $userbranch = $data{'branchcode'}; } $template->param( userbranch => $userbranch ); -- 2.39.5