]> git.koha-community.org Git - koha.git/commit
Bug 9126: Do not return from Check too early.
authorJulian Maurice <julian.maurice@biblibre.com>
Wed, 21 Nov 2012 16:38:28 +0000 (17:38 +0100)
committerChris Cormack <chris@bigballofwax.co.nz>
Tue, 15 Jan 2013 04:40:18 +0000 (17:40 +1300)
commitd92c958fcb1c957c54ff236dcf7e1f39681bd90c
treecef808bd0aac82422a25d0e32920d76aeb6b28fc
parentdb3db75e42b040098b70f412c30c715a8be92059
Bug 9126: Do not return from Check too early.

If there is no errors, it should continue instead of returning true.

+ move a block of code at the end of Check function. This avoid
detaching and re-attaching a HTML block if there are errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
The following queries show us the issues:
select count(*) from items;
select * from aqorders_items where ordernumber=XX;

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test:

AcqCreateItem = receive
UniqueItemFields = barcode

1) Create a new basket
2) Create a new order with quantity > 1
3) Close the basket and create a new invoice/shipment
4) Receive only 1 item.
   - Fill out the first item form with item type only. Click add.
   - Don't change second item form at all.
   - Click save.

Before patch:
2 items are created on the record, both with the selected itemtype.

After patch:
Only 1 item is created, which is correct.

Signed-off-by: Elliott Davis <elliott@bywatersolions.com>
Seems to work as described by the test plan
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt