]> git.koha-community.org Git - koha.git/commit
Bug 32477: Launch function hideColumns after changing datatables settings
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Thu, 23 Nov 2023 11:15:57 +0000 (13:15 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 2 Feb 2024 17:46:01 +0000 (17:46 +0000)
commit44adbd6628488ae2fad9eba87fa80a24b5fe1d3a
treec6598864674177cbc779b277c06647b5958b6c66
parente1fcd24cd3e748e9ed7c7543d1d789fbe11bc8c9
Bug 32477: Launch function hideColumns after changing datatables settings

Hiding columns in batch item modification breaks if page is
loaded again. If one hides e.g. column "Collection" and then loads
the page column "Holds" disappears. Also behaviour of checbox
changes for "Collection" column. This happens because we launch
function "hideColumns" before changing datatables settings and
"hidden" column with class "sorting_1" is still present.

To test:
1. Find items to modify and modify them with batch item
modification tool.
2. In modification page, hide column "Collection". Confirm
correct column is hidden.
3. Reload the page or modify items again.
=> Note that column "Holds" is now hidden and checking checkbox
for column "Collection" behaves incorrectly (unchecked checkbox
shows column, checked hides it)
4. Apply this patch.
5. Repeat steps 1, 2 and 3.
=> Confirm correct column is now hidden when page is loaded again
and checkbox works correctly.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 71a7aa1cdce3a3d52dbb421c3ca5d3cf58fcd9c0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit ff3209520563b867365ee7f8c8f8e0dba3913d84)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js