From 2f60cd8dd23662ad2878cb6d189679fde125290f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 24 Apr 2019 00:03:34 -0400 Subject: [PATCH] Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item (You may need the patches on bug 22669) - Change the collection code value => The "Collection code" column must be filled with the new value Signed-off-by: Nick Clemens --- acqui/orderreceive.pl | 2 +- catalogue/getitem-ajax.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl index a9d3201246..05008ae523 100755 --- a/acqui/orderreceive.pl +++ b/acqui/orderreceive.pl @@ -144,7 +144,7 @@ if ($AcqCreateItem eq 'receiving') { $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => $fw, kohafield => 'items.location', authorised_value => $item->{location} }); $item->{location} = $descriptions->{lib} // ''; - $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => $fw, kohafield => 'items.collection', authorised_value => $item->{collection} }); + $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => $fw, kohafield => 'items.ccode', authorised_value => $item->{ccode} }); $item->{collection} = $descriptions->{lib} // ''; $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => $fw, kohafield => 'items.materials', authorised_value => $item->{materials} }); diff --git a/catalogue/getitem-ajax.pl b/catalogue/getitem-ajax.pl index 87fc547aab..80c4f615cf 100755 --- a/catalogue/getitem-ajax.pl +++ b/catalogue/getitem-ajax.pl @@ -69,7 +69,7 @@ if($itemnumber) { $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({ frameworkcode => $fw, kohafield => 'items.location', authorised_value => $item->location }); $item_unblessed->{location} = $descriptions->{lib} // ''; - $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({ frameworkcode => $fw, kohafield => 'items.collection', authorised_value => $item->collection }); + $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({ frameworkcode => $fw, kohafield => 'items.ccode', authorised_value => $item->ccode }); $item_unblessed->{collection} = $descriptions->{lib} // ''; $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => $item->materials }); -- 2.39.5