3 # Copyright 2015 BibLibre
5 # This file is part of Koha.
7 # Koha is free software; you can redistribute it and/or modify it under the
8 # terms of the GNU General Public License as published by the Free Software
9 # Foundation; either version 3 of the License, or (at your option) any later
12 # Koha is distributed in the hope that it will be useful, but WITHOUT ANY
13 # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
14 # A PARTICULAR PURPOSE. See the GNU General Public License for more details.
16 # You should have received a copy of the GNU General Public License along
17 # with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 27;
25 use t::lib::TestBuilder;
29 use Koha::Account::Lines;
30 use Koha::Account::Offsets;
31 use Koha::DateUtils qw( dt_from_string );
34 use_ok('C4::Accounts');
35 use_ok('Koha::Object');
36 use_ok('Koha::Patron');
37 use_ok('Data::Dumper');
40 can_ok( 'C4::Accounts',
47 purge_zero_balance_fees )
50 my $schema = Koha::Database->new->schema;
51 $schema->storage->txn_begin;
52 my $dbh = C4::Context->dbh;
54 my $builder = t::lib::TestBuilder->new;
55 my $library = $builder->build( { source => 'Branch' } );
57 $dbh->do(q|DELETE FROM accountlines|);
58 $dbh->do(q|DELETE FROM issues|);
59 $dbh->do(q|DELETE FROM borrowers|);
61 my $branchcode = $library->{branchcode};
64 my $context = new Test::MockModule('C4::Context');
65 $context->mock( 'userenv', sub {
69 branch => $branchcode,
73 # Testing purge_zero_balance_fees
75 # The 3rd value in the insert is 'days ago' --
80 my $sth = $dbh->prepare(
81 "INSERT INTO accountlines (
87 VALUES ( ?, ?, (select date_sub(CURRENT_DATE, INTERVAL ? DAY) ), ? )"
93 { amount => 0 , days_ago => 0 , description =>'purge_zero_balance_fees should not delete 0 balance fees with date today' , delete => 0 } ,
94 { amount => 0 , days_ago => $days - 1 , description =>'purge_zero_balance_fees should not delete 0 balance fees with date before threshold day' , delete => 0 } ,
95 { amount => 0 , days_ago => $days , description =>'purge_zero_balance_fees should not delete 0 balance fees with date on threshold day' , delete => 0 } ,
96 { amount => 0 , days_ago => $days + 1 , description =>'purge_zero_balance_fees should delete 0 balance fees with date after threshold day' , delete => 1 } ,
97 { amount => undef , days_ago => $days + 1 , description =>'purge_zero_balance_fees should delete NULL balance fees with date after threshold day' , delete => 1 } ,
98 { amount => 5 , days_ago => $days - 1 , description =>'purge_zero_balance_fees should not delete fees with positive amout owed before threshold day' , delete => 0 } ,
99 { amount => 5 , days_ago => $days , description =>'purge_zero_balance_fees should not delete fees with positive amout owed on threshold day' , delete => 0 } ,
100 { amount => 5 , days_ago => $days + 1 , description =>'purge_zero_balance_fees should not delete fees with positive amout owed after threshold day' , delete => 0 } ,
101 { amount => -5 , days_ago => $days - 1 , description =>'purge_zero_balance_fees should not delete fees with negative amout owed before threshold day' , delete => 0 } ,
102 { amount => -5 , days_ago => $days , description =>'purge_zero_balance_fees should not delete fees with negative amout owed on threshold day' , delete => 0 } ,
103 { amount => -5 , days_ago => $days + 1 , description =>'purge_zero_balance_fees should not delete fees with negative amout owed after threshold day' , delete => 0 }
105 my $categorycode = $builder->build({ source => 'Category' })->{categorycode};
106 my $borrower = Koha::Patron->new( { firstname => 'Test', surname => 'Patron', categorycode => $categorycode, branchcode => $branchcode } )->store();
108 for my $data ( @test_data ) {
109 $sth->execute($borrower->borrowernumber, $data->{amount}, $data->{days_ago}, $data->{description});
112 purge_zero_balance_fees( $days );
114 $sth = $dbh->prepare(
115 "select count(*) = 0 as deleted
117 where description = ?"
121 sub is_delete_correct {
122 my $should_delete = shift;
123 my $description = shift;
124 $sth->execute( $description );
125 my $test = $sth->fetchrow_hashref();
126 is( $test->{deleted}, $should_delete, $description )
129 for my $data (@test_data) {
130 is_delete_correct( $data->{delete}, $data->{description});
133 $dbh->do(q|DELETE FROM accountlines|);
135 subtest "Koha::Account::pay tests" => sub {
140 my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
141 my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode };
143 my $borrower = Koha::Patron->new( {
144 cardnumber => '1234567890',
146 firstname => 'Marty',
148 $borrower->categorycode( $categorycode );
149 $borrower->branchcode( $branchcode );
152 my $account = Koha::Account->new({ patron_id => $borrower->id });
154 my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 100 })->store();
155 my $line2 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 200 })->store();
157 $sth = $dbh->prepare("SELECT count(*) FROM accountlines");
159 my $count = $sth->fetchrow_array;
160 is($count, 2, 'There is 2 lines as expected');
162 # There is $100 in the account
163 $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
164 my $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
166 for my $line ( @$amountoutstanding ) {
167 $amountleft += $line;
169 is($amountleft, 300, 'The account has 300$ as expected' );
171 # We make a $20 payment
172 my $borrowernumber = $borrower->borrowernumber;
174 my $payment_note = '$20.00 payment note';
175 my $id = $account->pay( { amount => $data, note => $payment_note, payment_type => "TEST_TYPE" } );
177 my $accountline = Koha::Account::Lines->find( $id );
178 is( $accountline->payment_type, "TEST_TYPE", "Payment type passed into pay is set in account line correctly" );
180 # There is now $280 in the account
181 $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
182 $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
184 for my $line ( @$amountoutstanding ) {
185 $amountleft += $line;
187 is($amountleft, 280, 'The account has $280 as expected' );
189 # Is the payment note well registered
190 $sth = $dbh->prepare("SELECT note FROM accountlines WHERE borrowernumber=? ORDER BY accountlines_id DESC LIMIT 1");
191 $sth->execute($borrower->borrowernumber);
192 my $note = $sth->fetchrow_array;
193 is($note,'$20.00 payment note', '$20.00 payment note is registered');
195 # We make a -$30 payment (a NEGATIVE payment)
197 $payment_note = '-$30.00 payment note';
198 $account->pay( { amount => $data, note => $payment_note } );
200 # There is now $310 in the account
201 $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
202 $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
204 for my $line ( @$amountoutstanding ) {
205 $amountleft += $line;
207 is($amountleft, 310, 'The account has $310 as expected' );
208 # Is the payment note well registered
209 $sth = $dbh->prepare("SELECT note FROM accountlines WHERE borrowernumber=? ORDER BY accountlines_id DESC LIMIT 1");
210 $sth->execute($borrower->borrowernumber);
211 $note = $sth->fetchrow_array;
212 is($note,'-$30.00 payment note', '-$30.00 payment note is registered');
214 #We make a $150 payment ( > 1stLine )
216 $payment_note = '$150.00 payment note';
217 $account->pay( { amount => $data, note => $payment_note } );
219 # There is now $160 in the account
220 $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
221 $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
223 for my $line ( @$amountoutstanding ) {
224 $amountleft += $line;
226 is($amountleft, 160, 'The account has $160 as expected' );
228 # Is the payment note well registered
229 $sth = $dbh->prepare("SELECT note FROM accountlines WHERE borrowernumber=? ORDER BY accountlines_id DESC LIMIT 1");
230 $sth->execute($borrower->borrowernumber);
231 $note = $sth->fetchrow_array;
232 is($note,'$150.00 payment note', '$150.00 payment note is registered');
234 #We make a $200 payment ( > amountleft )
236 $payment_note = '$200.00 payment note';
237 $account->pay( { amount => $data, note => $payment_note } );
239 # There is now -$40 in the account
240 $sth = $dbh->prepare("SELECT amountoutstanding FROM accountlines WHERE borrowernumber=?");
241 $amountoutstanding = $dbh->selectcol_arrayref($sth, {}, $borrower->borrowernumber);
243 for my $line ( @$amountoutstanding ) {
244 $amountleft += $line;
246 is($amountleft, -40, 'The account has -$40 as expected, (credit situation)' );
248 # Is the payment note well registered
249 $sth = $dbh->prepare("SELECT note FROM accountlines WHERE borrowernumber=? ORDER BY accountlines_id DESC LIMIT 1");
250 $sth->execute($borrower->borrowernumber);
251 $note = $sth->fetchrow_array;
252 is($note,'$200.00 payment note', '$200.00 payment note is registered');
254 my $line3 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 42, accounttype => 'TEST' })->store();
255 my $payment_id = $account->pay( { lines => [$line3], amount => 42 } );
256 my $payment = Koha::Account::Lines->find( $payment_id );
257 is( $payment->amount(), '-42.000000', "Payment paid the specified fine" );
258 $line3 = Koha::Account::Lines->find( $line3->id );
259 is( $line3->amountoutstanding, '0.000000', "Specified fine is paid" );
262 subtest "Koha::Account::pay particular line tests" => sub {
267 my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
268 my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode };
270 my $borrower = Koha::Patron->new( {
271 cardnumber => 'kylemhall',
275 $borrower->categorycode( $categorycode );
276 $borrower->branchcode( $branchcode );
279 my $account = Koha::Account->new({ patron_id => $borrower->id });
281 my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 1 })->store();
282 my $line2 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 2 })->store();
283 my $line3 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 3 })->store();
284 my $line4 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 4 })->store();
286 is( $account->balance(), 10, "Account balance is 10" );
290 lines => [$line2, $line3, $line4],
295 $_->_result->discard_changes foreach ( $line1, $line2, $line3, $line4 );
297 # Line1 is not paid at all, as it was not passed in the lines param
298 is( $line1->amountoutstanding, "1.000000", "Line 1 was not paid" );
299 # Line2 was paid in full, as it was the first in the lines list
300 is( $line2->amountoutstanding, "0.000000", "Line 2 was paid in full" );
301 # Line3 was paid partially, as the remaining balance did not cover it entirely
302 is( $line3->amountoutstanding, "1.000000", "Line 3 was paid to 1.00" );
303 # Line4 was not paid at all, as the payment was all used up by that point
304 is( $line4->amountoutstanding, "4.000000", "Line 4 was not paid" );
307 subtest "Koha::Account::pay writeoff tests" => sub {
312 my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
313 my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode };
315 my $borrower = Koha::Patron->new( {
316 cardnumber => 'chelseahall',
318 firstname => 'Chelsea',
320 $borrower->categorycode( $categorycode );
321 $borrower->branchcode( $branchcode );
324 my $account = Koha::Account->new({ patron_id => $borrower->id });
326 my $line = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 42 })->store();
328 is( $account->balance(), 42, "Account balance is 42" );
330 my $id = $account->pay(
338 $line->_result->discard_changes();
340 is( $line->amountoutstanding, "0.000000", "Line was written off" );
342 my $writeoff = Koha::Account::Lines->find( $id );
344 is( $writeoff->accounttype, 'W', 'Type is correct' );
345 is( $writeoff->description, 'Writeoff', 'Description is correct' );
346 is( $writeoff->amount, '-42.000000', 'Amount is correct' );
349 subtest "More Koha::Account::pay tests" => sub {
354 my $category = $builder->build({ source => 'Category' })->{ categorycode };
355 my $branch = $builder->build({ source => 'Branch' })->{ branchcode };
356 $branchcode = $branch;
357 my $borrowernumber = $builder->build({
358 source => 'Borrower',
359 value => { categorycode => $category,
360 branchcode => $branch }
361 })->{ borrowernumber };
364 my $accountline = $builder->build({ source => 'Accountline',
365 value => { borrowernumber => $borrowernumber,
367 amountoutstanding => $amount }
370 my $rs = $schema->resultset('Accountline')->search({
371 borrowernumber => $borrowernumber
374 is( $rs->count(), 1, 'Accountline created' );
376 my $account = Koha::Account->new( { patron_id => $borrowernumber } );
377 my $line = Koha::Account::Lines->find( $accountline->{ accountlines_id } );
378 # make the full payment
379 $account->pay({ lines => [$line], amount => $amount, library_id => $branch, note => 'A payment note' });
381 my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->{accountlines_id} })->next();
382 is( $offset->amount(), '-100.000000', 'Offset amount is -100.00' );
383 is( $offset->type(), 'Payment', 'Offset type is Payment' );
385 my $stat = $schema->resultset('Statistic')->search({
388 }, { order_by => { -desc => 'datetime' } })->next();
390 ok( defined $stat, "There's a payment log that matches the branch" );
393 skip "No statistic logged", 4 unless defined $stat;
395 is( $stat->type, 'payment', "Correct statistic type" );
396 is( $stat->branch, $branch, "Correct branch logged to statistics" );
397 is( $stat->borrowernumber, $borrowernumber, "Correct borrowernumber logged to statistics" );
398 is( $stat->value+0, $amount, "Correct amount logged to statistics" );
402 subtest "Even more Koha::Account::pay tests" => sub {
407 my $category = $builder->build({ source => 'Category' })->{ categorycode };
408 my $branch = $builder->build({ source => 'Branch' })->{ branchcode };
409 $branchcode = $branch;
410 my $borrowernumber = $builder->build({
411 source => 'Borrower',
412 value => { categorycode => $category,
413 branchcode => $branch }
414 })->{ borrowernumber };
417 my $partialamount = 60;
418 my $accountline = $builder->build({ source => 'Accountline',
419 value => { borrowernumber => $borrowernumber,
421 amountoutstanding => $amount }
424 my $rs = $schema->resultset('Accountline')->search({
425 borrowernumber => $borrowernumber
428 is( $rs->count(), 1, 'Accountline created' );
430 my $account = Koha::Account->new( { patron_id => $borrowernumber } );
431 my $line = Koha::Account::Lines->find( $accountline->{ accountlines_id } );
432 # make the full payment
433 $account->pay({ lines => [$line], amount => $partialamount, library_id => $branch, note => 'A payment note' });
435 my $offset = Koha::Account::Offsets->search( { debit_id => $accountline->{ accountlines_id } } )->next();
436 is( $offset->amount, '-60.000000', 'Offset amount is -60.00' );
437 is( $offset->type, 'Payment', 'Offset type is payment' );
439 my $stat = $schema->resultset('Statistic')->search({
442 }, { order_by => { -desc => 'datetime' } })->next();
444 ok( defined $stat, "There's a payment log that matches the branch" );
447 skip "No statistic logged", 4 unless defined $stat;
449 is( $stat->type, 'payment', "Correct statistic type" );
450 is( $stat->branch, $branch, "Correct branch logged to statistics" );
451 is( $stat->borrowernumber, $borrowernumber, "Correct borrowernumber logged to statistics" );
452 is( $stat->value+0, $partialamount, "Correct amount logged to statistics" );
456 subtest 'balance' => sub {
459 my $patron = $builder->build({source => 'Borrower'});
460 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
461 my $account = $patron->account;
462 is( $account->balance, 0, 'balance should return 0 if the patron does not have fines' );
464 my $accountline_1 = $builder->build(
466 source => 'Accountline',
468 borrowernumber => $patron->borrowernumber,
470 amountoutstanding => 42
474 my $accountline_2 = $builder->build(
476 source => 'Accountline',
478 borrowernumber => $patron->borrowernumber,
480 amountoutstanding => -13
485 my $balance = $patron->account->balance;
486 is( int($balance), 29, 'balance should return the correct value');
491 subtest "Koha::Account::chargelostitem tests" => sub {
497 my $itype_no_replace_no_fee = $builder->build({ source => 'Itemtype', value => {
499 defaultreplacecost => undef,
502 my $itype_replace_no_fee = $builder->build({ source => 'Itemtype', value => {
504 defaultreplacecost => 16.32,
507 my $itype_no_replace_fee = $builder->build({ source => 'Itemtype', value => {
509 defaultreplacecost => undef,
512 my $itype_replace_fee = $builder->build({ source => 'Itemtype', value => {
514 defaultreplacecost => 4.08,
517 my $cli_borrowernumber = $builder->build({ source => 'Borrower' })->{'borrowernumber'};
518 my $cli_itemnumber1 = $builder->build({ source => 'Item', value => { itype => $itype_no_replace_no_fee->{itemtype} } })->{'itemnumber'};
519 my $cli_itemnumber2 = $builder->build({ source => 'Item', value => { itype => $itype_replace_no_fee->{itemtype} } })->{'itemnumber'};
520 my $cli_itemnumber3 = $builder->build({ source => 'Item', value => { itype => $itype_no_replace_fee->{itemtype} } })->{'itemnumber'};
521 my $cli_itemnumber4 = $builder->build({ source => 'Item', value => { itype => $itype_replace_fee->{itemtype} } })->{'itemnumber'};
523 my $cli_issue_id_1 = $builder->build({ source => 'Issue', value => { borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1 } })->{issue_id};
524 my $cli_issue_id_2 = $builder->build({ source => 'Issue', value => { borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2 } })->{issue_id};
525 my $cli_issue_id_3 = $builder->build({ source => 'Issue', value => { borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3 } })->{issue_id};
526 my $cli_issue_id_4 = $builder->build({ source => 'Issue', value => { borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4 } })->{issue_id};
528 my $duck = Koha::Items->find({itemnumber=>$cli_itemnumber1});
530 t::lib::Mocks::mock_preference('item-level_itypes', '1');
531 t::lib::Mocks::mock_preference('useDefaultReplacementCost', '0');
533 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 0, "Perdedor");
534 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
535 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
536 ok( !$lostfine, "No lost fine if no replacementcost or default when pref off");
537 ok( !$procfee, "No processing fee if no processing fee");
538 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 6.12, "Perdedor");
539 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
540 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
541 ok( $lostfine->amount == 6.12, "Lost fine equals replacementcost when pref off and no default set");
542 ok( !$procfee, "No processing fee if no processing fee");
545 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 0, "Perdedor");
546 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
547 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
548 ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
549 ok( !$procfee, "No processing fee if no processing fee");
550 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 6.12, "Perdedor");
551 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
552 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
553 ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
554 ok( !$procfee, "No processing fee if no processing fee");
557 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 0, "Perdedor");
558 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
559 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
560 ok( !$lostfine, "No lost fine if no replacementcost and no default set when pref off");
561 ok( $procfee->amount == 8.16, "Processing fee if processing fee");
562 is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
564 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 6.12, "Perdedor");
565 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
566 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
567 ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and no default set");
568 ok( $procfee->amount == 8.16, "Processing fee if processing fee");
569 is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
573 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
574 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
575 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
576 ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
577 ok( $procfee->amount == 2.04, "Processing fee if processing fee");
578 is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
580 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 6.12, "Perdedor");
581 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
582 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
583 ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
584 ok( $procfee->amount == 2.04, "Processing fee if processing fee");
585 is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
589 t::lib::Mocks::mock_preference('useDefaultReplacementCost', '1');
591 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 0, "Perdedor");
592 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
593 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
594 ok( !$lostfine, "No lost fine if no replacementcost or default when pref on");
595 ok( !$procfee, "No processing fee if no processing fee");
596 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 6.12, "Perdedor");
597 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
598 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
599 is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
600 ok( !$procfee, "No processing fee if no processing fee");
602 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 0, "Perdedor");
603 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
604 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
605 is( $lostfine->amount(), "16.320000", "Lost fine is default if no replacementcost but default set when pref on");
606 ok( !$procfee, "No processing fee if no processing fee");
608 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 6.12, "Perdedor");
609 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
610 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
611 is( $lostfine->amount, "6.120000" , "Lost fine equals replacementcost when pref on and default set");
612 ok( !$procfee, "No processing fee if no processing fee");
614 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 0, "Perdedor");
615 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
616 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
617 ok( !$lostfine, "No lost fine if no replacementcost and default not set when pref on");
618 is( $procfee->amount, "8.160000", "Processing fee if processing fee");
619 is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
621 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 6.12, "Perdedor");
622 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
623 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
624 is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
625 is( $procfee->amount, "8.160000", "Processing fee if processing fee");
626 is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
628 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
629 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
630 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
631 is( $lostfine->amount, "4.080000", "Lost fine is default if no replacementcost but default set when pref on");
632 is( $procfee->amount, "2.040000", "Processing fee if processing fee");
633 is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
636 C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 6.12, "Perdedor");
637 $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
638 $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
639 is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and default set");
640 is( $procfee->amount, "2.040000", "Processing fee if processing fee");
641 is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
643 # Cleanup - this must be replaced with a transaction per subtest
644 Koha::Patrons->find($cli_borrowernumber)->checkouts->delete;
647 subtest "Koha::Account::non_issues_charges tests" => sub {
650 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
652 my $today = dt_from_string;
656 Koha::Account::Line->new(
658 borrowernumber => $patron->borrowernumber,
661 description => 'a Res fee',
662 accounttype => 'Res',
663 amountoutstanding => $res,
666 Koha::Account::Line->new(
668 borrowernumber => $patron->borrowernumber,
671 description => 'a Rental fee',
672 accounttype => 'Rent',
673 amountoutstanding => $rent,
676 Koha::Account::Line->new(
678 borrowernumber => $patron->borrowernumber,
681 description => 'a Manual invoice fee',
682 accounttype => 'Copie',
683 amountoutstanding => $manual,
686 Koha::AuthorisedValue->new(
688 category => 'MANUAL_INV',
689 authorised_value => 'Copie',
690 lib => 'Fee for copie',
694 my $account = $patron->account;
696 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', 0 );
697 t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 0 );
698 t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge', 0 );
699 my ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
700 my $other_charges = $total - $non_issues_charges;
703 $res + $rent + $manual,
704 'Total charges should be Res + Rent + Manual'
706 is( $non_issues_charges, 0,
707 'If 0|0|0 there should not have non issues charges' );
708 is( $other_charges, 15, 'If 0|0|0 there should only have other charges' );
710 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', 0 );
711 t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 0 );
712 t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge', 1 );
713 ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
714 $other_charges = $total - $non_issues_charges;
717 $res + $rent + $manual,
718 'Total charges should be Res + Rent + Manual'
720 is( $non_issues_charges, $manual,
721 'If 0|0|1 Only Manual should be a non issue charge' );
725 'If 0|0|1 Res + Rent should be other charges'
728 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', 0 );
729 t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 1 );
730 t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge', 0 );
731 ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
732 $other_charges = $total - $non_issues_charges;
735 $res + $rent + $manual,
736 'Total charges should be Res + Rent + Manual'
738 is( $non_issues_charges, $rent,
739 'If 0|1|0 Only Rental should be a non issue charge' );
743 'If 0|1|0 Rent + Manual should be other charges'
746 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', 0 );
747 t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 1 );
748 t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge', 1 );
749 ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
750 $other_charges = $total - $non_issues_charges;
753 $res + $rent + $manual,
754 'Total charges should be Res + Rent + Manual'
759 'If 0|1|1 Rent + Manual should be non issues charges'
761 is( $other_charges, $res, 'If 0|1|1 there should only have other charges' );
763 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', 1 );
764 t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 0 );
765 t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge', 0 );
766 ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
767 $other_charges = $total - $non_issues_charges;
770 $res + $rent + $manual,
771 'Total charges should be Res + Rent + Manual'
773 is( $non_issues_charges, $res,
774 'If 1|0|0 Only Res should be non issues charges' );
778 'If 1|0|0 Rent + Manual should be other charges'
781 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', 1 );
782 t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 1 );
783 t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge', 0 );
784 ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
785 $other_charges = $total - $non_issues_charges;
788 $res + $rent + $manual,
789 'Total charges should be Res + Rent + Manual'
794 'If 1|1|0 Res + Rent should be non issues charges'
796 is( $other_charges, $manual,
797 'If 1|1|0 Only Manual should be other charges' );
799 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', 1 );
800 t::lib::Mocks::mock_preference( 'RentalsInNoissuesCharge', 1 );
801 t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge', 1 );
802 ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges );
803 $other_charges = $total - $non_issues_charges;
806 $res + $rent + $manual,
807 'Total charges should be Res + Rent + Manual'
811 $res + $rent + $manual,
812 'If 1|1|1 Res + Rent + Manual should be non issues charges'
814 is( $other_charges, 0, 'If 1|1|1 there should not have any other charges' );
817 subtest "Koha::Account::non_issues_charges tests" => sub {
820 my $patron = $builder->build_object(
822 class => "Koha::Patrons",
826 categorycode => $categorycode,
827 branchcode => $branchcode
832 my $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store();
833 my $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => -5 })->store();
834 my $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment', amount => 0 })->store();
835 purge_zero_balance_fees( 1 );
836 my $debit_2 = Koha::Account::Lines->find( $debit->id );
837 my $credit_2 = Koha::Account::Lines->find( $credit->id );
838 ok( $debit_2, 'Debit was correctly not deleted when credit has balance' );
839 ok( $credit_2, 'Credit was correctly not deleted when credit has balance' );
840 is( Koha::Account::Lines->count({ borrowernumber => $patron->id }), 2, "The 2 account lines still exists" );
842 $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 5 })->store();
843 $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store();
844 $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment', amount => 0 })->store();
845 purge_zero_balance_fees( 1 );
846 $debit_2 = $credit_2 = undef;
847 $debit_2 = Koha::Account::Lines->find( $debit->id );
848 $credit_2 = Koha::Account::Lines->find( $credit->id );
849 ok( $debit_2, 'Debit was correctly not deleted when debit has balance' );
850 ok( $credit_2, 'Credit was correctly not deleted when debit has balance' );
851 is( Koha::Account::Lines->count({ borrowernumber => $patron->id }), 2 + 2, "The 2 + 2 account lines still exists" );
853 $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store();
854 $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store();
855 $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment', amount => 0 })->store();
856 purge_zero_balance_fees( 1 );
857 $debit_2 = Koha::Account::Lines->find( $debit->id );
858 $credit_2 = Koha::Account::Lines->find( $credit->id );
859 ok( !$debit_2, 'Debit was correctly deleted' );
860 ok( !$credit_2, 'Credit was correctly deleted' );
861 is( Koha::Account::Lines->count({ borrowernumber => $patron->id }), 2 + 2, "The 2 + 2 account lines still exists, the last 2 have been deleted ok" );
864 subtest "Koha::Account::Line::void tests" => sub {
869 my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
870 my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode };
872 my $borrower = Koha::Patron->new( {
873 cardnumber => 'dariahall',
875 firstname => 'Daria',
877 $borrower->categorycode( $categorycode );
878 $borrower->branchcode( $branchcode );
881 my $account = Koha::Account->new({ patron_id => $borrower->id });
883 my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amount => 10, amountoutstanding => 10 })->store();
884 my $line2 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amount => 20, amountoutstanding => 20 })->store();
886 is( $account->balance(), 30, "Account balance is 30" );
887 is( $line1->amountoutstanding, 10, 'First fee has amount outstanding of 10' );
888 is( $line2->amountoutstanding, 20, 'Second fee has amount outstanding of 20' );
890 my $id = $account->pay(
892 lines => [$line1, $line2],
897 my $account_payment = Koha::Account::Lines->find( $id );
899 is( $account->balance(), 0, "Account balance is 0" );
901 $line1->_result->discard_changes();
902 $line2->_result->discard_changes();
903 is( $line1->amountoutstanding+0, 0, 'First fee has amount outstanding of 0' );
904 is( $line2->amountoutstanding+0, 0, 'Second fee has amount outstanding of 0' );
906 $account_payment->void();
908 is( $account->balance(), 30, "Account balance is again 30" );
910 $account_payment->_result->discard_changes();
911 $line1->_result->discard_changes();
912 $line2->_result->discard_changes();
914 is( $account_payment->accounttype, 'VOID', 'Voided payment accounttype is VOID' );
915 is( $account_payment->amount+0, 0, 'Voided payment amount is 0' );
916 is( $account_payment->amountoutstanding+0, 0, 'Voided payment amount outstanding is 0' );
918 is( $line1->amountoutstanding+0, 10, 'First fee again has amount outstanding of 10' );
919 is( $line2->amountoutstanding+0, 20, 'Second fee again has amount outstanding of 20' );
922 subtest "Koha::Account::Offset credit & debit tests" => sub {
927 my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };
928 my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode };
930 my $borrower = Koha::Patron->new( {
931 cardnumber => 'kyliehall',
933 firstname => 'Kylie',
935 $borrower->categorycode( $categorycode );
936 $borrower->branchcode( $branchcode );
939 my $account = Koha::Account->new({ patron_id => $borrower->id });
941 my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amount => 10, amountoutstanding => 10 })->store();
942 my $line2 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amount => 20, amountoutstanding => 20 })->store();
944 my $id = $account->pay(
946 lines => [$line1, $line2],
951 # Test debit and credit methods for Koha::Account::Offset
952 my $account_offset = Koha::Account::Offsets->find( { credit_id => $id, debit_id => $line1->id } );
953 is( $account_offset->debit->id, $line1->id, "Koha::Account::Offset->debit gets correct accountline" );
954 is( $account_offset->credit->id, $id, "Koha::Account::Offset->credit gets correct accountline" );
956 $account_offset = Koha::Account::Offset->new(
965 is( $account_offset->debit, undef, "Koha::Account::Offset->debit returns undef if no associated debit" );
966 is( $account_offset->credit, undef, "Koha::Account::Offset->credit returns undef if no associated credit" );