3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use Test::More tests => 120;
24 use POSIX qw( floor );
26 use t::lib::TestBuilder;
34 use C4::Overdues qw(UpdateFine CalcFine);
37 use Koha::IssuingRules;
40 use Koha::Subscriptions;
41 use Koha::Account::Lines;
42 use Koha::Account::Offsets;
44 my $schema = Koha::Database->schema;
45 $schema->storage->txn_begin;
46 my $builder = t::lib::TestBuilder->new;
47 my $dbh = C4::Context->dbh;
50 $dbh->{RaiseError} = 1;
52 my $cache = Koha::Caches->get_instance();
53 $dbh->do(q|DELETE FROM special_holidays|);
54 $dbh->do(q|DELETE FROM repeatable_holidays|);
55 $cache->clear_from_cache('single_holidays');
57 # Start with a clean slate
58 $dbh->do('DELETE FROM issues');
59 $dbh->do('DELETE FROM borrowers');
61 my $library = $builder->build({
64 my $library2 = $builder->build({
67 my $itemtype = $builder->build(
68 { source => 'Itemtype',
69 value => { notforloan => undef, rentalcharge => 0, defaultreplacecost => undef, processfee => undef }
72 my $patron_category = $builder->build(
78 BlockExpiredPatronOpacActions => -1, # Pick the pref value
83 my $CircControl = C4::Context->preference('CircControl');
84 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
87 homebranch => $library2->{branchcode},
88 holdingbranch => $library2->{branchcode}
92 branchcode => $library2->{branchcode}
95 # No userenv, PickupLibrary
96 t::lib::Mocks::mock_preference('IndependentBranches', '0');
97 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
99 C4::Context->preference('CircControl'),
101 'CircControl changed to PickupLibrary'
104 C4::Circulation::_GetCircControlBranch($item, $borrower),
105 $item->{$HomeOrHoldingBranch},
106 '_GetCircControlBranch returned item branch (no userenv defined)'
109 # No userenv, PatronLibrary
110 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
112 C4::Context->preference('CircControl'),
114 'CircControl changed to PatronLibrary'
117 C4::Circulation::_GetCircControlBranch($item, $borrower),
118 $borrower->{branchcode},
119 '_GetCircControlBranch returned borrower branch'
122 # No userenv, ItemHomeLibrary
123 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
125 C4::Context->preference('CircControl'),
127 'CircControl changed to ItemHomeLibrary'
130 $item->{$HomeOrHoldingBranch},
131 C4::Circulation::_GetCircControlBranch($item, $borrower),
132 '_GetCircControlBranch returned item branch'
136 C4::Context->_new_userenv('xxx');
137 C4::Context->set_userenv(0,0,0,'firstname','surname', $library2->{branchcode}, 'Midway Public Library', '', '', '');
138 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
140 # Userenv set, PickupLibrary
141 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
143 C4::Context->preference('CircControl'),
145 'CircControl changed to PickupLibrary'
148 C4::Circulation::_GetCircControlBranch($item, $borrower),
149 $library2->{branchcode},
150 '_GetCircControlBranch returned current branch'
153 # Userenv set, PatronLibrary
154 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
156 C4::Context->preference('CircControl'),
158 'CircControl changed to PatronLibrary'
161 C4::Circulation::_GetCircControlBranch($item, $borrower),
162 $borrower->{branchcode},
163 '_GetCircControlBranch returned borrower branch'
166 # Userenv set, ItemHomeLibrary
167 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
169 C4::Context->preference('CircControl'),
171 'CircControl changed to ItemHomeLibrary'
174 C4::Circulation::_GetCircControlBranch($item, $borrower),
175 $item->{$HomeOrHoldingBranch},
176 '_GetCircControlBranch returned item branch'
179 # Reset initial configuration
180 t::lib::Mocks::mock_preference('CircControl', $CircControl);
182 C4::Context->preference('CircControl'),
184 'CircControl reset to its initial value'
187 # Set a simple circ policy
188 $dbh->do('DELETE FROM issuingrules');
190 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
191 maxissueqty, issuelength, lengthunit,
192 renewalsallowed, renewalperiod,
193 norenewalbefore, auto_renew,
210 # Test C4::Circulation::ProcessOfflinePayment
211 my $sth = C4::Context->dbh->prepare("SELECT COUNT(*) FROM accountlines WHERE amount = '-123.45' AND accounttype = 'Pay'");
213 my ( $original_count ) = $sth->fetchrow_array();
215 C4::Context->dbh->do("INSERT INTO borrowers ( cardnumber, surname, firstname, categorycode, branchcode ) VALUES ( '99999999999', 'Hall', 'Kyle', ?, ? )", undef, $patron_category->{categorycode}, $library2->{branchcode} );
217 C4::Circulation::ProcessOfflinePayment({ cardnumber => '99999999999', amount => '123.45' });
220 my ( $new_count ) = $sth->fetchrow_array();
222 ok( $new_count == $original_count + 1, 'ProcessOfflinePayment makes payment correctly' );
224 C4::Context->dbh->do("DELETE FROM accountlines WHERE borrowernumber IN ( SELECT borrowernumber FROM borrowers WHERE cardnumber = '99999999999' )");
225 C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'");
226 C4::Context->dbh->do("DELETE FROM accountlines");
228 # CanBookBeRenewed tests
229 C4::Context->set_preference('ItemsDeniedRenewal','');
230 # Generate test biblio
231 my $title = 'Silence in the library';
232 my ($biblionumber, $biblioitemnumber) = add_biblio($title, 'Moffat, Steven');
234 my $barcode = 'R00000342';
235 my $branch = $library2->{branchcode};
237 my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
239 homebranch => $branch,
240 holdingbranch => $branch,
242 replacementprice => 12.00,
248 my $barcode2 = 'R00000343';
249 my ( $item_bibnum2, $item_bibitemnum2, $itemnumber2 ) = AddItem(
251 homebranch => $branch,
252 holdingbranch => $branch,
253 barcode => $barcode2,
254 replacementprice => 23.00,
260 my $barcode3 = 'R00000346';
261 my ( $item_bibnum3, $item_bibitemnum3, $itemnumber3 ) = AddItem(
263 homebranch => $branch,
264 holdingbranch => $branch,
265 barcode => $barcode3,
266 replacementprice => 23.00,
273 my %renewing_borrower_data = (
275 surname => 'Renewal',
276 categorycode => $patron_category->{categorycode},
277 branchcode => $branch,
280 my %reserving_borrower_data = (
281 firstname => 'Katrin',
282 surname => 'Reservation',
283 categorycode => $patron_category->{categorycode},
284 branchcode => $branch,
287 my %hold_waiting_borrower_data = (
289 surname => 'Reservation',
290 categorycode => $patron_category->{categorycode},
291 branchcode => $branch,
294 my %restricted_borrower_data = (
295 firstname => 'Alice',
296 surname => 'Reservation',
297 categorycode => $patron_category->{categorycode},
298 debarred => '3228-01-01',
299 branchcode => $branch,
302 my %expired_borrower_data = (
305 categorycode => $patron_category->{categorycode},
306 branchcode => $branch,
307 dateexpiry => dt_from_string->subtract( months => 1 ),
310 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
311 my $reserving_borrowernumber = Koha::Patron->new(\%reserving_borrower_data)->store->borrowernumber;
312 my $hold_waiting_borrowernumber = Koha::Patron->new(\%hold_waiting_borrower_data)->store->borrowernumber;
313 my $restricted_borrowernumber = Koha::Patron->new(\%restricted_borrower_data)->store->borrowernumber;
314 my $expired_borrowernumber = Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
316 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
317 my $restricted_borrower = Koha::Patrons->find( $restricted_borrowernumber )->unblessed;
318 my $expired_borrower = Koha::Patrons->find( $expired_borrowernumber )->unblessed;
325 my $checkitem = undef;
328 my $issue = AddIssue( $renewing_borrower, $barcode);
329 my $datedue = dt_from_string( $issue->date_due() );
330 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
332 my $issue2 = AddIssue( $renewing_borrower, $barcode2);
333 $datedue = dt_from_string( $issue->date_due() );
334 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
337 my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $itemnumber } )->borrowernumber;
338 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
340 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
341 is( $renewokay, 1, 'Can renew, no holds for this title or item');
344 # Biblio-level hold, renewal test
346 $branch, $reserving_borrowernumber, $biblionumber,
347 $bibitems, $priority, $resdate, $expdate, $notes,
348 $title, $checkitem, $found
351 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
352 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
353 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
354 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
355 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
356 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
357 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
359 # Now let's add an item level hold, we should no longer be able to renew the item
360 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
362 borrowernumber => $hold_waiting_borrowernumber,
363 biblionumber => $biblionumber,
364 itemnumber => $itemnumber,
365 branchcode => $branch,
369 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
370 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
373 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
374 # be able to renew these items
375 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
377 borrowernumber => $hold_waiting_borrowernumber,
378 biblionumber => $biblionumber,
379 itemnumber => $itemnumber3,
380 branchcode => $branch,
385 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
386 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
387 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
388 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
389 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
391 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
392 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
393 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
395 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
396 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
397 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
399 my $reserveid = Koha::Holds->search({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
400 my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;
401 AddIssue($reserving_borrower, $barcode3);
402 my $reserve = $dbh->selectrow_hashref(
403 'SELECT * FROM old_reserves WHERE reserve_id = ?',
407 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
409 # Item-level hold, renewal test
411 $branch, $reserving_borrowernumber, $biblionumber,
412 $bibitems, $priority, $resdate, $expdate, $notes,
413 $title, $itemnumber, $found
416 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
417 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
418 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
420 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2, 1);
421 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
423 # Items can't fill hold for reasons
424 ModItem({ notforloan => 1 }, $biblionumber, $itemnumber);
425 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
426 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
427 ModItem({ notforloan => 0, itype => $itemtype }, $biblionumber, $itemnumber);
429 # FIXME: Add more for itemtype not for loan etc.
431 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
432 my $barcode5 = 'R00000347';
433 my ( $item_bibnum5, $item_bibitemnum5, $itemnumber5 ) = AddItem(
435 homebranch => $branch,
436 holdingbranch => $branch,
437 barcode => $barcode5,
438 replacementprice => 23.00,
443 my $datedue5 = AddIssue($restricted_borrower, $barcode5);
444 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
446 t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
447 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
448 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
449 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $itemnumber5);
450 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
452 # Users cannot renew an overdue item
453 my $barcode6 = 'R00000348';
454 my ( $item_bibnum6, $item_bibitemnum6, $itemnumber6 ) = AddItem(
456 homebranch => $branch,
457 holdingbranch => $branch,
458 barcode => $barcode6,
459 replacementprice => 23.00,
465 my $barcode7 = 'R00000349';
466 my ( $item_bibnum7, $item_bibitemnum7, $itemnumber7 ) = AddItem(
468 homebranch => $branch,
469 holdingbranch => $branch,
470 barcode => $barcode7,
471 replacementprice => 23.00,
476 my $datedue6 = AddIssue( $renewing_borrower, $barcode6);
477 is (defined $datedue6, 1, "Item 2 checked out, due date: ".$datedue6->date_due);
479 my $now = dt_from_string();
480 my $five_weeks = DateTime::Duration->new(weeks => 5);
481 my $five_weeks_ago = $now - $five_weeks;
482 t::lib::Mocks::mock_preference('finesMode', 'production');
484 my $passeddatedue1 = AddIssue($renewing_borrower, $barcode7, $five_weeks_ago);
485 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
487 my ( $fine ) = CalcFine( GetItem(undef, $barcode7), $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
488 C4::Overdues::UpdateFine(
490 issue_id => $passeddatedue1->id(),
491 itemnumber => $itemnumber7,
492 borrowernumber => $renewing_borrower->{borrowernumber},
495 due => Koha::DateUtils::output_pref($five_weeks_ago)
499 t::lib::Mocks::mock_preference('RenewalLog', 0);
500 my $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } );
501 my $old_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
502 AddRenewal( $renewing_borrower->{borrowernumber}, $itemnumber7, $branch );
503 my $new_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
504 is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
506 t::lib::Mocks::mock_preference('RenewalLog', 1);
507 $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } );
508 $old_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
509 AddRenewal( $renewing_borrower->{borrowernumber}, $itemnumber7, $branch );
510 $new_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
511 is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
513 my $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $itemnumber7 } );
514 is( $fines->count, 2 );
515 is( $fines->next->accounttype, 'F', 'Fine on renewed item is closed out properly' );
516 is( $fines->next->accounttype, 'F', 'Fine on renewed item is closed out properly' );
520 my $old_issue_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["ISSUE"]) } );
521 my $old_renew_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
522 AddIssue( $renewing_borrower,$barcode7,Koha::DateUtils::output_pref({str=>$datedue6->date_due, dateformat =>'iso'}),0,$date, 0, undef );
523 $new_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
524 is ($new_log_size, $old_renew_log_size + 1, 'renew log successfully added when renewed via issuing');
525 $new_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["ISSUE"]) } );
526 is ($new_log_size, $old_issue_log_size, 'renew not logged as issue when renewed via issuing');
528 $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $itemnumber7 } );
531 t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
532 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber6);
533 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
534 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber7);
535 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
538 $hold = Koha::Holds->search({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber })->next;
542 # Test automatic renewal before value for "norenewalbefore" in policy is set
543 # In this case automatic renewal is not permitted prior to due date
544 my $barcode4 = '11235813';
545 my ( $item_bibnum4, $item_bibitemnum4, $itemnumber4 ) = AddItem(
547 homebranch => $branch,
548 holdingbranch => $branch,
549 barcode => $barcode4,
550 replacementprice => 16.00,
556 $issue = AddIssue( $renewing_borrower, $barcode4, undef, undef, undef, undef, { auto_renew => 1 } );
557 ( $renewokay, $error ) =
558 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
559 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
560 is( $error, 'auto_too_soon',
561 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
564 # Test premature manual renewal
565 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7');
567 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
568 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
569 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
572 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
573 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
575 GetSoonestRenewDate( $renewing_borrowernumber, $itemnumber ),
576 $datedue->clone->add( days => -7 ),
577 'Bug 14395: Renewals permitted 7 days before due date, as expected'
581 # Test 'date' setting for syspref NoRenewalBeforePrecision
582 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
584 GetSoonestRenewDate( $renewing_borrowernumber, $itemnumber ),
585 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
586 'Bug 14395: Renewals permitted 7 days before due date, as expected'
590 # Test premature automatic renewal
591 ( $renewokay, $error ) =
592 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
593 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
594 is( $error, 'auto_too_soon',
595 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
598 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
599 # and test automatic renewal again
600 $dbh->do('UPDATE issuingrules SET norenewalbefore = 0');
601 ( $renewokay, $error ) =
602 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
603 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
604 is( $error, 'auto_too_soon',
605 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
608 # Change policy so that loans can be renewed 99 days prior to the due date
609 # and test automatic renewal again
610 $dbh->do('UPDATE issuingrules SET norenewalbefore = 99');
611 ( $renewokay, $error ) =
612 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
613 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
614 is( $error, 'auto_renew',
615 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
618 subtest "too_late_renewal / no_auto_renewal_after" => sub {
620 my $item_to_auto_renew = $builder->build(
623 biblionumber => $biblionumber,
624 homebranch => $branch,
625 holdingbranch => $branch,
630 my $ten_days_before = dt_from_string->add( days => -10 );
631 my $ten_days_ahead = dt_from_string->add( days => 10 );
632 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
634 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 9');
635 ( $renewokay, $error ) =
636 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
637 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
638 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
640 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 10');
641 ( $renewokay, $error ) =
642 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
643 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
644 is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
646 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 11');
647 ( $renewokay, $error ) =
648 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
649 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
650 is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
652 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
653 ( $renewokay, $error ) =
654 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
655 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
656 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
658 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => -1 ) );
659 ( $renewokay, $error ) =
660 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
661 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
662 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
664 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => -1 ) );
665 ( $renewokay, $error ) =
666 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
667 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
668 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
670 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 1 ) );
671 ( $renewokay, $error ) =
672 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
673 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
674 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
677 subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew" => sub {
679 my $item_to_auto_renew = $builder->build({
682 biblionumber => $biblionumber,
683 homebranch => $branch,
684 holdingbranch => $branch,
688 my $ten_days_before = dt_from_string->add( days => -10 );
689 my $ten_days_ahead = dt_from_string->add( days => 10 );
690 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
692 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
693 C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
694 C4::Context->set_preference('OPACFineNoRenewals','10');
695 my $fines_amount = 5;
696 C4::Accounts::manualinvoice( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber}, "Some fines", 'F', $fines_amount );
697 ( $renewokay, $error ) =
698 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
699 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
700 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
702 C4::Accounts::manualinvoice( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber}, "Some fines", 'F', $fines_amount );
703 ( $renewokay, $error ) =
704 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
705 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
706 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
708 C4::Accounts::manualinvoice( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber}, "Some fines", 'F', $fines_amount );
709 ( $renewokay, $error ) =
710 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
711 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
712 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );
714 $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
717 subtest "auto_account_expired | BlockExpiredPatronOpacActions" => sub {
719 my $item_to_auto_renew = $builder->build({
722 biblionumber => $biblionumber,
723 homebranch => $branch,
724 holdingbranch => $branch,
728 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
730 my $ten_days_before = dt_from_string->add( days => -10 );
731 my $ten_days_ahead = dt_from_string->add( days => 10 );
733 # Patron is expired and BlockExpiredPatronOpacActions=0
734 # => auto renew is allowed
735 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 0);
736 my $patron = $expired_borrower;
737 my $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
738 ( $renewokay, $error ) =
739 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
740 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
741 is( $error, 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
742 Koha::Checkouts->find( $checkout->issue_id )->delete;
745 # Patron is expired and BlockExpiredPatronOpacActions=1
746 # => auto renew is not allowed
747 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
748 $patron = $expired_borrower;
749 $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
750 ( $renewokay, $error ) =
751 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
752 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
753 is( $error, 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
754 Koha::Checkouts->find( $checkout->issue_id )->delete;
757 # Patron is not expired and BlockExpiredPatronOpacActions=1
758 # => auto renew is allowed
759 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
760 $patron = $renewing_borrower;
761 $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
762 ( $renewokay, $error ) =
763 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
764 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
765 is( $error, 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
766 Koha::Checkouts->find( $checkout->issue_id )->delete;
769 subtest "GetLatestAutoRenewDate" => sub {
771 my $item_to_auto_renew = $builder->build(
774 biblionumber => $biblionumber,
775 homebranch => $branch,
776 holdingbranch => $branch,
781 my $ten_days_before = dt_from_string->add( days => -10 );
782 my $ten_days_ahead = dt_from_string->add( days => 10 );
783 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
784 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = NULL');
785 my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
786 is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after or no_auto_renewal_after_hard_limit are not defined' );
787 my $five_days_before = dt_from_string->add( days => -5 );
788 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 5, no_auto_renewal_after_hard_limit = NULL');
789 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
790 is( $latest_auto_renew_date->truncate( to => 'minute' ),
791 $five_days_before->truncate( to => 'minute' ),
792 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
794 my $five_days_ahead = dt_from_string->add( days => 5 );
795 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = NULL');
796 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
797 is( $latest_auto_renew_date->truncate( to => 'minute' ),
798 $five_days_ahead->truncate( to => 'minute' ),
799 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
801 my $two_days_ahead = dt_from_string->add( days => 2 );
802 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 2 ) );
803 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
804 is( $latest_auto_renew_date->truncate( to => 'day' ),
805 $two_days_ahead->truncate( to => 'day' ),
806 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
808 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 2 ) );
809 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
810 is( $latest_auto_renew_date->truncate( to => 'day' ),
811 $two_days_ahead->truncate( to => 'day' ),
812 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
819 # set policy to forbid renewals
820 $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
822 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
823 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
824 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
826 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
827 t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
828 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
830 C4::Overdues::UpdateFine(
832 issue_id => $issue->id(),
833 itemnumber => $itemnumber,
834 borrowernumber => $renewing_borrower->{borrowernumber},
837 due => Koha::DateUtils::output_pref($datedue)
841 my $line = Koha::Account::Lines->search({ borrowernumber => $renewing_borrower->{borrowernumber} })->next();
842 is( $line->accounttype, 'FU', 'Account line type is FU' );
843 is( $line->lastincrement, '15.000000', 'Account line last increment is 15.00' );
844 is( $line->amountoutstanding, '15.000000', 'Account line amount outstanding is 15.00' );
845 is( $line->amount, '15.000000', 'Account line amount is 15.00' );
846 is( $line->issue_id, $issue->id, 'Account line issue id matches' );
848 my $offset = Koha::Account::Offsets->search({ debit_id => $line->id })->next();
849 is( $offset->type, 'Fine', 'Account offset type is Fine' );
850 is( $offset->amount, '15.000000', 'Account offset amount is 15.00' );
852 t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
853 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
855 LostItem( $itemnumber, 'test', 1 );
857 my $item = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber);
858 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
859 my $checkout = Koha::Checkouts->find({ itemnumber => $itemnumber });
860 is( $checkout, undef, 'LostItem called with forced return has checked in the item' );
862 my $total_due = $dbh->selectrow_array(
863 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
864 undef, $renewing_borrower->{borrowernumber}
867 is( $total_due, '15.000000', 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
869 C4::Context->dbh->do("DELETE FROM accountlines");
871 C4::Overdues::UpdateFine(
873 issue_id => $issue2->id(),
874 itemnumber => $itemnumber2,
875 borrowernumber => $renewing_borrower->{borrowernumber},
878 due => Koha::DateUtils::output_pref($datedue)
882 LostItem( $itemnumber2, 'test', 0 );
884 my $item2 = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber2);
885 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
886 ok( Koha::Checkouts->find({ itemnumber => $itemnumber2 }), 'LostItem called without forced return has checked in the item' );
888 $total_due = $dbh->selectrow_array(
889 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
890 undef, $renewing_borrower->{borrowernumber}
893 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
895 my $future = dt_from_string();
896 $future->add( days => 7 );
897 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
898 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
900 # Users cannot renew any item if there is an overdue item
901 t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
902 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber6);
903 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
904 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber7);
905 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
910 # GetUpcomingDueIssues tests
911 my $barcode = 'R00000342';
912 my $barcode2 = 'R00000343';
913 my $barcode3 = 'R00000344';
914 my $branch = $library2->{branchcode};
916 #Create another record
917 my $title2 = 'Something is worng here';
918 my ($biblionumber2, $biblioitemnumber2) = add_biblio($title2, 'Anonymous');
923 homebranch => $branch,
924 holdingbranch => $branch,
925 barcode => $barcode3,
932 my %a_borrower_data = (
933 firstname => 'Fridolyn',
935 categorycode => $patron_category->{categorycode},
936 branchcode => $branch,
939 my $a_borrower_borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
940 my $a_borrower = Koha::Patrons->find( $a_borrower_borrowernumber )->unblessed;
942 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
943 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
944 my $today = DateTime->today(time_zone => C4::Context->tz());
946 my $issue = AddIssue( $a_borrower, $barcode, $yesterday );
947 my $datedue = dt_from_string( $issue->date_due() );
948 my $issue2 = AddIssue( $a_borrower, $barcode2, $two_days_ahead );
949 my $datedue2 = dt_from_string( $issue->date_due() );
953 # GetUpcomingDueIssues tests
955 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
956 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
959 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
960 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
961 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
964 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
965 is ( scalar( @$upcoming_dues ), 1,
966 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
969 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
971 my $issue3 = AddIssue( $a_borrower, $barcode3, $today );
973 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
974 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
976 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
977 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
979 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
980 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
982 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
983 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
985 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
986 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
988 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
989 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
994 my $barcode = '1234567890';
995 my $branch = $library2->{branchcode};
997 my ($biblionumber, $biblioitemnumber) = add_biblio();
1000 my ( undef, undef, $itemnumber ) = AddItem(
1002 homebranch => $branch,
1003 holdingbranch => $branch,
1004 barcode => $barcode,
1011 my %a_borrower_data = (
1012 firstname => 'Kyle',
1014 categorycode => $patron_category->{categorycode},
1015 branchcode => $branch,
1018 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1020 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1021 my $issue = AddIssue( $borrower, $barcode );
1024 issue_id => $issue->id(),
1025 itemnumber => $itemnumber,
1026 borrowernumber => $borrowernumber,
1032 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $itemnumber );
1033 my $count = $hr->{count};
1035 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
1039 $dbh->do('DELETE FROM issues');
1040 $dbh->do('DELETE FROM items');
1041 $dbh->do('DELETE FROM issuingrules');
1044 INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod,
1045 norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
1054 my ( $biblionumber, $biblioitemnumber ) = add_biblio();
1056 my $barcode1 = '1234';
1057 my ( undef, undef, $itemnumber1 ) = AddItem(
1059 homebranch => $library2->{branchcode},
1060 holdingbranch => $library2->{branchcode},
1061 barcode => $barcode1,
1066 my $barcode2 = '4321';
1067 my ( undef, undef, $itemnumber2 ) = AddItem(
1069 homebranch => $library2->{branchcode},
1070 holdingbranch => $library2->{branchcode},
1071 barcode => $barcode2,
1077 my $borrowernumber1 = Koha::Patron->new({
1078 firstname => 'Kyle',
1080 categorycode => $patron_category->{categorycode},
1081 branchcode => $library2->{branchcode},
1082 })->store->borrowernumber;
1083 my $borrowernumber2 = Koha::Patron->new({
1084 firstname => 'Chelsea',
1086 categorycode => $patron_category->{categorycode},
1087 branchcode => $library2->{branchcode},
1088 })->store->borrowernumber;
1090 my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
1091 my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
1093 my $issue = AddIssue( $borrower1, $barcode1 );
1095 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
1096 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
1099 $library2->{branchcode}, $borrowernumber2, $biblionumber,
1100 '', 1, undef, undef, '',
1104 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
1105 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1106 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
1107 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
1109 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
1110 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1111 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
1112 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
1114 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
1115 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1116 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
1117 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
1119 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
1120 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1121 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
1122 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
1124 # Setting item not checked out to be not for loan but holdable
1125 ModItem({ notforloan => -1 }, $biblionumber, $itemnumber2);
1127 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
1128 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
1132 # Don't allow renewing onsite checkout
1133 my $barcode = 'R00000XXX';
1134 my $branch = $library->{branchcode};
1136 #Create another record
1137 my ($biblionumber, $biblioitemnumber) = add_biblio('A title', 'Anonymous');
1139 my (undef, undef, $itemnumber) = AddItem(
1141 homebranch => $branch,
1142 holdingbranch => $branch,
1143 barcode => $barcode,
1149 my $borrowernumber = Koha::Patron->new({
1152 categorycode => $patron_category->{categorycode},
1153 branchcode => $branch,
1154 })->store->borrowernumber;
1156 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1158 my $issue = AddIssue( $borrower, $barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
1159 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $itemnumber );
1160 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
1161 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1165 my $library = $builder->build({ source => 'Branch' });
1167 my ($biblionumber, $biblioitemnumber) = add_biblio();
1169 my $barcode = 'just a barcode';
1170 my ( undef, undef, $itemnumber ) = AddItem(
1172 homebranch => $library->{branchcode},
1173 holdingbranch => $library->{branchcode},
1174 barcode => $barcode,
1180 my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode} } } );
1182 my $issue = AddIssue( $patron, $barcode );
1185 issue_id => $issue->id(),
1186 itemnumber => $itemnumber,
1187 borrowernumber => $patron->{borrowernumber},
1194 issue_id => $issue->id(),
1195 itemnumber => $itemnumber,
1196 borrowernumber => $patron->{borrowernumber},
1201 is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1204 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1207 my $homebranch = $builder->build( { source => 'Branch' } );
1208 my $holdingbranch = $builder->build( { source => 'Branch' } );
1209 my $otherbranch = $builder->build( { source => 'Branch' } );
1210 my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1211 my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1213 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1214 my $item = $builder->build(
1217 homebranch => $homebranch->{branchcode},
1218 holdingbranch => $holdingbranch->{branchcode},
1219 biblionumber => $biblioitem->{biblionumber}
1224 set_userenv($holdingbranch);
1226 my $issue = AddIssue( $patron_1->unblessed, $item->{barcode} );
1227 is( ref($issue), 'Koha::Schema::Result::Issue' ); # FIXME Should be Koha::Checkout
1229 my ( $error, $question, $alerts );
1231 # AllowReturnToBranch == anywhere
1232 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1233 ## Test that unknown barcodes don't generate internal server errors
1234 set_userenv($homebranch);
1235 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
1236 ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
1237 ## Can be issued from homebranch
1238 set_userenv($homebranch);
1239 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1240 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1241 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1242 ## Can be issued from holdingbranch
1243 set_userenv($holdingbranch);
1244 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1245 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1246 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1247 ## Can be issued from another branch
1248 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1249 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1250 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1252 # AllowReturnToBranch == holdingbranch
1253 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1254 ## Cannot be issued from homebranch
1255 set_userenv($homebranch);
1256 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1257 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1258 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1259 is( $error->{branch_to_return}, $holdingbranch->{branchcode} );
1260 ## Can be issued from holdinbranch
1261 set_userenv($holdingbranch);
1262 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1263 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1264 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1265 ## Cannot be issued from another branch
1266 set_userenv($otherbranch);
1267 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1268 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1269 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1270 is( $error->{branch_to_return}, $holdingbranch->{branchcode} );
1272 # AllowReturnToBranch == homebranch
1273 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1274 ## Can be issued from holdinbranch
1275 set_userenv($homebranch);
1276 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1277 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1278 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1279 ## Cannot be issued from holdinbranch
1280 set_userenv($holdingbranch);
1281 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1282 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1283 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1284 is( $error->{branch_to_return}, $homebranch->{branchcode} );
1285 ## Cannot be issued from holdinbranch
1286 set_userenv($otherbranch);
1287 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1288 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1289 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1290 is( $error->{branch_to_return}, $homebranch->{branchcode} );
1292 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1295 subtest 'AddIssue & AllowReturnToBranch' => sub {
1298 my $homebranch = $builder->build( { source => 'Branch' } );
1299 my $holdingbranch = $builder->build( { source => 'Branch' } );
1300 my $otherbranch = $builder->build( { source => 'Branch' } );
1301 my $patron_1 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1302 my $patron_2 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1304 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1305 my $item = $builder->build(
1308 homebranch => $homebranch->{branchcode},
1309 holdingbranch => $holdingbranch->{branchcode},
1313 biblionumber => $biblioitem->{biblionumber}
1318 set_userenv($holdingbranch);
1320 my $ref_issue = 'Koha::Schema::Result::Issue'; # FIXME Should be Koha::Checkout
1321 my $issue = AddIssue( $patron_1, $item->{barcode} );
1323 my ( $error, $question, $alerts );
1325 # AllowReturnToBranch == homebranch
1326 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1327 ## Can be issued from homebranch
1328 set_userenv($homebranch);
1329 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1330 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1331 ## Can be issued from holdinbranch
1332 set_userenv($holdingbranch);
1333 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1334 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1335 ## Can be issued from another branch
1336 set_userenv($otherbranch);
1337 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1338 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1340 # AllowReturnToBranch == holdinbranch
1341 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1342 ## Cannot be issued from homebranch
1343 set_userenv($homebranch);
1344 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1345 ## Can be issued from holdingbranch
1346 set_userenv($holdingbranch);
1347 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1348 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1349 ## Cannot be issued from another branch
1350 set_userenv($otherbranch);
1351 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1353 # AllowReturnToBranch == homebranch
1354 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1355 ## Can be issued from homebranch
1356 set_userenv($homebranch);
1357 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1358 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1359 ## Cannot be issued from holdinbranch
1360 set_userenv($holdingbranch);
1361 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1362 ## Cannot be issued from another branch
1363 set_userenv($otherbranch);
1364 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1365 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1368 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1371 my $library = $builder->build( { source => 'Branch' } );
1372 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1374 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1375 my $item_1 = $builder->build(
1378 homebranch => $library->{branchcode},
1379 holdingbranch => $library->{branchcode},
1380 biblionumber => $biblioitem_1->{biblionumber}
1384 my $biblioitem_2 = $builder->build( { source => 'Biblioitem' } );
1385 my $item_2 = $builder->build(
1388 homebranch => $library->{branchcode},
1389 holdingbranch => $library->{branchcode},
1390 biblionumber => $biblioitem_2->{biblionumber}
1395 my ( $error, $question, $alerts );
1397 # Patron cannot issue item_1, they have overdues
1398 my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1399 my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, $yesterday ); # Add an overdue
1401 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1402 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1403 is( keys(%$error) + keys(%$alerts), 0, 'No key for error and alert' . str($error, $question, $alerts) );
1404 is( $question->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=confirmation, USERBLOCKEDOVERDUE should be set for question' );
1406 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1407 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1408 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1409 is( $error->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=block, USERBLOCKEDOVERDUE should be set for error' );
1411 # Patron cannot issue item_1, they are debarred
1412 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1413 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber, expiration => $tomorrow } );
1414 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1415 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1416 is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ), 'USERBLOCKEDWITHENDDATE should be tomorrow' );
1418 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber } );
1419 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1420 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1421 is( $error->{USERBLOCKEDNOENDDATE}, '9999-12-31', 'USERBLOCKEDNOENDDATE should be 9999-12-31 for unlimited debarments' );
1424 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
1427 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1428 my $patron_category_x = $builder->build_object(
1430 class => 'Koha::Patron::Categories',
1431 value => { category_type => 'X' }
1434 my $patron = $builder->build_object(
1436 class => 'Koha::Patrons',
1438 categorycode => $patron_category_x->categorycode,
1439 gonenoaddress => undef,
1446 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1447 my $item_1 = $builder->build(
1451 homebranch => $library->branchcode,
1452 holdingbranch => $library->branchcode,
1453 biblionumber => $biblioitem_1->{biblionumber}
1458 my ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_1->{barcode} );
1459 is( $error->{STATS}, 1, '"Error" flag "STATS" must be set if CanBookBeIssued is called with a statistic patron (category_type=X)' );
1461 # TODO There are other tests to provide here
1464 subtest 'MultipleReserves' => sub {
1467 my $title = 'Silence in the library';
1468 my ($biblionumber, $biblioitemnumber) = add_biblio($title, 'Moffat, Steven');
1470 my $branch = $library2->{branchcode};
1472 my $barcode1 = 'R00110001';
1473 my ( $item_bibnum1, $item_bibitemnum1, $itemnumber1 ) = AddItem(
1475 homebranch => $branch,
1476 holdingbranch => $branch,
1477 barcode => $barcode1,
1478 replacementprice => 12.00,
1484 my $barcode2 = 'R00110002';
1485 my ( $item_bibnum2, $item_bibitemnum2, $itemnumber2 ) = AddItem(
1487 homebranch => $branch,
1488 holdingbranch => $branch,
1489 barcode => $barcode2,
1490 replacementprice => 12.00,
1498 my $resdate = undef;
1499 my $expdate = undef;
1501 my $checkitem = undef;
1504 my %renewing_borrower_data = (
1505 firstname => 'John',
1506 surname => 'Renewal',
1507 categorycode => $patron_category->{categorycode},
1508 branchcode => $branch,
1510 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
1511 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
1512 my $issue = AddIssue( $renewing_borrower, $barcode1);
1513 my $datedue = dt_from_string( $issue->date_due() );
1514 is (defined $issue->date_due(), 1, "item 1 checked out");
1515 my $borrowing_borrowernumber = Koha::Checkouts->find({ itemnumber => $itemnumber1 })->borrowernumber;
1517 my %reserving_borrower_data1 = (
1518 firstname => 'Katrin',
1519 surname => 'Reservation',
1520 categorycode => $patron_category->{categorycode},
1521 branchcode => $branch,
1523 my $reserving_borrowernumber1 = Koha::Patron->new(\%reserving_borrower_data1)->store->borrowernumber;
1525 $branch, $reserving_borrowernumber1, $biblionumber,
1526 $bibitems, $priority, $resdate, $expdate, $notes,
1527 $title, $checkitem, $found
1530 my %reserving_borrower_data2 = (
1531 firstname => 'Kirk',
1532 surname => 'Reservation',
1533 categorycode => $patron_category->{categorycode},
1534 branchcode => $branch,
1536 my $reserving_borrowernumber2 = Koha::Patron->new(\%reserving_borrower_data2)->store->borrowernumber;
1538 $branch, $reserving_borrowernumber2, $biblionumber,
1539 $bibitems, $priority, $resdate, $expdate, $notes,
1540 $title, $checkitem, $found
1544 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber1, 1);
1545 is($renewokay, 0, 'Bug 17941 - should cover the case where 2 books are both reserved, so failing');
1548 my $barcode3 = 'R00110003';
1549 my ( $item_bibnum3, $item_bibitemnum3, $itemnumber3 ) = AddItem(
1551 homebranch => $branch,
1552 holdingbranch => $branch,
1553 barcode => $barcode3,
1554 replacementprice => 12.00,
1561 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber1, 1);
1562 is($renewokay, 1, 'Bug 17941 - should cover the case where 2 books are reserved, but a third one is available');
1566 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
1569 my $library = $builder->build( { source => 'Branch' } );
1570 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1572 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1573 my $biblionumber = $biblioitem->{biblionumber};
1574 my $item_1 = $builder->build(
1577 homebranch => $library->{branchcode},
1578 holdingbranch => $library->{branchcode},
1579 biblionumber => $biblionumber,
1583 my $item_2 = $builder->build(
1586 homebranch => $library->{branchcode},
1587 holdingbranch => $library->{branchcode},
1588 biblionumber => $biblionumber,
1593 my ( $error, $question, $alerts );
1594 my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, dt_from_string->add( days => 1 ) );
1596 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1597 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1598 is( keys(%$error) + keys(%$alerts), 0, 'No error or alert should be raised' . str($error, $question, $alerts) );
1599 is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' . str($error, $question, $alerts) );
1601 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1602 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1603 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1' . str($error, $question, $alerts) );
1605 # Add a subscription
1606 Koha::Subscription->new({ biblionumber => $biblionumber })->store;
1608 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1609 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1610 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription' . str($error, $question, $alerts) );
1612 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1613 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1614 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription' . str($error, $question, $alerts) );
1617 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
1620 my $library = $builder->build( { source => 'Branch' } );
1621 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1624 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1625 my $item_1 = $builder->build(
1629 homebranch => $library->{branchcode},
1630 holdingbranch => $library->{branchcode},
1634 biblionumber => $biblioitem_1->{biblionumber}
1638 my $biblioitem_2 = $builder->build( { source => 'Biblioitem' } );
1639 my $item_2 = $builder->build(
1643 homebranch => $library->{branchcode},
1644 holdingbranch => $library->{branchcode},
1648 biblionumber => $biblioitem_2->{biblionumber}
1653 # And the issuing rule
1654 Koha::IssuingRules->search->delete;
1655 my $rule = Koha::IssuingRule->new(
1657 categorycode => '*',
1662 firstremind => 1, # 1 day of grace
1663 finedays => 2, # 2 days of fine per day of overdue
1664 lengthunit => 'days',
1669 # Patron cannot issue item_1, they have overdues
1670 my $five_days_ago = dt_from_string->subtract( days => 5 );
1671 my $ten_days_ago = dt_from_string->subtract( days => 10 );
1672 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
1673 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
1674 ; # Add another overdue
1676 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
1677 AddReturn( $item_1->{barcode}, $library->{branchcode},
1678 undef, undef, dt_from_string );
1679 my $debarments = Koha::Patron::Debarments::GetDebarments(
1680 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1681 is( scalar(@$debarments), 1 );
1683 # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
1684 # Same for the others
1685 my $expected_expiration = output_pref(
1687 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 ),
1688 dateformat => 'sql',
1692 is( $debarments->[0]->{expiration}, $expected_expiration );
1694 AddReturn( $item_2->{barcode}, $library->{branchcode},
1695 undef, undef, dt_from_string );
1696 $debarments = Koha::Patron::Debarments::GetDebarments(
1697 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1698 is( scalar(@$debarments), 1 );
1699 $expected_expiration = output_pref(
1701 dt => dt_from_string->add( days => ( 10 - 1 ) * 2 ),
1702 dateformat => 'sql',
1706 is( $debarments->[0]->{expiration}, $expected_expiration );
1708 Koha::Patron::Debarments::DelUniqueDebarment(
1709 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1711 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
1712 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
1713 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
1714 ; # Add another overdue
1715 AddReturn( $item_1->{barcode}, $library->{branchcode},
1716 undef, undef, dt_from_string );
1717 $debarments = Koha::Patron::Debarments::GetDebarments(
1718 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1719 is( scalar(@$debarments), 1 );
1720 $expected_expiration = output_pref(
1722 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 ),
1723 dateformat => 'sql',
1727 is( $debarments->[0]->{expiration}, $expected_expiration );
1729 AddReturn( $item_2->{barcode}, $library->{branchcode},
1730 undef, undef, dt_from_string );
1731 $debarments = Koha::Patron::Debarments::GetDebarments(
1732 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1733 is( scalar(@$debarments), 1 );
1734 $expected_expiration = output_pref(
1736 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
1737 dateformat => 'sql',
1741 is( $debarments->[0]->{expiration}, $expected_expiration );
1744 subtest 'AddReturn + suspension_chargeperiod' => sub {
1747 my $library = $builder->build( { source => 'Branch' } );
1748 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1751 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1752 my $item_1 = $builder->build(
1756 homebranch => $library->{branchcode},
1757 holdingbranch => $library->{branchcode},
1761 biblionumber => $biblioitem_1->{biblionumber}
1766 # And the issuing rule
1767 Koha::IssuingRules->search->delete;
1768 my $rule = Koha::IssuingRule->new(
1770 categorycode => '*',
1775 firstremind => 0, # 0 day of grace
1776 finedays => 2, # 2 days of fine per day of overdue
1777 suspension_chargeperiod => 1,
1778 lengthunit => 'days',
1783 my $five_days_ago = dt_from_string->subtract( days => 5 );
1784 # We want to charge 2 days every day, without grace
1785 # With 5 days of overdue: 5 * Z
1786 my $expected_expiration = dt_from_string->add( days => ( 5 * 2 ) / 1 );
1787 test_debarment_on_checkout(
1790 library => $library,
1792 due_date => $five_days_ago,
1793 expiration_date => $expected_expiration,
1797 # We want to charge 2 days every 2 days, without grace
1798 # With 5 days of overdue: (5 * 2) / 2
1799 $rule->suspension_chargeperiod(2)->store;
1800 $expected_expiration = dt_from_string->add( days => floor( 5 * 2 ) / 2 );
1801 test_debarment_on_checkout(
1804 library => $library,
1806 due_date => $five_days_ago,
1807 expiration_date => $expected_expiration,
1811 # We want to charge 2 days every 3 days, with 1 day of grace
1812 # With 5 days of overdue: ((5-1) / 3 ) * 2
1813 $rule->suspension_chargeperiod(3)->store;
1814 $rule->firstremind(1)->store;
1815 $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 1 ) / 3 ) * 2 ) );
1816 test_debarment_on_checkout(
1819 library => $library,
1821 due_date => $five_days_ago,
1822 expiration_date => $expected_expiration,
1826 # Use finesCalendar to know if holiday must be skipped to calculate the due date
1827 # We want to charge 2 days every days, with 0 day of grace (to not burn brains)
1828 $rule->finedays(2)->store;
1829 $rule->suspension_chargeperiod(1)->store;
1830 $rule->firstremind(0)->store;
1831 t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
1833 # Adding a holiday 2 days ago
1834 my $calendar = C4::Calendar->new(branchcode => $library->{branchcode});
1835 my $two_days_ago = dt_from_string->subtract( days => 2 );
1836 $calendar->insert_single_holiday(
1837 day => $two_days_ago->day,
1838 month => $two_days_ago->month,
1839 year => $two_days_ago->year,
1840 title => 'holidayTest-2d',
1841 description => 'holidayDesc 2 days ago'
1843 # With 5 days of overdue, only 4 (x finedays=2) days must charged (one was an holiday)
1844 $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) );
1845 test_debarment_on_checkout(
1848 library => $library,
1850 due_date => $five_days_ago,
1851 expiration_date => $expected_expiration,
1855 # Adding a holiday 2 days ahead, with finesCalendar=noFinesWhenClosed it should be skipped
1856 my $two_days_ahead = dt_from_string->add( days => 2 );
1857 $calendar->insert_single_holiday(
1858 day => $two_days_ahead->day,
1859 month => $two_days_ahead->month,
1860 year => $two_days_ahead->year,
1861 title => 'holidayTest+2d',
1862 description => 'holidayDesc 2 days ahead'
1865 # Same as above, but we should skip D+2
1866 $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) + 1 );
1867 test_debarment_on_checkout(
1870 library => $library,
1872 due_date => $five_days_ago,
1873 expiration_date => $expected_expiration,
1877 # Adding another holiday, day of expiration date
1878 my $expected_expiration_dt = dt_from_string($expected_expiration);
1879 $calendar->insert_single_holiday(
1880 day => $expected_expiration_dt->day,
1881 month => $expected_expiration_dt->month,
1882 year => $expected_expiration_dt->year,
1883 title => 'holidayTest_exp',
1884 description => 'holidayDesc on expiration date'
1886 # Expiration date will be the day after
1887 test_debarment_on_checkout(
1890 library => $library,
1892 due_date => $five_days_ago,
1893 expiration_date => $expected_expiration_dt->clone->add( days => 1 ),
1897 test_debarment_on_checkout(
1900 library => $library,
1902 return_date => dt_from_string->add(days => 5),
1903 expiration_date => dt_from_string->add(days => 5 + (5 * 2 - 1) ),
1908 subtest 'AddReturn | is_overdue' => sub {
1911 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
1912 t::lib::Mocks::mock_preference('finesMode', 'production');
1913 t::lib::Mocks::mock_preference('MaxFine', '100');
1915 my $library = $builder->build( { source => 'Branch' } );
1916 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1918 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1919 my $item = $builder->build(
1923 homebranch => $library->{branchcode},
1924 holdingbranch => $library->{branchcode},
1928 biblionumber => $biblioitem->{biblionumber},
1933 Koha::IssuingRules->search->delete;
1934 my $rule = Koha::IssuingRule->new(
1936 categorycode => '*',
1941 lengthunit => 'days',
1942 fine => 1, # Charge 1 every day of overdue
1948 my $one_day_ago = dt_from_string->subtract( days => 1 );
1949 my $five_days_ago = dt_from_string->subtract( days => 5 );
1950 my $ten_days_ago = dt_from_string->subtract( days => 10 );
1951 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1953 # No date specify, today will be used
1954 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
1955 AddReturn( $item->{barcode}, $library->{branchcode} );
1956 is( int($patron->account->balance()), 10, 'Patron should have a charge of 10 (10 days x 1)' );
1957 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1959 # specify return date 5 days before => no overdue
1960 AddIssue( $patron->unblessed, $item->{barcode}, $five_days_ago ); # date due was 5d ago
1961 AddReturn( $item->{barcode}, $library->{branchcode}, undef, undef, $ten_days_ago );
1962 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
1963 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1965 # specify return date 5 days later => overdue
1966 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
1967 AddReturn( $item->{barcode}, $library->{branchcode}, undef, undef, $five_days_ago );
1968 is( int($patron->account->balance()), 5, 'AddReturn: pass return_date => overdue' );
1969 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1971 # specify dropbox date 5 days before => no overdue
1972 AddIssue( $patron->unblessed, $item->{barcode}, $five_days_ago ); # date due was 5d ago
1973 AddReturn( $item->{barcode}, $library->{branchcode}, undef, 1, undef, $ten_days_ago );
1974 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
1975 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1977 # specify dropbox date 5 days later => overdue, or... not
1978 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
1979 AddReturn( $item->{barcode}, $library->{branchcode}, undef, 1, undef, $five_days_ago );
1980 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue in dropbox mode' ); # FIXME? This is weird, the FU fine is created ( _CalculateAndUpdateFine > C4::Overdues::UpdateFine ) then remove later (in _FixOverduesOnReturn). Looks like it is a feature
1981 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
1984 subtest '_FixAccountForLostAndReturned' => sub {
1988 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
1989 t::lib::Mocks::mock_preference( 'WhenLostForgiveFine', 0 );
1991 my $processfee_amount = 20;
1992 my $replacement_amount = 99.00;
1993 my $item_type = $builder->build_object(
1994 { class => 'Koha::ItemTypes',
1996 notforloan => undef,
1998 defaultreplacecost => undef,
1999 processfee => $processfee_amount
2003 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2005 # Generate test biblio
2006 my $title = 'Koha for Dummies';
2007 my ( $biblionumber, $biblioitemnumber ) = add_biblio( $title, 'Hall, Daria' );
2009 subtest 'Full write-off tests' => sub {
2013 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2014 my $barcode = 'KD123456789';
2016 my ( undef, undef, $item_id ) = AddItem(
2017 { homebranch => $library->branchcode,
2018 holdingbranch => $library->branchcode,
2019 barcode => $barcode,
2020 replacementprice => $replacement_amount,
2021 itype => $item_type->itemtype
2026 AddIssue( $patron->unblessed, $barcode );
2028 # Simulate item marked as lost
2029 ModItem( { itemlost => 3 }, $biblionumber, $item_id );
2030 LostItem( $item_id, 1 );
2032 my $processing_fee_lines = Koha::Account::Lines->search(
2033 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'PF' } );
2034 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2035 my $processing_fee_line = $processing_fee_lines->next;
2036 is( $processing_fee_line->amount + 0,
2037 $processfee_amount, 'The right PF amount is generated' );
2038 is( $processing_fee_line->amountoutstanding + 0,
2039 $processfee_amount, 'The right PF amountoutstanding is generated' );
2041 my $lost_fee_lines = Koha::Account::Lines->search(
2042 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'L' } );
2043 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2044 my $lost_fee_line = $lost_fee_lines->next;
2045 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2046 is( $lost_fee_line->amountoutstanding + 0,
2047 $replacement_amount, 'The right L amountountstanding is generated' );
2049 my $account = $patron->account;
2050 my $debts = $account->outstanding_debits;
2052 # Write off the debt
2053 my $credit = $account->add_credit(
2054 { amount => $account->balance,
2058 $credit->apply( { debits => $debts, offset_type => 'Writeoff' } );
2060 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item_id, $patron->id );
2061 is( $credit_return_id, undef, 'No CR account line added' );
2063 $lost_fee_line->discard_changes; # reload from DB
2064 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2065 is( $lost_fee_line->accounttype,
2066 'LR', 'Lost fee now has account type of LR ( Lost Returned )' );
2068 is( $patron->account->balance, -0, 'The patron balance is 0, everything was written off' );
2071 subtest 'Full payment tests' => sub {
2075 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2076 my $barcode = 'KD123456790';
2078 my ( undef, undef, $item_id ) = AddItem(
2079 { homebranch => $library->branchcode,
2080 holdingbranch => $library->branchcode,
2081 barcode => $barcode,
2082 replacementprice => $replacement_amount,
2083 itype => $item_type->itemtype
2088 AddIssue( $patron->unblessed, $barcode );
2090 # Simulate item marked as lost
2091 ModItem( { itemlost => 1 }, $biblionumber, $item_id );
2092 LostItem( $item_id, 1 );
2094 my $processing_fee_lines = Koha::Account::Lines->search(
2095 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'PF' } );
2096 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2097 my $processing_fee_line = $processing_fee_lines->next;
2098 is( $processing_fee_line->amount + 0,
2099 $processfee_amount, 'The right PF amount is generated' );
2100 is( $processing_fee_line->amountoutstanding + 0,
2101 $processfee_amount, 'The right PF amountoutstanding is generated' );
2103 my $lost_fee_lines = Koha::Account::Lines->search(
2104 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'L' } );
2105 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2106 my $lost_fee_line = $lost_fee_lines->next;
2107 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2108 is( $lost_fee_line->amountoutstanding + 0,
2109 $replacement_amount, 'The right L amountountstanding is generated' );
2111 my $account = $patron->account;
2112 my $debts = $account->outstanding_debits;
2114 # Write off the debt
2115 my $credit = $account->add_credit(
2116 { amount => $account->balance,
2120 $credit->apply( { debits => $debts, offset_type => 'Payment' } );
2122 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item_id, $patron->id );
2123 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2125 is( $credit_return->accounttype, 'CR', 'An account line of type CR is added' );
2126 is( $credit_return->amount + 0,
2127 -99.00, 'The account line of type CR has an amount of -99' );
2128 is( $credit_return->amountoutstanding + 0,
2129 -99.00, 'The account line of type CR has an amountoutstanding of -99' );
2131 $lost_fee_line->discard_changes;
2132 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2133 is( $lost_fee_line->accounttype,
2134 'LR', 'Lost fee now has account type of LR ( Lost Returned )' );
2136 is( $patron->account->balance,
2137 -99, 'The patron balance is -99, a credit that equals the lost fee payment' );
2140 subtest 'Test without payment or write off' => sub {
2144 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2145 my $barcode = 'KD123456791';
2147 my ( undef, undef, $item_id ) = AddItem(
2148 { homebranch => $library->branchcode,
2149 holdingbranch => $library->branchcode,
2150 barcode => $barcode,
2151 replacementprice => $replacement_amount,
2152 itype => $item_type->itemtype
2157 AddIssue( $patron->unblessed, $barcode );
2159 # Simulate item marked as lost
2160 ModItem( { itemlost => 3 }, $biblionumber, $item_id );
2161 LostItem( $item_id, 1 );
2163 my $processing_fee_lines = Koha::Account::Lines->search(
2164 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'PF' } );
2165 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2166 my $processing_fee_line = $processing_fee_lines->next;
2167 is( $processing_fee_line->amount + 0,
2168 $processfee_amount, 'The right PF amount is generated' );
2169 is( $processing_fee_line->amountoutstanding + 0,
2170 $processfee_amount, 'The right PF amountoutstanding is generated' );
2172 my $lost_fee_lines = Koha::Account::Lines->search(
2173 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'L' } );
2174 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2175 my $lost_fee_line = $lost_fee_lines->next;
2176 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2177 is( $lost_fee_line->amountoutstanding + 0,
2178 $replacement_amount, 'The right L amountountstanding is generated' );
2180 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item_id, $patron->id );
2181 is( $credit_return_id, undef, 'No CR account line added' );
2183 $lost_fee_line->discard_changes;
2184 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2185 is( $lost_fee_line->accounttype, 'LR', 'Lost fee now has account type of LR ( Lost Returned )' );
2187 is( $patron->account->balance, 20, 'The patron balance is 20, still owes the processing fee' );
2190 subtest 'Test with partial payement and write off, and remaining debt' => sub {
2194 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2195 my $barcode = 'KD123456792';
2197 my ( undef, undef, $item_id ) = AddItem(
2198 { homebranch => $library->branchcode,
2199 holdingbranch => $library->branchcode,
2200 barcode => $barcode,
2201 replacementprice => $replacement_amount,
2202 itype => $item_type->itemtype
2207 AddIssue( $patron->unblessed, $barcode );
2209 # Simulate item marked as lost
2210 ModItem( { itemlost => 1 }, $biblionumber, $item_id );
2211 LostItem( $item_id, 1 );
2213 my $processing_fee_lines = Koha::Account::Lines->search(
2214 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'PF' } );
2215 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2216 my $processing_fee_line = $processing_fee_lines->next;
2217 is( $processing_fee_line->amount + 0,
2218 $processfee_amount, 'The right PF amount is generated' );
2219 is( $processing_fee_line->amountoutstanding + 0,
2220 $processfee_amount, 'The right PF amountoutstanding is generated' );
2222 my $lost_fee_lines = Koha::Account::Lines->search(
2223 { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'L' } );
2224 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2225 my $lost_fee_line = $lost_fee_lines->next;
2226 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
2227 is( $lost_fee_line->amountoutstanding + 0,
2228 $replacement_amount, 'The right L amountountstanding is generated' );
2230 my $account = $patron->account;
2231 is( $account->balance, $processfee_amount + $replacement_amount, 'Balance is PF + L' );
2234 my $payment_amount = 27;
2235 my $payment = $account->add_credit(
2236 { amount => $payment_amount,
2241 $payment->apply( { debits => $lost_fee_lines->reset, offset_type => 'Payment' } );
2243 # Partially write off fee
2244 my $write_off_amount = 25;
2245 my $write_off = $account->add_credit(
2246 { amount => $write_off_amount,
2250 $write_off->apply( { debits => $lost_fee_lines->reset, offset_type => 'Writeoff' } );
2252 is( $account->balance,
2253 $processfee_amount + $replacement_amount - $payment_amount - $write_off_amount,
2254 'Payment and write off applied'
2257 my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item_id, $patron->id );
2258 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2260 is( $account->balance, $processfee_amount - $payment_amount, 'Balance is PF - payment (CR)' );
2262 is( $credit_return->accounttype, 'CR', 'An account line of type CR is added' );
2263 is( $credit_return->amount + 0,
2264 $payment_amount * -1,
2265 'The account line of type CR has an amount equal to the payment'
2267 is( $credit_return->amountoutstanding + 0,
2268 $payment_amount * -1,
2269 'The account line of type CR has an amountoutstanding equal to the payment'
2272 $lost_fee_line->discard_changes;
2273 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2274 is( $lost_fee_line->accounttype,
2275 'LR', 'Lost fee now has account type of LR ( Lost Returned )' );
2277 is( $account->balance,
2278 $processfee_amount - $payment_amount,
2279 'The patron balance is the difference between the PF and the credit'
2284 subtest '_FixOverduesOnReturn' => sub {
2287 # Generate test biblio
2288 my $title = 'Koha for Dummies';
2289 my ( $biblionumber, $biblioitemnumber ) = add_biblio($title, 'Hall, Kylie');
2291 my $barcode = 'KD987654321';
2292 my $branchcode = $library2->{branchcode};
2294 my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
2296 homebranch => $branchcode,
2297 holdingbranch => $branchcode,
2298 barcode => $barcode,
2299 replacementprice => 99.00,
2305 my $patron = $builder->build( { source => 'Borrower' } );
2307 ## Start with basic call, should just close out the open fine
2308 my $accountline = Koha::Account::Line->new(
2310 borrowernumber => $patron->{borrowernumber},
2311 accounttype => 'FU',
2312 itemnumber => $itemnumber,
2314 amountoutstanding => 99.00,
2315 lastincrement => 9.00,
2319 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $itemnumber );
2321 $accountline->_result()->discard_changes();
2323 is( $accountline->amountoutstanding, '99.000000', 'Fine has the same amount outstanding as previously' );
2324 is( $accountline->accounttype, 'F', 'Open fine ( account type FU ) has been closed out ( account type F )');
2327 ## Run again, with exemptfine enabled
2330 accounttype => 'FU',
2331 amountoutstanding => 99.00,
2335 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $itemnumber, 1 );
2337 $accountline->_result()->discard_changes();
2339 is( $accountline->amountoutstanding + 0, 0, 'Fine has been reduced to 0' );
2340 is( $accountline->accounttype, 'FFOR', 'Open fine ( account type FU ) has been set to fine forgiven ( account type FFOR )');
2342 ## Run again, with dropbox mode enabled
2345 accounttype => 'FU',
2346 amountoutstanding => 99.00,
2350 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $itemnumber, 0, 1 );
2352 $accountline->_result()->discard_changes();
2354 is( $accountline->amountoutstanding + 0, 90, 'Fine has been reduced to 90' );
2355 is( $accountline->accounttype, 'F', 'Open fine ( account type FU ) has been closed out ( account type F )');
2358 subtest 'Set waiting flag' => sub {
2361 my $library_1 = $builder->build( { source => 'Branch' } );
2362 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2363 my $library_2 = $builder->build( { source => 'Branch' } );
2364 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2366 my $biblio = $builder->build( { source => 'Biblio' } );
2367 my $biblioitem = $builder->build( { source => 'Biblioitem', value => { biblionumber => $biblio->{biblionumber} } } );
2369 my $item = $builder->build(
2373 homebranch => $library_1->{branchcode},
2374 holdingbranch => $library_1->{branchcode},
2378 biblionumber => $biblioitem->{biblionumber},
2383 set_userenv( $library_2 );
2384 my $reserve_id = AddReserve(
2385 $library_2->{branchcode}, $patron_2->{borrowernumber}, $biblioitem->{biblionumber},
2386 '', 1, undef, undef, '', undef, $item->{itemnumber},
2389 set_userenv( $library_1 );
2390 my $do_transfer = 1;
2391 my ( $res, $rr ) = AddReturn( $item->{barcode}, $library_1->{branchcode} );
2392 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2393 my $hold = Koha::Holds->find( $reserve_id );
2394 is( $hold->found, 'T', 'Hold is in transit' );
2396 my ( $status ) = CheckReserves($item->{itemnumber});
2397 is( $status, 'Reserved', 'Hold is not waiting yet');
2399 set_userenv( $library_2 );
2401 AddReturn( $item->{barcode}, $library_2->{branchcode} );
2402 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2403 $hold = Koha::Holds->find( $reserve_id );
2404 is( $hold->found, 'W', 'Hold is waiting' );
2405 ( $status ) = CheckReserves($item->{itemnumber});
2406 is( $status, 'Waiting', 'Now the hold is waiting');
2409 subtest 'CanBookBeIssued | is_overdue' => sub {
2412 # Set a simple circ policy
2413 $dbh->do('DELETE FROM issuingrules');
2415 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
2416 maxissueqty, issuelength, lengthunit,
2417 renewalsallowed, renewalperiod,
2418 norenewalbefore, auto_renew,
2435 my $five_days_go = output_pref({ dt => dt_from_string->add( days => 5 ), dateonly => 1});
2436 my $ten_days_go = output_pref({ dt => dt_from_string->add( days => 10), dateonly => 1 });
2437 my $library = $builder->build( { source => 'Branch' } );
2438 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
2440 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
2441 my $item = $builder->build(
2445 homebranch => $library->{branchcode},
2446 holdingbranch => $library->{branchcode},
2450 biblionumber => $biblioitem->{biblionumber},
2455 my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $five_days_go ); # date due was 10d ago
2456 my $actualissue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } );
2457 is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
2458 my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->{barcode},$ten_days_go, undef, undef, undef);
2459 is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
2460 is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
2463 subtest 'ItemsDeniedRenewal preference' => sub {
2466 C4::Context->set_preference('ItemsDeniedRenewal','');
2468 my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
2471 INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod,
2472 norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
2475 '*', $idr_lib->branchcode, '*', 25,
2482 my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
2483 homebranch => $idr_lib->branchcode,
2487 itemcallnumber => undef,
2491 my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
2492 homebranch => $idr_lib->branchcode,
2495 location => 'NOPROC'
2499 my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
2500 branchcode => $idr_lib->branchcode,
2503 my $future = dt_from_string->add( days => 1 );
2504 my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
2505 returndate => undef,
2508 borrowernumber => $idr_borrower->borrowernumber,
2509 itemnumber => $deny_book->itemnumber,
2510 onsite_checkout => 0,
2511 date_due => $future,
2514 my $allow_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
2515 returndate => undef,
2518 borrowernumber => $idr_borrower->borrowernumber,
2519 itemnumber => $allow_book->itemnumber,
2520 onsite_checkout => 0,
2521 date_due => $future,
2527 my ( $idr_mayrenew, $idr_error ) =
2528 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2529 is( $idr_mayrenew, 1, 'Renewal allowed when no rules' );
2530 is( $idr_error, undef, 'Renewal allowed when no rules' );
2532 $idr_rules="withdrawn: [1]";
2534 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2535 ( $idr_mayrenew, $idr_error ) =
2536 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2537 is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
2538 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
2539 ( $idr_mayrenew, $idr_error ) =
2540 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2541 is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );
2542 is( $idr_error, undef, 'Renewal allowed when 1 rules not matched (withdrawn)' );
2544 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
2546 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2547 ( $idr_mayrenew, $idr_error ) =
2548 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2549 is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
2550 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
2551 ( $idr_mayrenew, $idr_error ) =
2552 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2553 is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
2554 is( $idr_error, undef, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
2556 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
2558 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2559 ( $idr_mayrenew, $idr_error ) =
2560 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2561 is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
2562 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
2563 ( $idr_mayrenew, $idr_error ) =
2564 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2565 is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
2566 is( $idr_error, undef, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
2568 $idr_rules="itemcallnumber: [NULL]";
2569 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2570 ( $idr_mayrenew, $idr_error ) =
2571 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2572 is( $idr_mayrenew, 0, 'Renewal blocked for undef when NULL in pref' );
2573 $idr_rules="itemcallnumber: ['']";
2574 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2575 ( $idr_mayrenew, $idr_error ) =
2576 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2577 is( $idr_mayrenew, 1, 'Renewal not blocked for undef when "" in pref' );
2579 $idr_rules="itemnotes: [NULL]";
2580 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2581 ( $idr_mayrenew, $idr_error ) =
2582 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2583 is( $idr_mayrenew, 1, 'Renewal not blocked for "" when NULL in pref' );
2584 $idr_rules="itemnotes: ['']";
2585 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2586 ( $idr_mayrenew, $idr_error ) =
2587 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2588 is( $idr_mayrenew, 0, 'Renewal blocked for empty string when "" in pref' );
2591 subtest 'CanBookBeIssued | item-level_itypes=biblio' => sub {
2594 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
2595 my $library = $builder->build( { source => 'Branch' } );
2596 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
2598 my $itemtype = $builder->build(
2600 source => 'Itemtype',
2601 value => { notforloan => undef, }
2605 my $biblioitem = $builder->build( { source => 'Biblioitem', value => { itemtype => $itemtype->{itemtype} } } );
2606 my $item = $builder->build_object(
2608 class => 'Koha::Items',
2610 homebranch => $library->{branchcode},
2611 holdingbranch => $library->{branchcode},
2615 biblionumber => $biblioitem->{biblionumber},
2616 biblioitemnumber => $biblioitem->{biblioitemnumber},
2621 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2622 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2623 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2626 subtest 'CanBookBeIssued | notforloan' => sub {
2629 t::lib::Mocks::mock_preference('AllowNotForLoanOverride', 0);
2631 my $library = $builder->build( { source => 'Branch' } );
2632 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
2634 my $itemtype = $builder->build(
2636 source => 'Itemtype',
2637 value => { notforloan => undef, }
2641 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
2642 my $item = $builder->build_object(
2644 class => 'Koha::Items',
2646 homebranch => $library->{branchcode},
2647 holdingbranch => $library->{branchcode},
2651 itype => $itemtype->{itemtype},
2652 biblionumber => $biblioitem->{biblionumber},
2653 biblioitemnumber => $biblioitem->{biblioitemnumber},
2658 my ( $issuingimpossible, $needsconfirmation );
2661 subtest 'item-level_itypes = 1' => sub {
2664 t::lib::Mocks::mock_preference('item-level_itypes', 1); # item
2665 # Is for loan at item type and item level
2666 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2667 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2668 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2670 # not for loan at item type level
2671 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
2672 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2673 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2676 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
2677 'Item can not be issued, not for loan at item type level'
2680 # not for loan at item level
2681 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
2682 $item->notforloan( 1 )->store;
2683 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2684 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2687 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
2688 'Item can not be issued, not for loan at item type level'
2692 subtest 'item-level_itypes = 0' => sub {
2695 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
2697 # We set another itemtype for biblioitem
2698 my $itemtype = $builder->build(
2700 source => 'Itemtype',
2701 value => { notforloan => undef, }
2705 # for loan at item type and item level
2706 $item->notforloan(0)->store;
2707 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
2708 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2709 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2710 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2712 # not for loan at item type level
2713 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
2714 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2715 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2718 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
2719 'Item can not be issued, not for loan at item type level'
2722 # not for loan at item level
2723 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
2724 $item->notforloan( 1 )->store;
2725 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2726 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2729 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
2730 'Item can not be issued, not for loan at item type level'
2734 # TODO test with AllowNotForLoanOverride = 1
2737 subtest 'AddReturn should clear items.onloan for unissued items' => sub {
2740 t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' );
2741 my $item = $builder->build_object({ class => 'Koha::Items', value => { onloan => '2018-01-01' }});
2742 AddReturn( $item->barcode, $item->homebranch );
2743 $item->discard_changes; # refresh
2744 is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
2747 $schema->storage->txn_rollback;
2748 C4::Context->clear_syspref_cache();
2749 $cache->clear_from_cache('single_holidays');
2752 my ( $library ) = @_;
2753 C4::Context->set_userenv(0,0,0,'firstname','surname', $library->{branchcode}, $library->{branchname}, '', '', '');
2757 my ( $error, $question, $alert ) = @_;
2759 $s = %$error ? ' (error: ' . join( ' ', keys %$error ) . ')' : '';
2760 $s .= %$question ? ' (question: ' . join( ' ', keys %$question ) . ')' : '';
2761 $s .= %$alert ? ' (alert: ' . join( ' ', keys %$alert ) . ')' : '';
2766 my ($title, $author) = @_;
2768 my $marcflavour = C4::Context->preference('marcflavour');
2770 my $biblio = MARC::Record->new();
2772 my $tag = $marcflavour eq 'UNIMARC' ? '200' : '245';
2773 $biblio->append_fields(
2774 MARC::Field->new($tag, ' ', ' ', a => $title),
2779 my ($tag, $code) = $marcflavour eq 'UNIMARC' ? (200, 'f') : (100, 'a');
2780 $biblio->append_fields(
2781 MARC::Field->new($tag, ' ', ' ', $code => $author),
2785 return AddBiblio($biblio, '');
2788 sub test_debarment_on_checkout {
2790 my $item = $params->{item};
2791 my $library = $params->{library};
2792 my $patron = $params->{patron};
2793 my $due_date = $params->{due_date} || dt_from_string;
2794 my $return_date = $params->{return_date} || dt_from_string;
2795 my $expected_expiration_date = $params->{expiration_date};
2797 $expected_expiration_date = output_pref(
2799 dt => $expected_expiration_date,
2800 dateformat => 'sql',
2804 my @caller = caller;
2805 my $line_number = $caller[2];
2806 AddIssue( $patron, $item->{barcode}, $due_date );
2808 my ( undef, $message ) = AddReturn( $item->{barcode}, $library->{branchcode},
2809 undef, undef, $return_date );
2810 is( $message->{WasReturned} && exists $message->{Debarred}, 1, 'AddReturn must have debarred the patron' )
2811 or diag('AddReturn returned message ' . Dumper $message );
2812 my $debarments = Koha::Patron::Debarments::GetDebarments(
2813 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2814 is( scalar(@$debarments), 1, 'Test at line ' . $line_number );
2816 is( $debarments->[0]->{expiration},
2817 $expected_expiration_date, 'Test at line ' . $line_number );
2818 Koha::Patron::Debarments::DelUniqueDebarment(
2819 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );