Bug 27209: (follow-up) Add ->is_pickup_location_valid
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 14 Dec 2020 10:37:53 +0000 (07:37 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 28 Dec 2020 13:41:08 +0000 (14:41 +0100)
commit02df63c430df50d0d6985be23c4e5a98142b8a30
treeec2c4ef96d3d66c7dab4081fbd4cc3e95ed5b187
parent18578794d9e5ac3c5e5c0548989224149bccae60
Bug 27209: (follow-up) Add ->is_pickup_location_valid

This patch simply refactors the pickup location check into a method that
can be called on its own. Tests are added, and the tests for
->set_pickup_location should pass unmodified.

To test:
1. Apply the first two patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: tests pass
3. Apply this refactoring patch
4. Notice the tests are similar, but check for boolean output
5. Repeat 2
=> SUCCESS: New tests pass, set_pickup_location() behavior unchanged.
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 865a1dab5c346920c61237c4b7593202328e04f8)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Hold.pm
t/db_dependent/Koha/Hold.t