]> git.koha-community.org Git - koha.git/commit
Bug 24614: Use Koha::Reports from save_report and update_sql
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 11 Feb 2020 16:21:38 +0000 (17:21 +0100)
committerJoy Nelson <joy@bywatersolutions.com>
Fri, 3 Apr 2020 22:38:29 +0000 (22:38 +0000)
commit0a6c345703d46f4da4714dd5fa9ae673fab94ec6
tree7da82377e1c9d7fb9bab465c4877cafc899074bd
parentd3d27f48d8672a5d5f679647a7265ba1fd9bb11e
Bug 24614: Use Koha::Reports from save_report and update_sql

In order to get the default value defined at DBMS level, we use
Koha::Reports (to inherit from Koha::Object->store) from the 2 add/edit
methods of C4::Reports::Guided.
A second step would be to remove completely those CRUD subroutines and
use directly Koha::Reports instead.

Test plan:
1. Add and edit some reports
2. Disable memcached, create a report, edit it
=> Should not crash
3. Make sure the tests make sense and that they pass after the second
patch.

The error was:
DBD::mysql::db do failed: Column 'cache_expiry' cannot be null [for
Statement "UPDATE saved_sql SET savedsql = ?, last_modified = now(),
report_name = ?, report_group = ?, report_subgroup = ?, notes = ?,
cache_expiry = ?, public = ? WHERE id = ? "] at
/kohadevbox/koha/C4/Reports/Guided.pm line 633.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
C4/Reports/Guided.pm