Bug 24964: Restore pagination for patrons for owner/users of funds
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 6 Apr 2020 09:44:18 +0000 (11:44 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 6 Apr 2020 09:57:10 +0000 (10:57 +0100)
commit25fa93a40683870c0e9c0fd96d839878aa2229c6
tree44f22d0b669ffab5612d05ea2c04218bef0f64ba
parent57333cda12111dd9582eabaa06069eda2dd154f5
Bug 24964: Restore pagination for patrons for owner/users of funds

admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only
retrieve patrons with acq (order_manage) permissions.

The original bug was hidden in the existing code, but the behavior was
terrible.
To prevent patrons matching the permissions contrainst to be hidden, we
fetched ALL the patrons from the DB, then filtered them depending on
their permissions. This might have awful performance on DB with lot of
patrons.

So basically with this patch we are adding the pagination back to the
"owner/users for funds" feature, as the permission filtering is now done
at DB level.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt