]> git.koha-community.org Git - koha.git/commit
Bug 24396: Fix Suggestions.t with MySQL 8
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 10 Jan 2020 10:29:15 +0000 (11:29 +0100)
committerJoy Nelson <joy@bywatersolutions.com>
Thu, 30 Jan 2020 23:46:20 +0000 (23:46 +0000)
commit4f2cac32a58905aab7f81071d27248174f932bad
treef602eb98b2886a6147b56c93823f0ad11987ff09
parent4c715fa0dbb0a92454b1e3012af8884ad4e12300
Bug 24396: Fix Suggestions.t with MySQL 8

 #   Failed test 'DelSuggestion deletes the correct suggestion'
 #   at t/db_dependent/Suggestions.t line 413.
 #          got: 'my title 3'
 #     expected: 'my deleted title'
 t/db_dependent/Suggestions.t .. 112/113 # Looks like you failed 1 test of 113.

Suggestions were returned in the reverse order. Adding an ORDER BY clause fixes the problem.

Test plan:
 % prove t/db_dependent/Suggestions.t
must return green

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
C4/Suggestions.pm