Bug 28986: Remove (All) notation to correctly select rule for editing
authorNick Clemens <nick@bywatersolutions.com>
Thu, 9 Sep 2021 15:21:10 +0000 (15:21 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 6 Oct 2021 20:10:02 +0000 (10:10 -1000)
commit68b32ac3bd4c3a9d152a3ced036d1fd933926c8c
treefe1e8fb3855e4dd0b991a22f00339fc93755039f
parent2d08f38a001a8701d722fa2da25952d3091c186b
Bug 28986: Remove (All) notation to correctly select rule for editing

This patch updates the JS comparison code to remove the '(All)' hint before comparing
to the current value

To test:
1 - Go to Administration -> Item types
2 - Edit a type to have a parent of another type
3 - Go to Administration -> Circulation and fines rules
4 - Add a rule for all categories for the child itemtype
5 - Add a rule for all categories for the parent itemtype
6 - Click edit on child type, note itemtype dropdown in editor correctly selected
7 - Click edit on parent type - note itemtype dropdown menu refers to 'All' itemtypes
8 - Apply patch
9 - Reload page and edit parent type rule
10 - Itemtype dropdown is correctly populated

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 5abd74c805cecb13c740cbcdf7764bfd1eb4cda8)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt