Bug 23059: reserve_stats.pl: Simplify reservestatus
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 23 May 2023 12:41:56 +0000 (12:41 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 20 Oct 2023 17:44:06 +0000 (14:44 -0300)
commit69ed355977d94f9abaeab00d394f903ff275c876
treee75b41db9e2f7fe056a9e49b158faa16eee55a82
parent8f86dcdce24a99d52dae0810e192797097cdd479
Bug 23059: reserve_stats.pl: Simplify reservestatus

This patch does the following:
[1] Go back to four statuses: Cancelled, Filled, Waiting or Placed.
    Placed is used as collective name for all other statuses: pending
    (placed), processing (found==P) or transit (found==T). Placed before
    anyway.
[2] Allow translation of these statuses in the template. Remove the sub
    reservestatushuman.
[3] The output of changeifreservestatus is considerably shorter and less
    ugly in the constructed sql statement.

Test plan:
[1] Use reservestatus as row, as column and only as filter (clicking few
    statuses).
[2] Verify that the shown statistics meet your expectations.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt
reports/reserves_stats.pl