]> git.koha-community.org Git - koha.git/commit
Bug 24719: Remove use of CGI object in C4::Context::set_remote_address()
authorDavid Cook <dcook@prosentient.com.au>
Thu, 27 Feb 2020 00:28:48 +0000 (00:28 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Wed, 1 Apr 2020 22:16:47 +0000 (22:16 +0000)
commit74e3ef126c5992ac049a35c75a7d3879669d7a49
tree733a6b528c0509495561641434578dbb1c05d033
parenta3143506b2edf7ffca185e650c18b89dc249423f
Bug 24719: Remove use of CGI object in C4::Context::set_remote_address()

This patch replaces the CGI "http" object method with its equivalent
class method, which doesn't require object instantiation and thus skips
global initialization and premature handling of the incoming HTTP request.

Test plan:
0. Disable Plack if it is enabled
1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1
2. Clear Memcached
3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
4. Note that form below "Upload progress" never appears and errors show
in browser console
5. Apply the patch
6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
7. Note that form appears below "Upload progress"

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
C4/Context.pm