Bug 30933: (follow-up) Consolidate transfer checks
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 21 Jun 2022 14:41:42 +0000 (14:41 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 20 Jul 2022 12:04:07 +0000 (09:04 -0300)
commit773779e792243f640c00be804a39f071a99ea60b
tree0a2332a17af7d45fb40bd6a1ec104f00a13d40bf
parentc46e0d89b4a3a95133a9e9de201219281a5e2cf4
Bug 30933: (follow-up) Consolidate transfer checks

Adding shelf->cannot_be_transferred with unit tests.

Note: This follow-up actually refers to comment42 on the
preceding report 25498.
Furthermore, we could still improve later on using error code
more effectively (adding codes). Here we concentrate on moving
the checks to module level.

Test plan:
Run t/db_dependent/Virtualshelves.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Virtualshelf.pm
t/db_dependent/Virtualshelves.t