Bug 30882: Add max_result_window to index config
authorFridolin Somers <fridolin.somers@biblibre.com>
Thu, 2 Jun 2022 06:24:03 +0000 (20:24 -1000)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 23 Aug 2022 17:37:04 +0000 (17:37 +0000)
commitb041f75f7be1b6e2dfdf232d8ee3e776f77277f7
tree87a108effb7791f944fcee885ecbf535f6e8b2e9
parent37e560ce88a91d716f8719e39515ab12fa9a19b7
Bug 30882: Add max_result_window to index config

Elasticsearch number of results is by default limited by setting "index.max-result-window", default value is 10000.
https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window

We use this setting:
https://git.koha-community.org/Koha-community/Koha/src/commit/44d6528b566e5c16eba9b15f8aa24667293766c3/Koha/SearchEngine/Elasticsearch/Search.pm#L411

I propose we add this setting in index config.

Test plan:
1) Use Elasticsearch
2) Apply patch and flush memcached
3) Rebuild indexes: misc/search_tools/rebuild_elasticsearch.pl -v -b -d
4) Check the settings of index (when using koha-testing-docker*):
   curl 'es:9200/koha_kohadev_biblios/_settings?pretty&filter_path=**.max_result_window'
5) You should see:
   "max_result_window" : "1000000"

* You also need to add this setting to the es section in koha-testing-docker's
docker-compose.yml (after the networks configuration):
     ports:
         - "9200:9300"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 90ef5ec8c81b6010e6d7eafc6498bc2e6a9ca8f5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
admin/searchengine/elasticsearch/index_config.yaml