Bug 24592: Reword LOST_RETURN to LOST_FOUND
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 5 Feb 2020 11:54:20 +0000 (11:54 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 13 Feb 2020 15:58:49 +0000 (15:58 +0000)
commitb9ecf361a82511a09b5487af0efd7f0d50a2b43e
tree42a8304c00eb749637b9fa3df1630e21eec8a766
parenta5a75ddd0419fabc1108b5334210692b99c49934
Bug 24592: Reword LOST_RETURN to LOST_FOUND

This patch updates the wording in the 'lost and found' process to more
closely reflect what the process is achieving by replacing 'RETURNED'
with 'FOUND'

Test plan:
1) Grep codebase for _FixAccountForLostAndReturned and note there are no
   longer any instanced of it.
2) Run t/db_dependent/Circulation.t and note it passes
3) Test returning/renewing an item that has been marked as lost and note
   the updated values in the accountlines now use LOST_FOUND as
   credit_type_code and 'FOUND' as the status for the 'LOST' fee
   (debit_type_code 'LOST')

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Circulation.pm
Koha/Account.pm
api/v1/swagger/definitions/patron_account_credit.json
koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc
t/db_dependent/Circulation.t