Bug 14103: Improved testing coverage
authorMark Tompsett <mtompset@hotmail.com>
Wed, 6 May 2015 17:56:30 +0000 (13:56 -0400)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 7 May 2015 16:06:15 +0000 (13:06 -0300)
commitc8d364ae727053e40926772ca43c1cb6ff9dc176
treee342ef30e39e9fcf2cfdfec0426bf49fa1714efb
parent0b24910100fbbe098acd2c8e4b961d0caa896e9e
Bug 14103: Improved testing coverage

As per Chris' comment #17, this improves the testing coverage.

Same test plan as comment #16, but add:

TEST PLAN SUPPLEMENT
--------------------
1) $ prove -v t/db_dependent/Borrower_Discharge.t
   -- notice only 5 tests, and generate_as_pdf not tested.
2) Apply this patch.
3) Retest as per comment #16
   -- this will test the error and no error cases
      tweaked in Koha/Borrower/Discharge.pm
4) remove PDF::HTML
   $ sudo apt-get purge libpdf-fromhtml-perl
5) $ prove -v t/db_dependent/Borrower_Discharge.t
   -- 7 tests, all successful
6) add PDF::HTML
   $ sudo dpkg -i /path/to/libpdf-fromhtml-perl...
   -- depends on how you get it. vary accordingly.
7) $ prove -v t/db_dependent/Borrower_Discharge.t
   -- 7 tests, all successful
   -- Note that is was a different 7th test. :)
8) koha qa test tools

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Koha/Borrower/Discharge.pm
t/db_dependent/Borrower_Discharge.t