Bug 28472: handle items with NULL shelving location
authorAndreas Roussos <a.roussos@dataly.gr>
Fri, 2 Jul 2021 11:12:21 +0000 (13:12 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 1 Oct 2021 17:38:33 +0000 (13:38 -0400)
commitd1bf0469d873b01b457f0f6d897443403cdbebbb
tree8714540a56dafc387fc2ec6a753298840ee37bd1
parent5abd74c805cecb13c740cbcdf7764bfd1eb4cda8
Bug 28472: handle items with NULL shelving location

The UpdateItemLocationOnCheckin System Preference can be set to update the
location of ALL items during check in, regardless of their shelving location.
However, this does not currently work 100% as it is excluding items with no
shelving location (i.e. value of NULL in the corresponding database field).

This patch, based on the comment made by Nick Clemens, fixes that.

Test plan (based on the original Bug Description by Andrew Fuerste-Henry):

1) Have a shelving location CART
2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes)
3) Check in an item that has a shelving location, confirm it changes to CART
4) Check in an item with a NULL shelving location, confirm it doesn't go to CART
5) Apply this patch
6) Repeat step 4): this time the item should move to the CART shelving location

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Circulation.pm