Bug 21311: Remove locked message from opac-auth.tt
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 10 Oct 2018 14:04:38 +0000 (16:04 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 26 Nov 2018 06:31:14 +0000 (07:31 +0100)
commite9e5e55e84624b36f317940eabb816d48612743d
treef3a91bc00fb695b8dde8f8661fca3b3e110095b1
parent5bffc862f3a59654a9ba6034de57108f08625c7b
Bug 21311: Remove locked message from opac-auth.tt

We should not expose more information than needed when someone tries
to login with invalid credentials. Saying that an account is locked
reveals that the account exists (or perhaps an email address).

Trivial fix. Keeping the var too_many_login_attempts for staff.
Note: We do not remove this distinction for the staff client here (in the
assumption that a library may well have additional security measures in
place for staff client). But it could be done too (on another report).

Test plan:
Enable lockout feature.
Enter invalid credentials until account locks out (on OPAC !!)
Note that message does no longer change to 'Account is locked'.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 716301d6f5bb149e963c5547d69d4019c20953db)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 55d687f3a7002439c6d27fb35af83333b8dfcdc4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt