]> git.koha-community.org Git - koha.git/commit
Bug 28670: Prevent api/v1/patrons_holds.t to fail randomly
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 18 Jan 2023 14:55:26 +0000 (15:55 +0100)
committerJacob O'Mara <jacob.omara@ptfs-europe.com>
Wed, 25 Jan 2023 14:33:47 +0000 (14:33 +0000)
commiteb2fbe6dd6bfc69601421773f963af784b4318bb
treee860ac47bfc177200214da7a3ec5b73dde23b388
parent472aad196d53b2e0b84ab2878a580eb5f015d6a2
Bug 28670: Prevent api/v1/patrons_holds.t to fail randomly

12:01:12 koha_1       |     #   Failed test 'Holds retrieved'
12:01:12 koha_1       |     #   at t/db_dependent/api/v1/patrons_holds.t line 56.
12:01:12 koha_1       |     #     Structures begin differing at:
12:01:12 koha_1       |     #          $got->[0]{hold_id} = '256'
12:01:12 koha_1       |     #     $expected->[0]{hold_id} = '255'
12:01:12 koha_1       |     # Looks like you failed 1 test of 9.
12:01:12 koha_1       |
12:01:12 koha_1       | #   Failed test 'list() tests'
12:01:12 koha_1       | #   at t/db_dependent/api/v1/patrons_holds.t line 70.

This is a weird one, and the only solution I see it to force the order
we want to receive the holds.

I guess we should not rely on an order if no order by clause is passed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit afcf0c95b43011aa1172c24d66b9b95b7662836b)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
t/db_dependent/api/v1/patrons_holds.t