Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 28 Apr 2022 07:43:06 +0000 (09:43 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 28 Apr 2022 20:49:20 +0000 (10:49 -1000)
commitf2d2ab18106ec9db29a66d4ce4781dae47d6792b
treeb775db02fcb7638d123b5f6e03ca0ce48f63a6ee
parentdedc0ae83f945546cbd52d5345f59bc3ecc9f101
Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON

RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item

Test plan:
1 - Enable HoldsAutoFill
2 - Place a title level hold
3 - Check in an item and confirm hold
4 - Switch to another branch
5 - Checkin the item
Without this patch you got
Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577.
 at /kohadevbox/koha/C4/Reserves.pm line 1576
With this patch applied the operation succeeds

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
circ/returns.pl