]> git.koha-community.org Git - koha.git/log
koha.git
8 years agoBug 10154: QA follow-up - Spelling and terminology
Katrin Fischer [Mon, 30 Nov 2015 23:47:54 +0000 (00:47 +0100)]
Bug 10154: QA follow-up - Spelling and terminology

- Changing capitalization: Any Patron category > Any patron category
- Changing Collection code > Collection

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 10154 Add Call number in the filter of most circulated items
Eivin Giske Skaaren [Wed, 28 Oct 2015 00:28:28 +0000 (00:28 +0000)]
Bug 10154 Add Call number in the filter of most circulated items

This patch adds call number, collection code and shelving location to
the filter.

To test:

It is of course a prerequisite to have items in the DB with the correct
MARC fields and that they have been checked out etc. to get a valid
result when testing.

1. Apply patch to koha synced to master.
2. Go to /cgi-bin/koha/reports/cat_issues_top.pl
3. Select filters, the new ones are Call number, Collection code and
   Shelving location
4. Hit submit.

Expected result:
The filters chosen will be printed under "Filtered on".
A table with the result is shown.

For manual verification here is some SQL to run:

SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues`
                  LEFT JOIN items USING(itemnumber)
                  LEFT JOIN biblio USING(biblionumber)
                  LEFT JOIN biblioitems USING(biblionumber)
                  LEFT JOIN borrowers USING(borrowernumber)
                  WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC;

Put in your valid values in the WHERE clause for the values in the
single quotes ''.

Sponsored-by: Halland county library
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  It works as described. Valid results, tested in various combinations.
  Follows the coding (awful) style of the original script, without
  introducing any regression. It would have been great to have
  callnumber interval, but anyway...

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 12923 Improve error logging for advance_notices.pl
Olli-Antti Kivilahti [Mon, 15 Sep 2014 08:42:34 +0000 (11:42 +0300)]
Bug 12923 Improve error logging for advance_notices.pl

Show borrowernumber when no letter of type is found and force utf8
output when running advance_notices.pl with -n flag, diacritics run awol
in the console output!

Also when debugging which borrower requests undefined letter templates,
it is very handy to log the borrowernumber so we catch and fix bad
borrower message transport settings.

TEST PREPARATION:

0. Edit the ODUEDGST letter, find an undefined letter for any trasport
   type.

::TESTS ARE (ALMOST) THE SAME AS IN bugg 12922::
TEST PLAN:

1. Find a borrower and from the messaging preferences set the "Advance
   notice" transport type to the undefined digest. Set the "Days in
   Advance" to 1.
2. Check-out something for that borrower and set the due date for
   tomorrow.
3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal.
4. BEFORE THIS PATCH: You get an error "no letter of type 'PREDUEDGST'
   found. Please see sample_notices.sql at ./advance_notices.pl line
   366."
4. AFTER THIS PATCH: You get an error "no letter of type 'PREDUEDGST'
   found for borrowernumber 1104659. Please see sample_notices.sql at
   ./advance_notices.pl line 368."
   Makes life more worth living for!
   Also diacritics printed on screen are displayed properly.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  I confirm the diacritics issue and solution. borrowernumber is
  displayed with warning when the 'no letter...' message is displayed.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592 - DBrev 3.23.00.011
Kyle M Hall [Thu, 31 Dec 2015 16:01:26 +0000 (16:01 +0000)]
Bug 13592 - DBrev 3.23.00.011

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592 [QA Followup] - Make the system preference description self documenting
Kyle M Hall [Fri, 18 Dec 2015 18:50:32 +0000 (18:50 +0000)]
Bug 13592 [QA Followup] - Make the system preference description self documenting

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592: Add an option to charge for any hold placed
Jonathan Druart [Wed, 11 Nov 2015 15:12:45 +0000 (15:12 +0000)]
Bug 13592: Add an option to charge for any hold placed

Currently the fee is applied on if all items for the record are issued
and at least one hold already exists on the record.
This patch does not give a complete answer to the problem (see
discussion on bug 13592 for the other user's expectations).
It only adds the ability to charge for any hold placed regardless of the
conditions.

Test plan:
1) Execute the updatedb entry to insert the new pref
2) Confirm that the behavior is the same as before applying this patch
3) Change the HoldFeeMode pref to 'always'
4) Note that the fee is applied for any hold placed

Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15225: [QA Follow-up] Improve changes to gethtml5media
Marcel de Rooy [Wed, 16 Dec 2015 14:54:49 +0000 (15:54 +0100)]
Bug 15225: [QA Follow-up] Improve changes to gethtml5media

[1] Improve readability, add some checks.
[2] Add the public flag for OPAC use. (If a file has not been marked as
    public, we should not return it in OPAC.)

Test plan:
See original commit. No changes in behavior.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15225: Make HTML5Media work with file upload feature.
Mirko Tietgen [Mon, 16 Nov 2015 17:10:27 +0000 (18:10 +0100)]
Bug 15225: Make HTML5Media work with file upload feature.

Koha::Upload allows files to be attached to bibliographic records.
HTML5Media streaming in Koha does not work with these files.

Test plan:
- apply patch
- make sure OPACBaseURL is set correctly
- enable HTML5MediaEnabled in OPAC and staff client
- connect upload.pl to 856$u in your framework
- upload a file with an extension set in HTML5MediaExtensions,
  make sure to set the codec correctly if you use WEBM (subfield c,
  eg. 'vp8, vorbis')
- save record, view in staff client and browser, check if 'Play
  media' option is available and works

Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15321: No need to add the change trigger conditionally
Jonathan Druart [Wed, 9 Dec 2015 09:04:35 +0000 (09:04 +0000)]
Bug 15321: No need to add the change trigger conditionally

It will be applied if the button exists.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15321 - Add delete report link to Show, Edit and Run screens
Magnus Enger [Tue, 8 Dec 2015 19:45:39 +0000 (20:45 +0100)]
Bug 15321 - Add delete report link to Show, Edit and Run screens

Currently, if you are editing or viewing the results of running a
report and you decide you want to delete it, you have to go back
to the list of saved reports to do so. This patch adds a "Delete"
link in some convenient places.

To test:
- Apply the patch
- Make sure you have at least one saved report
- Make sure you have the create_reports permission
- Go to the Show, Edit and Run screens and verify the Delete link
  is present and functional, including the JavaScript confirmation
  dialogue
- Change to a user without the create_reports permission and check
  that the Delete link is not displayed on the Show, Edit and Run
  screens
- Sign ye off merrily!

Version 2: This version makes sure the JavaScript confirmation is
shown before an actual delete is carried out.

Signed-off-by: Heather Braum <hbraum@nekls.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - DBrev 3.23.00.010
Kyle M Hall [Thu, 31 Dec 2015 15:35:31 +0000 (15:35 +0000)]
Bug 9129 - DBrev 3.23.00.010

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 [QA Followup] - Make unit test file conform to PBP
Kyle M Hall [Thu, 31 Dec 2015 15:31:19 +0000 (15:31 +0000)]
Bug 9129 [QA Followup] - Make unit test file conform to PBP

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - Add the ability to set the maximum fine for an item to its replacement...
Kyle M Hall [Thu, 22 Oct 2015 10:40:12 +0000 (06:40 -0400)]
Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price

This patch adds the ability to set the maximum fine for a given item to
its replacement price ( assuming the replacement price is set ). If
overduefinescap is also set, the fine will be the lesser of the two, if
both apply to the given overdue checkout.

To enable this new limit, create or edit your circulation rules and
check the checkbox for "Cap fines at replacement price"

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Pick an item, and set it's replacement price to 3.99
4) Edit the circulation rule that would apply to this item
   and the patron you will check it out to.
5) Check out the item to the patron, and backdate the due date
   such that the fine generated would be more than 3.99
6) Enable CalculateFinesOnReturn
7) Return the item, and view the fine generated, it should be 3.99

Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - Update schema
Kyle M Hall [Thu, 31 Dec 2015 15:29:13 +0000 (15:29 +0000)]
Bug 9129 - Update schema

Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - Update database
Kyle M Hall [Thu, 22 Oct 2015 10:38:57 +0000 (06:38 -0400)]
Bug 9129 - Update database

Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14939: Remove the Capture::Tiny dependency
Jonathan Druart [Thu, 10 Dec 2015 12:56:44 +0000 (12:56 +0000)]
Bug 14939: Remove the Capture::Tiny dependency

It's possible to redirect the std output to a variable, it will avoid to
add this new dependency.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  OK. + code factorisation with a function call.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14939: Modularize OAI Server existing classes
Frédéric Demians [Fri, 2 Oct 2015 07:18:18 +0000 (09:18 +0200)]
Bug 14939: Modularize OAI Server existing classes

Koha OAI server has been done in one unique .pl file because there
wasn't any object model or rules in the Koha project when it has been
coded. This patch modularized existing classes, putting each class in a
separate file in Koha::OAI::Server namespace. UT begining.

Add new dependency: Capture::Tiny

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
OAI server moduralized succefully. Works for Debian Jessie and
Wheezy. Test pass successfully

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 12342: Patron registration datepicker dropdown shows only 10 years
Martin Persson [Tue, 12 May 2015 11:33:14 +0000 (13:33 +0200)]
Bug 12342: Patron registration datepicker dropdown shows only 10 years

This patch changes the options to the date picker, allowing easy
selection of dates up to 120 years from the current date.

To test:
- Click on 'Patrons' from the main menu, select 'New patron'
- Set input focus to the 'Date of birth' input field,
  the date selection widget should show up.
- The year selection drop-down will only show current year minus 10.
- Apply the patch
- Go back to the same screen, set input focus to the 'Date of birth' field.
- The year selection drop-down should show current year minus 120.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14397: Fix tiny typo in database documentation
Katrin Fischer [Sun, 22 Nov 2015 02:01:18 +0000 (03:01 +0100)]
Bug 14397: Fix tiny typo in database documentation

Fixes Foriegn to Foreign.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15211: Patron card creator needs tools sidebar
Liz Rea [Thu, 19 Nov 2015 02:14:18 +0000 (15:14 +1300)]
Bug 15211: Patron card creator needs tools sidebar

The patron card creator should have the Tools area sidebar on its pages. This patch adds it.

To test:
Go to More -> Tools -> Patron card creator

The home page should have the tools sidebar
Click through all of the "New" pages - they should all have the tools sidebar
Click through all of the "Manage" pages - they should all have the tools sidebar

Also verify that on each page, the Patron card creator link in the sidebar is bolded

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Sidebar displayed Ok. No errors

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15211: adding Tools section sidebar to label creator
Liz Rea [Wed, 18 Nov 2015 22:34:41 +0000 (11:34 +1300)]
Bug 15211: adding Tools section sidebar to label creator

The label creator had a very sad sidebar, it needed to have the Tools area sidebar on it.

To test:

Click through all "New" pages, verify that the sidebar appears
Click through all "Manage" pages, verify that the sidebar appears.

Also verify that "Label creator" is bolded in the toolbar while the label creator is active.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Sidebar displayed Ok. No errors

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14292: Add patron category restrictions to longoverdue.pl
Barton Chittenden [Mon, 31 Aug 2015 15:42:32 +0000 (08:42 -0700)]
Bug 14292: Add patron category restrictions to longoverdue.pl

Squashed prevoius patch set.

Add command line options --category and --skip-category

Convert usage() to pod2usage. (This was previous FIXME)

Make borrower category handling more user friendly:

    Make --category and --skip-category mutally exclusive

    Check that categories specified by --category
    and --skip-category exist in categories table.

    Add --list-categories opttion to show available
    borrower categories.

http://bugs.koha-community.org/show_bug.cgi?id=14292

QA Follow-up

QA fixes - wording and trailing whitespaces

Simplify the category list

Basically we have 3 lists of categories:
1/ The full one, in the DB
2/ The one we want and list with --category
3/ The one we don't want and list with --skip-category

The list of categories to process is:
 * 1 if none --category or --skip-category options are provided
 * 2 if --category is provided
 * 1 - 3 if --skip-category is provided

(follow-up) Make --category and --skip-category case insensitive

"my" variable $borrower_category masks earlier declaration in same scope
"my" variable $skip_borrower_category masks earlier declaration in same scope

Signed-off-by: hbraum@nekls.org
Signed-off-by: Barton Chittenden <barton@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13931 [QA Followup] - Fix whitespace error
Kyle M Hall [Fri, 20 Nov 2015 16:54:43 +0000 (16:54 +0000)]
Bug 13931 [QA Followup] - Fix whitespace error

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13931 - Date of birth in patron search result and in autocomplete
Josef Moravec [Thu, 12 Nov 2015 19:45:01 +0000 (20:45 +0100)]
Bug 13931 - Date of birth in patron search result and in autocomplete

Test plan:
1) Apply the patch
2) Type into search form patron's name & check his date of birth in
   autocompletion
3) Go to intranet/cgi-bin/koha/members/member.pl & submit
   a search with more than one result .. now should in the table appear
   patron's date of birth
4) Try show/hide columns section if it works correctly for date of birth
5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to
   patrons section & check there is dateofbirth & it's functionality

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Works as described. Syspref dateformat respected. Column dateofbirth
  configurable, but mandatory on autocompletion search result.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 - DBrev 3.23.00.009
Kyle M Hall [Thu, 31 Dec 2015 13:31:35 +0000 (13:31 +0000)]
Bug 11622 - DBrev 3.23.00.009

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 [QA Follouwp] - Display payment block only if there is something to pay
Kyle M Hall [Thu, 24 Sep 2015 12:11:03 +0000 (08:11 -0400)]
Bug 11622 [QA Follouwp] - Display payment block only if there is something to pay

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 [QA Followup] - Fix currency issue, add error template
Kyle M Hall [Thu, 24 Sep 2015 12:06:16 +0000 (08:06 -0400)]
Bug 11622 [QA Followup] - Fix currency issue, add error template

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 [QA Followup] - Show ability to pay only if JavaScript is enabled
Kyle M Hall [Tue, 22 Sep 2015 12:40:01 +0000 (08:40 -0400)]
Bug 11622 [QA Followup] - Show ability to pay only if JavaScript is enabled

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 [QA Followup] - Use Koha's active currency for PayPal
Kyle M Hall [Tue, 22 Sep 2015 12:11:40 +0000 (08:11 -0400)]
Bug 11622 [QA Followup] - Use Koha's active currency for PayPal

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 [QA Followup] - Payment message always displays on opac-account.pl
Kyle M Hall [Mon, 21 Sep 2015 15:30:25 +0000 (11:30 -0400)]
Bug 11622 [QA Followup] - Payment message always displays on opac-account.pl

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 [QA Followup] - Display payment messages directly on opac account view
Kyle M Hall [Fri, 18 Sep 2015 12:54:30 +0000 (05:54 -0700)]
Bug 11622 [QA Followup] - Display payment messages directly on opac account view

Fixed spelling of "Receive" in preferences.

Signed-off-by: David Kuhn <techservspec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 [QA Followup] - Show amount to be paid near make payment button
Kyle M Hall [Fri, 18 Sep 2015 12:41:27 +0000 (05:41 -0700)]
Bug 11622 [QA Followup] - Show amount to be paid near make payment button

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 [QA Followup]
Kyle M Hall [Thu, 3 Sep 2015 17:18:42 +0000 (13:18 -0400)]
Bug 11622 [QA Followup]

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11622 - Add ability to pay fees and fines from OPAC via PayPal
Kyle M Hall [Thu, 23 Jan 2014 20:18:29 +0000 (15:18 -0500)]
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
    preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

Signed-off-by: Carol Corrales <ccorrales@losgatosca.gov>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
8 years agoBug 9303 - DBrev 3.23.00.008
Kyle M Hall [Thu, 31 Dec 2015 13:14:57 +0000 (13:14 +0000)]
Bug 9303 - DBrev 3.23.00.008

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9303 [QA Followup] - Restore missing svc script
Kyle M Hall [Wed, 3 Jun 2015 17:54:21 +0000 (13:54 -0400)]
Bug 9303 [QA Followup] - Restore missing svc script

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9303 [QA Followup] - Restore ability for patron to control setting
Kyle M Hall [Mon, 11 May 2015 11:31:27 +0000 (07:31 -0400)]
Bug 9303 [QA Followup] - Restore ability for patron to control setting

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9303 [QA Followup] - Restore missing biblio relationship
Kyle M Hall [Thu, 23 Apr 2015 17:56:55 +0000 (13:56 -0400)]
Bug 9303 [QA Followup] - Restore missing biblio relationship

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call...
Kyle M Hall [Tue, 21 Apr 2015 14:21:45 +0000 (10:21 -0400)]
Bug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call no."

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9303 [3] - relative's checkouts in the opac
Kyle M Hall [Mon, 2 Mar 2015 11:09:38 +0000 (03:09 -0800)]
Bug 9303 [3] - relative's checkouts in the opac

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/
Kyle M Hall [Mon, 2 Mar 2015 11:08:53 +0000 (03:08 -0800)]
Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9303 [1] - relative's checkouts in the opac - Database Updates
Kyle M Hall [Mon, 2 Mar 2015 11:07:52 +0000 (03:07 -0800)]
Bug 9303 [1] - relative's checkouts in the opac - Database Updates

This patch gives patrons the option of allowing other
linked relatives to view his or her checkouts from
opac-user.pl in a manner similiar to the patron's own
checkouts tab. By default the setting is not enabled.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create three borrowers, link them as relatives
4) In the OPAC, go to "my privacy" and choose to allow
   relatives to view current checkouts for borrowers A and B
5) Check out some items to each borrower
6) Log into the OPAC as borrower A, you should see a "Relatives'
   checkouts" tab. In this tab you should see the checkouts for
   borrower B
7) Log into the OPAC as borrower C, you should be able to view
   the current checkouts for both borrower A and borrower B

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13624 - DBrev 3.23.00.007
Kyle M Hall [Thu, 31 Dec 2015 12:50:08 +0000 (12:50 +0000)]
Bug 13624 - DBrev 3.23.00.007

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13624 - renaming atomicupdate from .pl to .perl
Charles Farmer [Fri, 16 Oct 2015 14:59:24 +0000 (10:59 -0400)]
Bug 13624 - renaming atomicupdate from .pl to .perl

I have not tested this very thoroughly e.g. understood the SQL changes etc. since
the patch has been signed off twice before.

But it seems to me like this patch is OK.
Applied, ran automatic tests and saved some values in the overduerules matrix/tabs OK.

Signed-off-by: Eivin Giske Skaaren <eivin@sysmystic.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13624 - Tidying the atomicupdate file and kohastructure.sql
Blou [Fri, 5 Jun 2015 19:06:36 +0000 (15:06 -0400)]
Bug 13624 - Tidying the atomicupdate file and kohastructure.sql

Signed-off-by: Martin Persson <xarragon@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13624 - Remove columns branchcode, categorytype from table overduerules_transport...
Blou [Tue, 21 Apr 2015 17:54:45 +0000 (13:54 -0400)]
Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types

This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice

TEST PLAN
1) Create or improve on overduerules data
  .1) Intranet -> tools -> overdue notices
  .2) Make sure to have data in first, second and third tabs
  .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability)
  .4) Make sure to have different letters and delay on first/second/third tab for at least one category
  .5) Remember it all.
2) Apply patch
3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl
4) run t/db_dependant/Overdues.t
5) Validate Overdue Notice page
  .1) validate data entered previously is still there
  .2) Add some more, save changes, validate

In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl
    - A new column and primary key, 'overduerules_id', is added to the table 'overduerules'
    - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types'
    - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types'
    - Data is migrated from the old tables to the new ones

In installer/data/mysql/kohastructure.sql :
    - Table 'overduerules'
    - Added a primary key named 'overduerules_id'
    - Table 'overduerules_transport_types'
    - Added a foreign key named 'overduerules_id'
    - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id'

In tools/overduerules.pl
    - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema

In C4/Overdues.pm :
    - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport

In t/db_dependent/Overdues.t :
    - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types'

Sponsored by : Halland County Library

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Martin Persson <xarragon@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13918 [QA Followup] - Remove unnecessary reference to $wcount
Kyle M Hall [Thu, 15 Oct 2015 13:44:13 +0000 (09:44 -0400)]
Bug 13918 [QA Followup] - Remove unnecessary reference to $wcount

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13918 [QA Followup] - Remove dead template code
Kyle M Hall [Thu, 31 Dec 2015 12:39:33 +0000 (12:39 +0000)]
Bug 13918 [QA Followup] - Remove dead template code

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13918 [QA Followup] - Improve $biblio->subtitles()
Kyle M Hall [Mon, 24 Aug 2015 15:10:58 +0000 (11:10 -0400)]
Bug 13918 [QA Followup] - Improve $biblio->subtitles()

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13918 [QA Followup] - Remove reserves_count
Kyle M Hall [Mon, 24 Aug 2015 14:55:28 +0000 (10:55 -0400)]
Bug 13918 [QA Followup] - Remove reserves_count

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13918 [QA Followup] - Unit Tests
Kyle M Hall [Mon, 24 Aug 2015 14:48:22 +0000 (10:48 -0400)]
Bug 13918 [QA Followup] - Unit Tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13918 - Add waiting expiration date to opac list of holds for user
Kyle M Hall [Wed, 18 Mar 2015 15:45:07 +0000 (11:45 -0400)]
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until <date>' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us>
Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 12375 - DBrev 3.23.00.006
Kyle M Hall [Thu, 31 Dec 2015 12:33:20 +0000 (12:33 +0000)]
Bug 12375 - DBrev 3.23.00.006

8 years agoBug 12375 [7] - Update to use Koha::Object classes
Kyle M Hall [Thu, 31 Dec 2015 12:27:15 +0000 (12:27 +0000)]
Bug 12375 [7] - Update to use Koha::Object classes

This code was written before the introduction of Koha::Object(s)

Considering the triviality of updating the code, we should go ahead
and switch this code to use Koha::Object(s) now.

8 years agoBug 12375 [6] [QA Followup] - Supress warnings for undefined indexes
Kyle M Hall [Fri, 25 Jul 2014 13:31:22 +0000 (09:31 -0400)]
Bug 12375 [6] [QA Followup] - Supress warnings for undefined indexes

8 years agoBug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order
Kyle M Hall [Mon, 21 Jul 2014 13:55:02 +0000 (09:55 -0400)]
Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order

8 years agoBug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue
Kyle M Hall [Thu, 5 Jun 2014 15:26:40 +0000 (11:26 -0400)]
Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue

Currently, all serials enumeration data is stored in conglomerated
fashion in serial.serialseq. This makes it extremely difficult to do any
reporting based on the individual sequence values due to this fact. In
addition to the formatted version of the sequence, we should be storing
the individual values as well.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new subscription, and add serials to it. The new x y and
   z fields should be populated with the same data the replaces {X} {Y} and
   {Z} in the enumeration field.
4) Inspect some existing serials. The update script will have made a
   best effort to recover the existing enumeration data to store in
   separate fields.

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
8 years agoBug 12375 [3] - Store serials enumeration data in separate fields
Kyle M Hall [Thu, 5 Jun 2014 14:52:30 +0000 (10:52 -0400)]
Bug 12375 [3] - Store serials enumeration data in separate fields

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
8 years agoBug 12375 [2] - Update Serial schema file
Kyle M Hall [Thu, 5 Jun 2014 14:53:13 +0000 (10:53 -0400)]
Bug 12375 [2] - Update Serial schema file

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
8 years agoBug 12375 [1] - Update database
Kyle M Hall [Tue, 23 Oct 2012 18:48:41 +0000 (14:48 -0400)]
Bug 12375 [1] - Update database

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
8 years agoBug 15447 - log4perl.conf does not have __LOG_DIR__ replaced when installing
Kyle M Hall [Wed, 30 Dec 2015 18:55:33 +0000 (18:55 +0000)]
Bug 15447 - log4perl.conf does not have __LOG_DIR__ replaced when installing

Since the introduction of Koha::Logger, it appears that the
log4perl.conf config file has been broken. The references to __LOG_DIR__
is not being replaced.

Test Plan:
1) Apply this patch
2) Run 'perl Makefile.PL'
3) Run 'make'
4) Open blib/KOHA_CONF_DIR/log4perl.conf with a text editor
5) Note the log file paths are correctly set, and do not have
   __LOG_DIR__ in them.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15383 [QA Followup] - Change language used
Kyle M Hall [Thu, 31 Dec 2015 11:23:42 +0000 (11:23 +0000)]
Bug 15383 [QA Followup] - Change language used

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15383 - Opac: Autority details: Fix translation issues with a tags
Marc Véron [Tue, 15 Dec 2015 16:06:17 +0000 (17:06 +0100)]
Bug 15383 - Opac: Autority details: Fix translation issues with a tags

Fix translation issue in opac-auth-detail.tt and opac-auth-MARCdetail.tt
(string splitting by link tag) making it hard to have a gramaticaly correct
translation.

To test:
- Apply patch
- In OPAC, go to search an Authority and display details (View full heading)
- Verify the line "Usage in records: x" in both Normal view and MARC view

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Not sure if "Usage in records" is the best wording, but I have no great
options either, "Number of records used in:"?

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15258: Fix Perl scripts declaring unused variables
Frédéric Demians [Thu, 26 Nov 2015 07:26:34 +0000 (08:26 +0100)]
Bug 15258: Fix Perl scripts declaring unused variables

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
All affected files tested with `perl -c`.
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15258: Prevent unused declared variables
Frédéric Demians [Thu, 26 Nov 2015 06:30:42 +0000 (07:30 +0100)]
Bug 15258: Prevent unused declared variables

Add a perlcritic rule to 00-perlcritic.t to prevent unused declared
variable.

TO TEST:

- Apply the 1st patch (unit test)
- Run the UT:
  prove -v t/00-testcritic.t
- Note that several Perl script fail
- Apply the 2nd patch
- Run the UT, and confirm it passes.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
All tests pass successful.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 7143: Add link to www.openhub.net profile for Marc Veron
Marc Véron [Fri, 11 Dec 2015 23:48:45 +0000 (00:48 +0100)]
Bug 7143: Add link to www.openhub.net profile for Marc Veron

This patch adds a link to www.openhub.net/p/koha/contributors/6618545408147
for Marc Veron (with &eacute;).

(Amended for &eacute; in commit message)

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
(Amended for comment #281: changed second occurence)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 13136: Add missing help file for label-manage.pl
Nicole C. Engard [Mon, 7 Dec 2015 19:15:04 +0000 (13:15 -0600)]
Bug 13136: Add missing help file for label-manage.pl

This patch adds in a help file for the new label-manage page.

To test:

* visit label creator
* click manage and choose an option
* click 'help' and confirm the file loads
* repeat for all options under manage

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Tab char corrected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 13517 [QA Followup] - Fix unit tests
Kyle M Hall [Thu, 9 Jul 2015 15:24:00 +0000 (11:24 -0400)]
Bug 13517 [QA Followup] - Fix unit tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 13517 [QA Followup] - Add unit tests
Kyle M Hall [Thu, 25 Jun 2015 19:17:12 +0000 (15:17 -0400)]
Bug 13517 [QA Followup] - Add unit tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 13517 - Show waiting date on reserve/request.pl
Kyle M Hall [Wed, 18 Mar 2015 12:50:21 +0000 (08:50 -0400)]
Bug 13517 - Show waiting date on reserve/request.pl

The holds table should show the waiting date for a hold in s similar
manner to the way it does on catalogue/detail.pl In addition, if the
ReservesMaxPickUpDelay syspref is set, we should display the date
when the waiting hold expires.

Test Plan:
1) Apply this patch
2) Set ReservesMaxPickUpDelay to 7
3) Find a waiting hold
4) Browse to reserve/request.pl for that record
5) Notice the "Item waiting" message now has "since <waitingdate>"
6) Notice the expiration field now has the date of <waitingdate> + 7 days

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us>
Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years ago Bug 15304: Remove Norwegian strings from nl-search.tt
Magnus Enger [Tue, 8 Dec 2015 20:11:58 +0000 (21:11 +0100)]
 Bug 15304: Remove Norwegian strings from nl-search.tt

When nl-search.pl gets data from the Norwegian national patron
database, it does so in an XML format that has Norwegian element
names. nl-search.pl displays the data with the Noregian element
names as labels. This means Norwegian words turn up in translations,
which is messy. This patch replaces the Norwegian labels with
English ones.

To test:
- Only Norwegian libraries and vendors get access to search against
  the national patron database, so a proper functional test is not
  possible
- Alternative 1: Just have a look at the nl-search.tt template
  before and after the patch and verify that after the patch the
  Norwegian strings that would be visible to a user are gone
- Alternative 2:
  - Verify that e.g. en-GB-staff-prog.po contains the Norwegian
    string "kjonn"
  - Apply the patch
  - Create new .po files with e.g. "./translate create en-GB"
  - Verify that "kjonn" is now gone from en-GB-staff-prog.po

Version 2: Tweak a couple of labels to be more in line with labels used
elsewhere in Koha, to avoid variants when translating.

Version 3: Replace e.g. "Gender: </span>" with "Gender:</span> " to
avoid similar-except-for-whitespace strings in translation.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
A few new strings, all previous removed.
No koha-qa errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15049: Simplify code in aqplan.tt
Jonathan Druart [Mon, 28 Dec 2015 10:26:10 +0000 (10:26 +0000)]
 Bug 15049: Simplify code in aqplan.tt

There was no need to duplicate this code in the template.
The only change with before this patch is that the "Currency = CUR"
and "Each cell contain both actual and estimated values." are now
displayed on 2 lines instead of 1.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15049: (followup) Add warning about "No active currency"
Marc Véron [Fri, 18 Dec 2015 15:01:12 +0000 (16:01 +0100)]
 Bug 15049: (followup) Add warning about "No active currency"

Fix translatibiity issues and use include in admin/aqplan.tt as well.
See comment #24

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15049: (Signed off) Hide currency but preserv alert
Bernardo Gonzalez Kriegel [Thu, 29 Oct 2015 12:13:26 +0000 (09:13 -0300)]
 Bug 15049: (Signed off) Hide currency but preserv alert

This follow up hides currency, but the alert pops
if no currency is active.

To test:
1) Apply the patch
2) Unset any active currency
3) Alert must show on Acquisitons home
4) Set a currency active, no currency display on Acqui home
5) Check that currency IS displayed on /cgi-bin/koha/admin/aqbudgets.pl
or /cgi-bin/koha/admin/aqbudgetperiods.pl

Amended for better translation

Currency does / does not display as described in test plan.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15049: Add warning about "No active currency" to Acquisitions start page
Marc Véron [Thu, 22 Oct 2015 09:44:23 +0000 (11:44 +0200)]
 Bug 15049: Add warning about "No active currency" to Acquisitions start page

If no active currency is defined, Acquisitions does not work properly and software
can occur while receiving.
This patch adds the warning message about missing active currency to Home > Acquisitions

To test:
- Apply patch
- Go to Home > Administration > Currencies & Exchange Rates > Currencies
- Make sure that no active currency is set
- Go to Home > Acquisitions
- Verify that a warning displays:
  - If user has at least permission for parameters_remaining_perissions,
    the warning should display a link to Currencies and exchange rates (currency.pl)
  - If the user has no permission to edit the Currencies and exchange rates,
    no link is displayed.
- Set an active currency
- Veryfy that the warning no longer displays

(Amended to remove superfluous line / mv)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. No errors

Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years agoBug 15080 - ./translate tool should tell if xgettext executable is missing
Olli-Antti Kivilahti [Thu, 29 Oct 2015 13:40:50 +0000 (15:40 +0200)]
Bug 15080 - ./translate tool should tell if xgettext executable is missing

Just upgraded our Koha container to 14.04 and noticing the
misc/translator/translate doesn't work.  This is because of a missing
package gettext.

This patch makes ./translate die with a helpful suggestion to install
gettext if xgettext-program is missing.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  I can reproduce the bug by desinstalling 'gettext' package on a Debian
  box. I confirm that without this patch, 'translate' command fails
  miserably. Suggesting to install gettext package is welcomed.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 10468: (followup) fix indentation
Aleisha [Thu, 20 Aug 2015 03:34:48 +0000 (03:34 +0000)]
Bug 10468: (followup) fix indentation

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 10468: Adding holds table to summary print
Aleisha [Thu, 20 Aug 2015 03:34:48 +0000 (03:34 +0000)]
Bug 10468: Adding holds table to summary print

To test:
1) Add a hold to a patron
2) Go to patron page
3) Click Print Summary
4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years ago Bug 12544 - Send scheduled reports as an attachment
Kyle M Hall [Tue, 3 Nov 2015 19:43:17 +0000 (14:43 -0500)]
 Bug 12544 - Send scheduled reports as an attachment

This patch adds the ability to add the report as an attached file
to the sent email.

Test Plan:
1) Email yourself a test report
2) Apply this patch
3) Repeat step 1, note there is no difference
4) Add the -a parameter, note your also recieve the report as an attachment

Sponsored-by: Briar Cliff University
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Julius Fleschner <Julius.fleschner@briarcliff.edu>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 12289: (follow-up) fix the compilation error
Joonas Kylmälä [Tue, 1 Sep 2015 07:26:40 +0000 (07:26 +0000)]
 Bug 12289: (follow-up) fix the compilation error

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 12289: Add --no-create options to stage_file.pl
Martin Renvoize [Mon, 19 May 2014 13:20:50 +0000 (13:20 +0000)]
 Bug 12289: Add --no-create options to stage_file.pl

This patch adds the no-create options to the command line interface
for bulk loading of records.

To test
1/ Apply both patches
2/ Call the script with --no-create and your will find that new
records are not created when no match is found.  The default, of
create_new remains the same as before.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15396: fix MARC21 Leader plugin label '1-4 Record size'
Mirko Tietgen [Fri, 18 Dec 2015 09:24:29 +0000 (10:24 +0100)]
 Bug 15396: fix MARC21 Leader plugin label '1-4 Record size'

The plugin label says "1-4 Record size", but it's actually 0-4.

http://www.loc.gov/marc/bibliographic/bdleader.html

Test plan:
-apply patch
-in cataloging, open a record in a framework that uses the plugin
-open LEADER/000 and check that the label says "0-4 Record size" now

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Good catch, fixed tab, no errors.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 14853: Change 'Fund' to 'Shipping fund'
Katrin Fischer [Sun, 22 Nov 2015 01:52:02 +0000 (02:52 +0100)]
 Bug 14853: Change 'Fund' to 'Shipping fund'

Changes the 'Fund' to 'Shipping fund' so it's clear
what the fund setting is used for.

To test:
- Receive a new shipment
- Verify that 'Shipping fund' displays on the parcels page
- Search for your invoice
- View invoice details
- Verify that 'Shipping fund' displays on the invoice page

Followed test plan (changed lines: '...cost' -> '...fund')
Display OK on both places.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag
Marc Véron [Wed, 9 Dec 2015 15:10:10 +0000 (16:10 +0100)]
 Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag

This patch fixes a translatability issue due to <trong> tags.

To verify:
- Make sure that you have some entries in 'Cities and Towns'
  ( Home > Administration > Cities )
- Edit the main address of a patron's details
- Locate field "City", at the right you have the text 'or choose'
  followed by a drop-down ('choose' is bold)
- change language e.g. to German, the text reads 'or auswählen'
  (instead of 'oder auswählen')
- This is due to the <strong> tags around 'choose'

To test:
- Apply patch
- Verify that the <strong> tags around 'choose' are removed in:
    koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc
    koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Obvious issue/solution

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15409 - Plugins section missing from Admin menu sidebar
Kyle M Hall [Tue, 22 Dec 2015 15:37:41 +0000 (15:37 +0000)]
 Bug 15409 - Plugins section missing from Admin menu sidebar

The sidebar menu in the Admin area of Koha is missing a section for
Plugins.

Test Plan:
1) Apply this patch
2) Log in with a user that has plugin permissions
3) Browse to a page with the admin menu sidebar, such as
   /cgi-bin/koha/admin/transport-cost-matrix.pl
4) Note the new Plugins section with a link to manage plugins
5) Log in with a user that has no plugin permissions
6) Revisit the same page, note the Plugins section is no longer visible

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years agoBug 15099 [QA Followup] - Make bug pass koha-qa.pl
Kyle M Hall [Wed, 30 Dec 2015 16:49:16 +0000 (16:49 +0000)]
Bug 15099 [QA Followup] - Make bug pass koha-qa.pl

Cleaned up additional tab characters and such well. This is a very
good time to take care of these.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15099: Move admin/categorie.pl to admin/categories.pl
Jonathan Druart [Wed, 2 Dec 2015 08:49:50 +0000 (08:49 +0000)]
Bug 15099: Move admin/categorie.pl to admin/categories.pl

This patch fixes the filename categorie.pl correcting it by categories.pl
The plurial is usually used for script names in the admin module.

Test plan:
Navigate to the patron categories page.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  No reference to categorie.pl anywhere in the code

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15432: t/db_dependent/Letters.t depends on external data/configuration
Marc Véron [Mon, 28 Dec 2015 15:00:54 +0000 (16:00 +0100)]
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration

To test:

- Set system preference LetterLog to 'Don't log'
- prove t/db_dependent/Letters.t
- Result: Fails on test 62 - Successfully sent claim
- Apply patch
- Test again
- Result: Pass OK

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: removed the bug reference, not needed.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15373: More changes of Zip to ZIP on intranet
Aleisha [Sun, 20 Dec 2015 19:57:54 +0000 (19:57 +0000)]
Bug 15373: More changes of Zip to ZIP on intranet

To test:

- Log in to Staff Interface, go to Administration, Libraries and Groups (cgi-bin/koha/admin/branches.pl). Click 'New library' and confirm that it says 'ZIP/Postal Code:' in the form.
- Go back to Administration, Cities and towns (cgi-bin/koha/admin/cities.pl). Confirm it says 'ZIP/Postal code' in table heading. Click 'New city' and confirm it says 'ZIP/Postal code:' in form
- Go back to Administration, Global system preferences, I18L/L10N (cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n). Under AddressFormat, confirm all available options say '[ZIP/Postal Code]'
- Go to Reports, Patrons (cgi-bin/koha/reports/borrowers_stats.pl). Confirm it says 'ZIP/Postal code' under Title
- Go to Tools, Batch patron modification (cgi-bin/koha/tools/modborrowers.pl), enter any card number and click 'Continue'. Confirm it says 'ZIP/Postal code' in the table of patron details, and in the form to edit

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Tested together with first patch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15373: Changing Zip to ZIP on OPAC and Intranet
Aleisha [Mon, 14 Dec 2015 22:43:26 +0000 (22:43 +0000)]
Bug 15373: Changing Zip to ZIP on OPAC and Intranet

To test:

1) Login to OPAC --> You personal details.
2) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact
3) Login to Staff interface --> Go to a member's page (ie koha/members/memberentry.pl) --> Details.
4) Ensure it says 'ZIP/Postal Code' under Alternate address and Alternative contact
5) Click Edit
6) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Tested together with second patch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9819 [QA Followup] - Fix DBrev description
Kyle M Hall [Wed, 30 Dec 2015 16:28:32 +0000 (16:28 +0000)]
Bug 9819 [QA Followup] - Fix DBrev description

8 years agoBug 11569 - [QA Followup] - Update English description for existing installations...
Kyle M Hall [Wed, 30 Dec 2015 16:25:06 +0000 (16:25 +0000)]
Bug 11569 - [QA Followup] - Update English description for existing installations, DBrev 3.23.00.005

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 11569: Correcting typos in userpermissions.sql
Aleisha [Mon, 21 Dec 2015 22:45:57 +0000 (22:45 +0000)]
Bug 11569: Correcting typos in userpermissions.sql

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9819 - DBrev 3.23.00.004
Kyle M Hall [Wed, 30 Dec 2015 16:01:23 +0000 (16:01 +0000)]
Bug 9819 - DBrev 3.23.00.004

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9819 [QA Followup] - Removed missed stopwords refs, remove Schema file
Kyle M Hall [Wed, 30 Dec 2015 15:54:56 +0000 (15:54 +0000)]
Bug 9819 [QA Followup] - Removed missed stopwords refs, remove Schema file

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9819: Make the tests pass
Jonathan Druart [Tue, 15 Dec 2015 10:07:39 +0000 (10:07 +0000)]
Bug 9819: Make the tests pass

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9819 - QA Followup: Stopwords vestiges in es-ES removed
Tomas Cohen Arazi [Mon, 22 Apr 2013 12:10:13 +0000 (09:10 -0300)]
Bug 9819 - QA Followup: Stopwords vestiges in es-ES removed

Gotcha.
To+

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9819 - Make updatedatabase.pl remove the 'stopwords' table
Tomas Cohen Arazi [Wed, 10 Apr 2013 14:13:10 +0000 (11:13 -0300)]
Bug 9819 - Make updatedatabase.pl remove the 'stopwords' table

To test:
- Apply the patch
- Will be prompted to run the updater
- The 'stopwords' database should be removed
  ( test on a mysql prompt with
    > SHOW TABLES LIKE 'stopwords';
   and should get no results)

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9819 - Remove 'stopwords' table from kohastructure.sql
Tomas Cohen Arazi [Wed, 10 Apr 2013 14:06:45 +0000 (11:06 -0300)]
Bug 9819 - Remove 'stopwords' table from kohastructure.sql

Just that.

To test:
- Apply the patch
- Do a fresh install
- The database structure should be created flawlessly
- There should not be a 'stopwords' table created

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9819 - 'stopwords'-related code removed
Tomas Cohen Arazi [Wed, 10 Apr 2013 13:52:54 +0000 (10:52 -0300)]
Bug 9819 - 'stopwords'-related code removed

This patch removes code related to stopwords usage. The following methods are removed:

C4::Search->remove_stopwords
C4::Context->stopwords
C4::Context->_new_stopwords

And the buildQuery API was changed (removed the \@removed_stopwords return value).
A follow-up is provided for database changes, to make rebasing easier.

To test:
- Apply this patch
- Do some searches in both intranet and opac interfaces
- Nothing should break

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>