]> git.koha-community.org Git - koha.git/log
koha.git
9 years agoBug 8007: (followup) double quotes...
Tomas Cohen Arazi [Thu, 30 Apr 2015 19:15:10 +0000 (16:15 -0300)]
Bug 8007: (followup) double quotes...

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7843: (QA followup) Make news selection persistant
Kyle M Hall [Fri, 6 Mar 2015 09:37:04 +0000 (10:37 +0100)]
Bug 7843: (QA followup) Make news selection persistant

This patch makes the following changes:
1) If there is no logged in patron, the RSS link states it is for
   system-wide news.
2) If a patron is logged in, the RSS link states it is for system-wide
   news *and* news for the patron's home library.
3) The patron's home branch code is embedded in the RSS feed url so
   he or she no longer needs to be logged in for us to know what branch's
   news to pull.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7843: Followup - fix broken url
Bernardo Gonzalez Kriegel [Tue, 3 Mar 2015 11:53:04 +0000 (08:53 -0300)]
Bug 7843: Followup - fix broken url

This patch fixes an invalid URL when clicking
on RSS feed.

To test:
1) Using Nicole words :)
If you visit : http://mykoha/cgi-bin/koha/opac-main.pl
then the RSS feed works.
If you're on http://mykoha and you click the rss icon you
get : http://mykoha/opac-news-rss.pl which is a 404 page.

2) Apply the patch

3) Repeat 1, error is now fixed

Signed-off-by: Pierre <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7843: (follow up) Improve RSS feed language
Nicole [Tue, 3 Mar 2015 11:05:38 +0000 (03:05 -0800)]
Bug 7843: (follow up) Improve RSS feed language

The RSS button used to read ' RSS for the librarys general newsfeed.'
This included one grammatical error and I think included more words
than most average people would read.  This patch simplifies it to say
'RSS for Library News.'

To test:
* Apply all patches
* Review RSS feed button's text on main page under news

http://bugs.koha-community.org/show_bug.cgi?id=7843

Signed-off-by: Pierre <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7843: (qa-followup) Create an RSS feed for news in Opac
Jonathan Druart [Thu, 19 Feb 2015 11:48:44 +0000 (12:48 +0100)]
Bug 7843: (qa-followup) Create an RSS feed for news in Opac

1/ use strict and warnings are useless, Modern::Perl is used
2/ Prefer to use the interface and theme TT var instead of the hard
coded path

Signed-off-by: Pierre <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7843: Remove the useless use of casAuthentication
Jonathan Druart [Thu, 19 Feb 2015 11:48:16 +0000 (12:48 +0100)]
Bug 7843: Remove the useless use of casAuthentication

Certainly a c/p error from opac-main.pl

Signed-off-by: Pierre <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7843: Create an RSS feed for news in Opac
Viktor Sarge [Sun, 8 Feb 2015 19:41:55 +0000 (19:41 +0000)]
Bug 7843: Create an RSS feed for news in Opac

Test plan:
* Install the patch
* Make shure there is news in the Opac
* Go to the Opac (opac-main.pl)
* Make shure you see an RSS icon below the news and a short text.
* Click the RSS icon and verify that you get an RSS feed that validates.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I took the liberty of fixing the copyright statement when signing it off

Signed-off-by: Pierre <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11814: Fix existing tests
Jonathan Druart [Fri, 19 Dec 2014 14:48:49 +0000 (15:48 +0100)]
Bug 11814: Fix existing tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11814: Fix sql parameters order
Jonathan Druart [Tue, 25 Nov 2014 09:01:05 +0000 (10:01 +0100)]
Bug 11814: Fix sql parameters order

Oops, bad paramaters passed on executing the sql query produced
unexpected behaviors.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11814: (follow-up) Use constants to describe statuses
Jonathan Druart [Thu, 13 Nov 2014 09:07:15 +0000 (10:07 +0100)]
Bug 11814: (follow-up) Use constants to describe statuses

This patch deals with all hard-coded status codes in the C4::Serials
module.

Test plan:
Test a complete workflow in the serial module (create, order, receive,
generate next) trying to use all statuses.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11814: Use constants to describe statuses
Kyle M Hall [Fri, 21 Feb 2014 14:19:09 +0000 (09:19 -0500)]
Bug 11814: Use constants to describe statuses

Make the code a bit more understandable by using constants to define
the status values and reference those. Adds self-documentation.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 1487: Store the "display only used tags/subf" value in a cookie
Jonathan Druart [Wed, 8 Apr 2015 09:15:02 +0000 (11:15 +0200)]
Bug 1487: Store the "display only used tags/subf" value in a cookie

On the marc framework page, the checkbox to display only used
tags/subfields is always unchecked.
It should be stored into a cookie to always display the same view.

Test plan:
1/ Go on the marc framework page
2/ Check the checkbox
3/ Go somewhere else on the staff interface
4/ Back to the marc framework page, the checkbox should be checked

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Works as advertised, getting datatables error when using feature
but the error exists pre-patch
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: (followup) manually add the <body> tag
Tomas Cohen Arazi [Thu, 30 Apr 2015 18:12:13 +0000 (15:12 -0300)]
Bug 8007: (followup) manually add the <body> tag

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: (QA followup) <body> was missing id and class
Tomas Cohen Arazi [Thu, 30 Apr 2015 15:58:15 +0000 (12:58 -0300)]
Bug 8007: (QA followup) <body> was missing id and class

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: (QA followup) fix charset collate
Tomas Cohen Arazi [Thu, 30 Apr 2015 15:05:22 +0000 (12:05 -0300)]
Bug 8007: (QA followup) fix charset collate

This bug was started before the changes on default collation. This
patch fixes that.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: DBRev 3.19.00.035
Tomas Cohen Arazi [Wed, 29 Apr 2015 13:11:44 +0000 (10:11 -0300)]
Bug 8007: DBRev 3.19.00.035

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: (QA followup) Add error handling when generating the pdf
Jonathan Druart [Tue, 28 Apr 2015 08:59:42 +0000 (10:59 +0200)]
Bug 8007: (QA followup) Add error handling when generating the pdf

If error occurs when generating the pdf, it would be better to get an
encapsulated error instead of the "software error" message in the pdf
file.
To test this patch I added this change:

b/Koha/Borrower/Discharge.pm
-115,6 +115,7 @@ sub generate_as_pdf {
     say $html_fh $html_content;
     close $html_fh;
     my $pdf = PDF::FromHTML->new( encoding => 'utf-8' );
+    $html_path .= "poeut";
     $pdf->load_file( $html_path );
     $pdf->convert;

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: (QA followup) wording issue on sysprefs
Tomas Cohen Arazi [Mon, 27 Apr 2015 19:45:46 +0000 (16:45 -0300)]
Bug 8007: (QA followup) wording issue on sysprefs

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: (QA followup) fix kohastructure to follow guidelines
Tomas Cohen Arazi [Mon, 27 Apr 2015 19:45:24 +0000 (16:45 -0300)]
Bug 8007: (QA followup) fix kohastructure to follow guidelines

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: (RM followup) fix DBIx schema checksum
Tomas Cohen Arazi [Mon, 27 Apr 2015 19:09:42 +0000 (16:09 -0300)]
Bug 8007: (RM followup) fix DBIx schema checksum

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: Compatibility with bug 11944
Jonathan Druart [Thu, 18 Dec 2014 14:39:46 +0000 (15:39 +0100)]
Bug 8007: Compatibility with bug 11944

This patch should be applied to work with bug 11944.
If you don't have 11944 yet, just don't apply this patch.

Note that the line
  binmode(STDOUT);
in pl files is mandatory.

It comes from bug 11944 that adds the line
  binmode( STDOUT, ":utf8" );
in C4::Templates::gettemplate.

Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: Replace HTML::HTMLDoc with PDF::FromHTML
Jonathan Druart [Thu, 18 Dec 2014 14:39:46 +0000 (15:39 +0100)]
Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML

Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: Discharge - Adding Perl dependencie
Yohann Dufour [Wed, 20 Aug 2014 08:24:17 +0000 (10:24 +0200)]
Bug 8007: Discharge - Adding Perl dependencie

HTML::HTMLDoc is required in order to generate the discharges in PDF format.

Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: Discharge - Add unit tests
Yohann Dufour [Mon, 4 Aug 2014 14:09:53 +0000 (16:09 +0200)]
Bug 8007: Discharge - Add unit tests

Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: Discharge management
Yohann Dufour [Mon, 4 Aug 2014 14:09:42 +0000 (16:09 +0200)]
Bug 8007: Discharge management

This patch is the main patch. It adds new package and files for the new
pages (opac-discharge, members/discharge and members/discharges).

At the intranet, it is now possible to generate a discharge for a patron.
At the opac, a patron can request a discharge and a discharge if it has
been validated by a librarian.

Requirements:
    The perl module PDF::FromHTML

New sysprefs:
 - useDischarge: Allows librarians to discharge borrowers and borrowers
   to request a discharge

New letter with a letter_code DISCHARGE.

Test plan:
- Switch on the syspref useDischarge.
- Verify a new tab appears in the patron page (intranet and opac).
- Verify the discharge cannot be generated if the patron has issues.
- Verify the patron can request a discharge from it's opac area.
- The request appears on the main page (intranet).
- Generate the discharge from the intranet.
- Try to download it (from the opac and the intranet).

Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: Discharge - Glue
Yohann Dufour [Mon, 4 Aug 2014 14:09:35 +0000 (16:09 +0200)]
Bug 8007: Discharge - Glue

This patch adds:
- links to the new pages.
- syspref description
- links on the main page (intranet)
- the DISCHARGE type for debarment

Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: Discharge - DBIx changes
Yohann Dufour [Mon, 4 Aug 2014 14:09:27 +0000 (16:09 +0200)]
Bug 8007: Discharge - DBIx changes

Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8007: Discharge - DB changes
Yohann Dufour [Mon, 4 Aug 2014 14:09:14 +0000 (16:09 +0200)]
Bug 8007: Discharge - DB changes

This patch adds:
- syspref useDischarge
- the new table discharges
- the discharge notice

Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7939: (QA followup) make the koha-translate script test the new filenames
Tomas Cohen Arazi [Thu, 30 Apr 2015 14:37:20 +0000 (11:37 -0300)]
Bug 7939: (QA followup) make the koha-translate script test the new filenames

The debian/scripts/koha-translate script was still testing for the old naming
schema files. I also made sure all files are tested, to warn the user if
any of them is absent.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7939: (followup) Update translation files
Bernardo Gonzalez Kriegel [Wed, 29 Apr 2015 19:28:00 +0000 (16:28 -0300)]
Bug 7939: (followup) Update translation files

Create/rename/update/fix translation files

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7939: Separate po files for different MARC dialects
Bernardo Gonzalez Kriegel [Sun, 23 Mar 2014 22:01:43 +0000 (19:01 -0300)]
Bug 7939: Separate po files for different MARC dialects

This patch implements separate PO files for
different MARC dialects.

It depends on correct filenames, i.e. it will build PO
files using files with/without "unimarc|normarc|marc21"
on their names.

Changes:
A) LangInstaller.pm
Added definitions to create or update xx-YY-{MARCFLAVOR}.po,
minor change to create and install procedure, and modification
of install procedure to handle multiple target dirs.
Updated documentation.

B) Standarization of filenames
STAFF po file is now xx-YY-staff-prog.po
MARC dialects po files are xx-YY-marc-{MARCFLAVOUR}.po

To test:
1) Update po files for your preferred language, ej. nn-NO
cd misc/translator
perl translate update nn-NO

2) Do some copying/renaming
cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-UNIMARC.po
cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-NORMARC.po
cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-MARC21.po
mv po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-staff-prog.po

(most MARC dialect strings are on staff, so we use that as basis)

3) Apply the patch

4) Update again to fix translation files, verbose
perl translate update nn-NO -v

5) Install language, verbose, verify translations
perl translate install nn-NO -v

6) Create translation files
rm po/nn-NO*
perl translate create nn-NO

we must have this list:
po/nn-NO-marc-MARC21.po
po/nn-NO-marc-NORMARC.po
po/nn-NO-marc-UNIMARC.po
po/nn-NO-opac-bootstrap.po
po/nn-NO-pref.po
po/nn-NO-staff-help.po
po/nn-NO-staff-prog.po

Additional tests:
7) Number of msgids
7.a) Before patch and after upgrade, extract and count msgids
for i in $(ls po/nn-NO-*po); \
do msginit -i $i -o nn-old.po --no-translator --no-wrap --locale=nn_NO; \
egrep ^msgid nn-old.po >> old; \
done
sort old | uniq | tee s-old | wc -l > n-old
s-old: have all msgids
n-old: number of msgids

7.b) After patch and after creation of new files
Repeat procedure, diferent files (s-new, n-new)

7.c) Compare (diff s-old snew), they are the same
(save for a strange UNIMARC char in my case, but
it's present on corresponding PO file)

8) Installed dirs/files
8.a) List of EN dirs/files
cd koha-tmpl
find | egrep "/en/" > en

8.b) List of nn-NO dirs/files. After patch and language install
cd koha-tmpl
find | egrep "/nn-NO/" | sed 's|/nn-NO/|/en/|' > nn

8.c) Compare (diff en nn), they are the same

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Followed the steps outlined by Bernardo, and everything works as
expected. I think the most important points are that "perl translate
create nn-NO" produces the right files, and translating anything in
them, then doing "translate install" makes the translations show
up in the interface. The numbers msgids in the nn-NO correspond
well wit the number of msgids in other sets of .po files.

I bet y'all will be happy when you don't have to see the stupid
Norwegian strings when you translate! ;-)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13893: [QA Follow-up] Move print statement, sort files in loop
Marcel de Rooy [Thu, 16 Apr 2015 13:34:25 +0000 (15:34 +0200)]
Bug 13893: [QA Follow-up] Move print statement, sort files in loop

Just moving the print statement for DEV updates to show them too for
the new perl format.
In the loop opendir..readdir is used; this might not be always in the
expected order. I added a sort to force the order.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13893: Add ability to execute perl scripts in atomicupdates
Kyle M Hall [Mon, 23 Mar 2015 13:19:03 +0000 (09:19 -0400)]
Bug 13893: Add ability to execute perl scripts in atomicupdates

Bug 13068 adds the ability to execute sql files from atomicupdates for
in process developments to reduce merge conflicts. We need to extend
this ability further to be able to handle perl code.

Revised Test Plan
-----------------
1) Run updatedatabase.pl
   -- Expect output to be similar to:
   $ ./installer/data/mysql/updatedatabase.pl
   DEV atomic update : test.perl
   Upgrade to XXX done (Bug 13893 - Add ability to execute perl scripts in atomicupdates)
2) Run koha qa test tools.
   -- only need to check last commit (-c 1), because first commit is a
      sample file which shouldn't be pushed.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13984: DBRev 3.19.00.034
Tomas Cohen Arazi [Wed, 29 Apr 2015 18:23:43 +0000 (15:23 -0300)]
Bug 13984: DBRev 3.19.00.034

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13984: Add atomic update - Insert pref CardnumberLength if not exists
Jonathan Druart [Mon, 13 Apr 2015 11:30:03 +0000 (13:30 +0200)]
Bug 13984: Add atomic update - Insert pref CardnumberLength if not exists

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13984: CardnumberLength missing in sysprefs.sql
Fridolin Somers [Mon, 13 Apr 2015 11:09:16 +0000 (13:09 +0200)]
Bug 13984: CardnumberLength missing in sysprefs.sql

Test plan :
- create a fresh database with installer
- check the presence of the syspref : select value from systempreferences where variable like 'CardnumberLength'

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14068: fix preinst for fresh package installs
Robin Sheat [Tue, 28 Apr 2015 03:19:30 +0000 (15:19 +1200)]
Bug 14068: fix preinst for fresh package installs

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works as expected. Tested both upgrading and on a new install.

9 years agoBug 11165: DBRev 3.19.00.033
Tomas Cohen Arazi [Wed, 29 Apr 2015 18:09:27 +0000 (15:09 -0300)]
Bug 11165: DBRev 3.19.00.033

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11165: (RM followup) DBIx updates
Tomas Cohen Arazi [Wed, 29 Apr 2015 18:07:56 +0000 (15:07 -0300)]
Bug 11165: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11165: Automatically save the authority last modification time
Jonathan Druart [Thu, 11 Dec 2014 15:49:34 +0000 (16:49 +0100)]
Bug 11165: Automatically save the authority last modification time

This patch rename the column auth_header.datemodified with modification_time.
Now this column will be automatically updated when a row will be
updated.

Test plan:
0/ Verify that la major part of your auth_header.datemodified is set to
null
1/ Execute the updatedb entry
2/ Verify that the column is renamed and the values have not been
changed.
3/ Update an authority and verify (using the sql cli) that this value
has been updated.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
In the absence of a coding guideline stipulating a preferred column
name for a timestamp, this modification_time works for me.
Null values are replaced by current time after db rev; other values
are left alone.
NOTE FOR RM: Please run update_dbix_class_files.pl.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13885: (QA followup) Remove tab, remove unnecessary permission check
Kyle M Hall [Fri, 17 Apr 2015 11:31:13 +0000 (07:31 -0400)]
Bug 13885: (QA followup) Remove tab, remove unnecessary permission check

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13885: Cataloging search header should include more options
Nick Clemens [Sat, 21 Mar 2015 14:51:24 +0000 (10:51 -0400)]
Bug 13885: Cataloging search header should include more options

This patch adds the check in and standard catalog search to cataloging-search.inc

To test:
1 - Apply patch
2 - Go to More->Cataloging
3 - Search in each tab (Cataloging search / Check out / Check in / Standard
    search) and ensure that all work as expected

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  - Added search options work properly, and are consistently named.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 1917 [QA Followup] - Don't limit the list results for RSS feeds
Kyle M Hall [Wed, 22 Apr 2015 11:36:51 +0000 (07:36 -0400)]
Bug 1917 [QA Followup] - Don't limit the list results for RSS feeds

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 1917 [QA Followup] - Remove unnecessary use of html filter
Kyle M Hall [Tue, 21 Apr 2015 13:52:49 +0000 (09:52 -0400)]
Bug 1917 [QA Followup] - Remove unnecessary use of html filter

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change...
Kyle M Hall [Mon, 20 Apr 2015 16:09:27 +0000 (12:09 -0400)]
Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 1917 - Add RSS Feeds for Lists
Kyle M Hall [Fri, 17 Apr 2015 18:02:15 +0000 (14:02 -0400)]
Bug 1917 - Add RSS Feeds for Lists

Test Plan:
1) Apply this patch
2) Create one or more public lists
3) View the list in the opac
4) Note the new RSS icon next to the list name
5) Open the link in FireFox or an RSS reader
6) You should see an RSS feed of your list with the title
   and author of each item as a hyperlink to the record details

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoRevert "Bug 8992: Use the existing greybox plugin in interface/theme"
Jonathan Druart [Wed, 29 Apr 2015 07:33:41 +0000 (09:33 +0200)]
Revert "Bug 8992: Use the existing greybox plugin in interface/theme"

This reverts commit 986b03e1c602b057275e343e3251a5cfbcc7cca6.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 4041: (QA followup) fix issues raised by koha-qa.pl
Tomas Cohen Arazi [Wed, 29 Apr 2015 15:04:07 +0000 (12:04 -0300)]
Bug 4041: (QA followup) fix issues raised by koha-qa.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 4041: DBRev 3.19.00.032
Tomas Cohen Arazi [Wed, 29 Apr 2015 14:30:34 +0000 (11:30 -0300)]
Bug 4041: DBRev 3.19.00.032

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 4041: Explain address format style in system preferences
Marc Véron [Wed, 29 Apr 2015 04:20:47 +0000 (06:20 +0200)]
Bug 4041: Explain address format style in system preferences

See comment #30 by Tomás Cohen Arazi

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 4041: (QA followup) Change addressformat to AddressFormat
Kyle M Hall [Fri, 10 Apr 2015 17:24:40 +0000 (13:24 -0400)]
Bug 4041: (QA followup) Change addressformat to AddressFormat

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
----
Amended to resolve conflict in sysprefs.sql / mveron
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 4041: Second Step: Add system preference and "German style" address formats for...
Marc Véron [Wed, 18 Feb 2015 16:23:57 +0000 (17:23 +0100)]
Bug 4041: Second Step: Add system preference and "German style" address formats for staff

To test:

Apply patch
Do a database update (e.g. by changing version number in kohaversion.pl)
Find new system preference 'addressformat' in I18N/L10N
Choose 'German style'
Go to Patrons and edit a patron / create new patron
Verify that Zip code appears above City
Change system preference to 'US style'
Verify that Zip code appears between State and Country.

BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g. fr for "French style") and copy / modify the includes using the same code as postfix.
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Patch amended to move street number after address. /Marc

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Amended do resolve conflict with updatedatabase.pl  /Marc
Rebased for current master /Marc

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 4041: Third step - Display address on patron's pages using the system preference
Marc Véron [Mon, 2 Mar 2015 20:33:20 +0000 (21:33 +0100)]
Bug 4041: Third step - Display address on patron's pages using the system preference

This patch displays the address information in the left column of the patron's pages using the new system preference.
The address is formatted in member-display-address-style-us.inc and member-display-address-style-de.inc

To test:
- Apply patch on top of 1st and 2nd patch
- Select 'German style' in system preference 'addressformat' in I18N/L10N
- Verify that the address information displays properly in the left column of all patron's pages.
- Verify that the address displays properly in the main area of moremember.pl as well (Note: In right column, Alternate address /contact are not yet touched))
- Switch system preference to US style, repeat checks

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
AMending without changes to put this patch at the end of the patch list / Marc

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 4041: First step (staff interface): Extract address blocks to include files
Marc Véron [Tue, 17 Feb 2015 21:36:45 +0000 (22:36 +0100)]
Bug 4041: First step (staff interface): Extract address blocks to include files

This patch extracts the address blocks in memberentrygen.tt to include files.

To test: The overall functionality should remain the same with this patch.

In further steps, more country- or region-dependent includes could be added, along with functionality to select them using a system preference.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13109: Serial failure for received and general viewing.
Mason James [Mon, 30 Mar 2015 06:33:45 +0000 (19:33 +1300)]
Bug 13109: Serial failure for received and general viewing.

to test...

1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate'

  an example url would be...
  http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1

  observe error...
  'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325'

2/ apply patch
3/ repeat step 1/
   observe that detail page displays OK

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I confirm the issue if startdate is null (can exist with old data,
before the js check on the form).
Amended patch: Remove trailing space char and the link to the bz number
(can be found using git log).

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8992: (QA followup) <body> was missing id and class
Tomas Cohen Arazi [Tue, 28 Apr 2015 21:11:35 +0000 (18:11 -0300)]
Bug 8992: (QA followup) <body> was missing id and class

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8992: DBRev 3.19.00.031
Tomas Cohen Arazi [Tue, 28 Apr 2015 19:33:27 +0000 (16:33 -0300)]
Bug 8992: DBRev 3.19.00.031

Some fixes too.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8992: Add 7..$3 to the Indentifier-standard index
Jonathan Druart [Wed, 7 Jan 2015 15:12:04 +0000 (16:12 +0100)]
Bug 8992: Add 7..$3 to the Indentifier-standard index

Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
9 years agoBug 8992: Add the greybox include file for the bootstrap theme
Jonathan Druart [Fri, 10 Oct 2014 02:12:00 +0000 (04:12 +0200)]
Bug 8992: Add the greybox include file for the bootstrap theme

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
9 years agoBug 8992: Use the existing greybox plugin in interface/theme
Jonathan Druart [Mon, 18 Aug 2014 09:25:58 +0000 (11:25 +0200)]
Bug 8992: Use the existing greybox plugin in interface/theme

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
9 years agoBug 8992: XSLT changes
Jonathan Druart [Wed, 23 Apr 2014 11:34:45 +0000 (13:34 +0200)]
Bug 8992: XSLT changes

This patch add the same behavior as previous patches for the xslt view.

Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
9 years agoBug 8992: DB changes - add the IdRef syspref
Jonathan Druart [Wed, 23 Apr 2014 11:33:25 +0000 (13:33 +0200)]
Bug 8992: DB changes - add the IdRef syspref

Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8992: Interfacing with the Idref webservice
Jonathan Druart [Wed, 23 Apr 2014 11:32:47 +0000 (13:32 +0200)]
Bug 8992: Interfacing with the Idref webservice

On the detail page (in the opac), if the biblio comes from the Sudoc,
you must have a link (on the right of the author link) which open a popup with
informations about this author (publications by role).

To test:

1/ Switch on the Idref system preference

2/ Simulate a SUDOC record:
  Fill a 7..$3 field with a ppn (032581270 for example).
  Fill the 009 field with an integer

3/ Go to the opac detail page of this notice.
You should see the IDREF link.
If you click on it, a popup displays a loading icon and after a few
seconds (depending of the productivity of the authority :)), a list of
roles. For each role, a table displays all his corresponding publications.

4/ On the right, you have 2 links: 1 for a koha search for this result
and 1 for a SUDOC link

Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10752: (QA followup) rephrase erorr messages a little
Katrin Fischer [Mon, 20 Apr 2015 20:15:02 +0000 (22:15 +0200)]
Bug 10752: (QA followup) rephrase erorr messages a little

Rephrased error messages a little and changed the link to
look like it does on other pages, for example when looking
at an order created from a suggestion.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
http://bugs.koha-community.org/show_bug.cgi?id=10752
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10752: Alert if the suggestion has not been added - OPAC
Jonathan Druart [Mon, 20 Apr 2015 08:08:07 +0000 (10:08 +0200)]
Bug 10752: Alert if the suggestion has not been added - OPAC

Same as previous patches for the OPAC.

Test plan is the same.

Tested with all patches applied. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10752: Remove the specific css for links in an error dialog
Jonathan Druart [Mon, 20 Apr 2015 07:44:23 +0000 (09:44 +0200)]
Bug 10752: Remove the specific css for links in an error dialog

Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489
Date:   Tue Mar 20 15:20:25 2012 +0100
    Bug 6209 [Revised] Standardize on one plugin for client-side form
    validation

It did not find how it could be useful.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10752: Alert the librarian if the suggestion has not been added
Jonathan Druart [Thu, 16 Apr 2015 14:57:03 +0000 (16:57 +0200)]
Bug 10752: Alert the librarian if the suggestion has not been added

Test plan:
- Create a new suggestion, chose a short term as your title and copy it.
- Leave all other fields of the suggestion form untouched.
- Save your first suggestion.
- Enter a second suggestion with the same title.

Before this patch, the suggestion was not inserted without alert.
With this patch, an alert is displayed on the interface.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Love the simplicity and ability to expand. :)

Tested with all pateches applied. Wors as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13919: Renewal possible with item level hold on item
Kyle M Hall [Mon, 30 Mar 2015 14:16:31 +0000 (10:16 -0400)]
Bug 13919: Renewal possible with item level hold on item

Test Plan:
1) Apply this patch
2) Enable AllowRenewalIfOtherItemsAvailable
3) Check out an item from a record with multiple holdable items
4) Place an item level hold on the checked out item
5) Verify the item can not be renewed from the opac

Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13919: Make the tests pass fixing the number of tests
Jonathan Druart [Mon, 13 Apr 2015 10:34:14 +0000 (12:34 +0200)]
Bug 13919: Make the tests pass fixing the number of tests

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13919: Unit Test
Kyle M Hall [Mon, 30 Mar 2015 14:16:11 +0000 (10:16 -0400)]
Bug 13919: Unit Test

Tested both unit test patches together.
Without main patch applied: do not pass as expected / with main patch pass OK as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 9878: Add consistentcy on restriction messages
Jonathan Druart [Thu, 9 Apr 2015 14:22:44 +0000 (16:22 +0200)]
Bug 9878: Add consistentcy on restriction messages

Between both pages circ/circulation.pl and members/moremember.pl, the
restriction messages should be the same.

Test plan:
1/ Add a non-unlimited restrictions to a patron
2/ Go on both pages and confirm the restriction message is the same.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12404: FIX documentation to join subfield
Jonathan Druart [Wed, 12 Nov 2014 10:16:03 +0000 (11:16 +0100)]
Bug 12404: FIX documentation to join subfield

To display all subfields, the join TT method must be used.

Signed-off-by: Courret <scourret@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12404: Allow equal sign '=' in the TT directive
Jonathan Druart [Wed, 5 Nov 2014 16:10:58 +0000 (17:10 +0100)]
Bug 12404: Allow equal sign '=' in the TT directive

Signed-off-by: Courret <scourret@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12404: Add some documentation in the help page.
Jonathan Druart [Tue, 11 Feb 2014 13:09:29 +0000 (14:09 +0100)]
Bug 12404: Add some documentation in the help page.

Signed-off-by: Courret <scourret@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12404: tools/export.pl allows CSV export
Jonathan Druart [Wed, 5 Feb 2014 15:44:24 +0000 (16:44 +0100)]
Bug 12404: tools/export.pl allows CSV export

Signed-off-by: Courret <scourret@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12404: Allow TT tags for csv profiles
Jonathan Druart [Tue, 11 Feb 2014 12:25:47 +0000 (13:25 +0100)]
Bug 12404: Allow TT tags for csv profiles

This patch is the main patch. It contains the changes in
C4::Record::marcrecord2csv.

The goal of this development is to provide a better flexibility on
creating a CSV profile.
Currently it is not possible to:
- Concatenate specific subfields into a csv column
- Display a field/subfield using a condition
- Extract a substring of a subfield value
and a lot of other actions.

This patch allows to write Template Toolkit code and to extract only
data you want.

See the help page for more information (in next patch).

Test plan:
Create some CSV profiles (MARC, not SQL) using some TT methods.
Use the basket export and the export tool and verify the CSV file
generated is what you expected.

Signed-off-by: Courret <scourret@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12404: Add new unit tests
Jonathan Druart [Tue, 11 Feb 2014 12:25:29 +0000 (13:25 +0100)]
Bug 12404: Add new unit tests

These unit tests reflect the changes done in next patches.

Signed-off-by: Courret <scourret@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12404: Add UT for marcrecord2csv
Jonathan Druart [Tue, 11 Feb 2014 12:21:59 +0000 (13:21 +0100)]
Bug 12404: Add UT for marcrecord2csv

Verify that these unit tests pass before any changes and after applying
all patches.

Signed-off-by: Courret <scourret@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10423: Show date due with time if it's a hourly loan
Jonathan Druart [Wed, 15 Apr 2015 13:33:54 +0000 (15:33 +0200)]
Bug 10423: Show date due with time if it's a hourly loan

On printing the summary from the patron account, the hours are not
displayed if needed.
The as_date_due flag should be set to display it correctly.
Problem, GetPendingIssues modify the value retrieved from the database.
In order to not add regression and check all calls to GetPendingIssues,
this patch backup the value before the change.

Test plan:
Check some items out, specify a hourly loan for some.
Click on print > print summary and confirm the date due are correctly
formatted.

Followed test plan. Date + time display as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10971: Hide EAN search for MARC21 / template corrections
Katrin Fischer [Sat, 21 Feb 2015 18:22:33 +0000 (19:22 +0100)]
Bug 10971: Hide EAN search for MARC21 / template corrections

This patch hides the EAN filter on the page for ordering from
a subscription when the marcflavour is not UNIMARC as it will
only work for this flavour currently.

It also corrects
- branch to library
- supplier to vendor
- the library code in the result list to the branch name

To test:
- Make sure you have a subscription, not the vendor
- Create a new basket for the subscription vendor
- Choose 'from a subscription' to create your order line
- Look at the filters on the left side, switch
  the marcflavour system preference to see change for
  the EAN filter
- Verify changes

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14055: remove symlink that breaks upgrades
Robin Sheat [Fri, 24 Apr 2015 02:48:53 +0000 (14:48 +1200)]
Bug 14055: remove symlink that breaks upgrades

Old versions of koha-common would put in a symlink to the system YUI
libraries. This causes upgrade problems, so we look out for that and zap
it if it's there.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14030: (RM followup) fix copypasta blooper
Tomas Cohen Arazi [Fri, 24 Apr 2015 13:12:32 +0000 (10:12 -0300)]
Bug 14030: (RM followup) fix copypasta blooper

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13992: Software error in reports if field or table does not exist
Marc Véron [Tue, 14 Apr 2015 08:28:03 +0000 (10:28 +0200)]
Bug 13992: Software error in reports if field or table does not exist

To reproduce:

- Go to Home > Reports Guided reports wizard
- Create report from SQL
- Enter something like: select holdrio from borrowers
- Save SQL
- run report

Result:
Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932.
expected: graceful error message

- Change sql to something like: select id from holdrio;
- Save SQL
- Run report

Result:
Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932.
expected:  graceful error message

- Change sql to something like: pling from plong
- Save SQL
Result (after saving): Message "The database returned the following error: 1"
Expected: Meaningful message "The database returned the following error: No SELECT" (similar to forbidden statements as UPDATE)

Test plan:
- Apply patch
- Try to reproduce issues above. They should be resolved.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14030: DBRev 3.19.00.030
Tomas Cohen Arazi [Fri, 24 Apr 2015 13:03:17 +0000 (10:03 -0300)]
Bug 14030: DBRev 3.19.00.030

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14030 - Added tests for duplicates.
Mark Tompsett [Tue, 21 Apr 2015 00:11:23 +0000 (20:11 -0400)]
Bug 14030 - Added tests for duplicates.

It seems that the id's are not really used, but rather
the subtags, types, and language related fields.

These tests check for duplicates.

TEST PLAN
---------
1) Apply both patches
2) prove -v t/db_dependent/Languages.t
   -- may fail if you have duplicates.
3) ./installer/data/mysql/updatedatabase.pl
   -- this will trigger the atomicupdate, which because of
      this tweak, will correct duplicates.
4) prove -v t/db_dependent/Languages.t
   -- should succeed.
5) Run the updatedatabase.pl script multiple times.
6) prove -v t/db_dependent/Languages.t
   -- should still succeed.
7) koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No koha-qa errors, test run successfully, no more duplicates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed German description.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14030: Add Georgian language and fix Kannada language code
Bernardo Gonzalez Kriegel [Tue, 21 Apr 2015 00:34:05 +0000 (21:34 -0300)]
Bug 14030: Add Georgian language and fix Kannada language code

This patch adds Georgian language and a fix wrong language code

Language added: Georgian - ka - geo
I selected 'geo' for ISO639-2 instead of 'kat' because it's the
same code form http://www.loc.gov/marc/languages/language_code.html

Also a fix is needed to Kannada ISO639-1 code, from 'ka' to 'kn'

To test:
1) Apply the patch
2) Run updatedatabase.pl (once)
3) Check language, e.g. go to staff > search > More options > Limits
and search for Georgian on language list

I only added language code 'ka', not script 'Geor' nor country 'GE',
the plan is to name translation files 'ka-*', but can ammend the patch
if needed.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13941: QA Follow-up - fix for acqui/addorder.tt
Katrin Fischer [Wed, 15 Apr 2015 21:33:00 +0000 (23:33 +0200)]
Bug 13941: QA Follow-up - fix for acqui/addorder.tt

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13941: [2/2] Fix <body> tags missing id/class
Frédéric Demians [Tue, 14 Apr 2015 14:27:48 +0000 (16:27 +0200)]
Bug 13941: [2/2] Fix <body> tags missing id/class

Followed test plan from patch 1/2, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13941: [1/2] Test <body> tag with id/class attributes
Frédéric Demians [Tue, 14 Apr 2015 14:26:50 +0000 (16:26 +0200)]
Bug 13941: [1/2] Test <body> tag with id/class attributes

Test:

- Apply the first patch [1/2] containing a new test checking <body> tags in all
  templates
- Run the test: prove xt/tt_valid.t
- You get a list of templates with invalid <body> tags.
- Apply the second patch [2/2] fixing all invalid <body> tags.
- Re-run the test: It passes.

Folowed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13492: Add the location column to the checkouts tables
Jonathan Druart [Tue, 23 Dec 2014 10:59:07 +0000 (11:59 +0100)]
Bug 13492: Add the location column to the checkouts tables

Test plan:
1/ Verify that the location column is correctly displayed on the
checkouts tables (circ/circulation.pl and members/moremember.pl).
2/ Verify that you can hide/show this column (using the admin page
and/or the ColVis DT plugin).

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13492: Add the column configuration for the checkouts table - morember.pl
Jonathan Druart [Tue, 23 Dec 2014 10:45:11 +0000 (11:45 +0100)]
Bug 13492: Add the column configuration for the checkouts table - morember.pl

Test plan:
1/ Verify that you can show/hide columns on the checkouts table (moremember.pl).
2/ Play with the column configuration admin page (admin/columns_settings.pl),
and confirm the behavior is correct (depends on what you have selected).

Amended patch: replace 'un' and 'deux' with 'sort_order' and
'todays_or_previous_checkouts' in the yml file.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13492: Add the column configuration for the checkouts table - circulation.pl
Jonathan Druart [Tue, 23 Dec 2014 10:30:33 +0000 (11:30 +0100)]
Bug 13492: Add the column configuration for the checkouts table - circulation.pl

Test plan:
1/ Verify that you can show/hide columns on the checkouts table (circulation.pl).
2/ Play with the column configuration admin page (admin/columns_settings.pl),
and confirm the behavior is correct (depends on what you have selected).

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13606: DBRev 3.19.00.029
Tomas Cohen Arazi [Thu, 23 Apr 2015 16:23:54 +0000 (13:23 -0300)]
Bug 13606: DBRev 3.19.00.029

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13606: (RM followup) DBIx updates
Tomas Cohen Arazi [Thu, 23 Apr 2015 16:22:41 +0000 (13:22 -0300)]
Bug 13606: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13606: Add tests and fix existing ones
Jonathan Druart [Fri, 10 Apr 2015 13:35:54 +0000 (15:35 +0200)]
Bug 13606: Add tests and fix existing ones

Some tests were wrong and not executed in a transaction.
Lot of sessions were created in DB because the session was never
flushed.

TEST PLAN
---------
$ mysql ...
> delete from sessions;
^Z
$ prove -v t/db_dependent/BackgroundJob.t
...
$ fg
> select id from sessions;
-- There will be lots of ids (10, if I recall)
^Z
$ git bz apply 13606
...
$ prove -v t/db_dependent/BackgroundJob.t
...
$ fg
> select * from sessions;
-- there should only be the one orphaned job.
   You can tell it is correct by the "making new job".
> quit

Run the koha-qa test tools.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoBug 13606 Clear job data in session when the job is completed
Frédéric Demians [Fri, 10 Apr 2015 06:44:39 +0000 (08:44 +0200)]
Bug 13606 Clear job data in session when the job is completed

Bug 11395 uses the session to store the report sent to the interface
(update on biblio XX OK, etc.).

If the session is stored in mysql, the max size of the
sessions.a_session will be reached easily (TEXT field).

To reproduce:
0/ Set SessionStorage to 'mysql'
1/ Create a file with 500 biblionumbers:
  mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt
2/ Define a marc modification template (something like "delete field 99$9" is nice)
3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool
4/ Repeat 3
You will get:
  Syck parser (line 1534, column 6): syntax error at
  /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75.
None Koha page is reachable.

It comes from get_template_and_user > checkauth > get_session >
l.1595 $session = new CGI::Session("driver:MySQL;serializer:yaml;id:md5", $sessionID, {Handle=>$dbh});

5/ Get your sessionID contained in your CGISESSID cookie
Have a look at the value a_session in the sessions table:
mysql> select a_session from sessions where id="YOUR_SESSIONID";

You should see that the yaml is not correctly ended.
The size of the DB field has been reached and the yaml is truncated.

Test plan:
0/ Delete your CGISESSID cookie
1/ Try to reproduce the previous issue
2/ After the second batch, have a look at the sessions table and confirm
that only one job_$JOB_ID exist in the yaml

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
NOTE: Nicely clears batch job session information.
      (2) is incorrect. This cleans up after a full run.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoBug 13606: Upgrade sessions.a_session to MEDIUMTEXT
Jonathan Druart [Wed, 21 Jan 2015 14:59:10 +0000 (15:59 +0100)]
Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT

The previous patch fixed partially the problem.
If you try to update more that 1000 records, you will get the same
error.

This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb).

Test plan:
1/ Try to modify a huge amount of records (1000 should be enough)
2/ Confirm it worked!

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
I confirm that with more than 1000 records the session object is truncated, and
then can't be anymore be desirialized, blocking completely Koha. Fixed with
this patch.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
This only pushes off the problem expontentially (64KB vs. 16MB), but this is a
good start.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoBug 13790: (RM followup) DBIx updates
Tomas Cohen Arazi [Thu, 23 Apr 2015 16:06:00 +0000 (13:06 -0300)]
Bug 13790: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13790: DBRev 3.19.00.028
Tomas Cohen Arazi [Thu, 23 Apr 2015 16:01:40 +0000 (13:01 -0300)]
Bug 13790: DBRev 3.19.00.028

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13790 [QA Followup] - Disable auto increment on old_issues after pk values are...
Kyle M Hall [Mon, 20 Apr 2015 12:21:08 +0000 (08:21 -0400)]
Bug 13790 [QA Followup] - Disable auto increment on old_issues after pk values are created

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>