]> git.koha-community.org Git - koha.git/log
koha.git
15 years agobug 3481: add deleditems.permanent_location (DB rev 052)
Galen Charlton [Mon, 24 Aug 2009 00:51:52 +0000 (20:51 -0400)]
bug 3481: add deleditems.permanent_location (DB rev 052)

Whenever a column is added to items, it must also be added
to deleteditems - otherwise, whenever an item is deleted,
it will not be saved to deleteditems.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoassigned typo fixes to DBrev 051
Galen Charlton [Mon, 24 Aug 2009 00:35:04 +0000 (20:35 -0400)]
assigned typo fixes to DBrev 051

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoFixed minor typos in new system preferences.
Nicole Engard [Sun, 23 Aug 2009 16:18:34 +0000 (12:18 -0400)]
Fixed minor typos in new system preferences.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoadded newlines back to sample_notices.sql
Galen Charlton [Mon, 24 Aug 2009 00:25:27 +0000 (20:25 -0400)]
added newlines back to sample_notices.sql

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 2611, 1934 followup - DBrevs 049 and 050
Galen Charlton [Mon, 24 Aug 2009 00:21:27 +0000 (20:21 -0400)]
bug 2611, 1934 followup - DBrevs 049 and 050

Assigned DBrevs as follows:

049: additional correction per bug 2611
050: OPACSearchForTitleIn system preference

Also fixed syntax errors in code for 050.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoREVISED: Fixed some typos and language in the sample notices.
Nicole Engard [Sun, 23 Aug 2009 10:49:18 +0000 (06:49 -0400)]
REVISED: Fixed some typos and language in the sample notices.

Realized that we don't want to update the notices in existing installs
as this would overwrite any changes and customizations libraries
may have made.

Original commit: 10b7bab4445c92f7f647be53e4b0ea858cbb2a84

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 1934: Add system preference to handle editing of 'More searches'
Nicole Engard [Sun, 23 Aug 2009 09:41:34 +0000 (05:41 -0400)]
Bug 1934: Add system preference to handle editing of 'More searches'

This preference allows librarians to control which links appear
in the 'More Searches' box on the opac detail page. If the
preference is left blank the 'More Searches' menu will not apear
on the opac detail page at all.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoChanged catlogue to catalog per the standard
Nicole Engard [Wed, 19 Aug 2009 03:01:40 +0000 (23:01 -0400)]
Changed catlogue to catalog per the standard

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoFixed some typos and language in the sample notices.
Nicole Engard [Sun, 16 Aug 2009 21:45:47 +0000 (17:45 -0400)]
Fixed some typos and language in the sample notices.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBUG 2611: Changed catalogue to catalog and fixed capitalization.
Nicole Engard [Sun, 16 Aug 2009 21:23:03 +0000 (17:23 -0400)]
BUG 2611: Changed catalogue to catalog and fixed capitalization.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 2611, 2761 followup
Galen Charlton [Sun, 23 Aug 2009 23:06:06 +0000 (19:06 -0400)]
bug 2611, 2761 followup

* set DB changes as revs 047 and 048
* ensured that itemcallnumber was widened to 255 in items and
  tmp_holdsqueue
* adjusted DB update descriptions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBUG 2611: Changed catalogue to catalog and fixed capitalization.
Nicole Engard [Sun, 16 Aug 2009 21:23:03 +0000 (17:23 -0400)]
BUG 2611: Changed catalogue to catalog and fixed capitalization.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBUG 2761 Fix max length of itemcallnumber to 255
Nicole Engard [Sun, 16 Aug 2009 17:51:39 +0000 (13:51 -0400)]
BUG 2761 Fix max length of itemcallnumber to 255

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3464 followup - fix glitches
Galen Charlton [Sun, 23 Aug 2009 22:37:19 +0000 (18:37 -0400)]
bug 3464 followup - fix glitches

* Fixed 'counry' typo
* added country and B_country to deleteborrowers

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3464: set to DBrev 046 for new borrowers columns
Galen Charlton [Sun, 23 Aug 2009 22:20:25 +0000 (18:20 -0400)]
bug 3464: set to DBrev 046 for new borrowers columns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3464: Takes columns country and B_country of table borrowers into account in...
Sébastien Hinderer [Sun, 2 Aug 2009 05:50:08 +0000 (07:50 +0200)]
bug 3464: Takes columns country and B_country of table borrowers into account in related operations.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoDatabase structure modification.
Sébastien Hinderer [Sat, 1 Aug 2009 11:05:55 +0000 (13:05 +0200)]
Database structure modification.

Adds the country and B_country columns to the borrowers table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3539: tweaked English description of HidePatronName syspref
Galen Charlton [Sun, 23 Aug 2009 17:57:26 +0000 (13:57 -0400)]
bug 3539: tweaked English description of HidePatronName syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3539, Adding a systempreference to hide borrowers name on the catalogue detail...
Chris Cormack [Wed, 19 Aug 2009 08:21:13 +0000 (20:21 +1200)]
Bug 3539, Adding a systempreference to hide borrowers name on the catalogue detail page, and holds page

Squashed commit of the following:

commit e9dd6e1dee03fe3503f7995b57510f9edfe6b333
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:14:53 2009 +0000

    Version number

commit df3ee5473e79b760a91c62b96d7ce19229e0fd27
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:08:11 2009 +0000

    French systempref

commit c4b036e4e43947d7d1fb9f2e18e460788cb4e1ec
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 00:25:33 2009 +0000

    Code to update the database, and updating the sysprefs.sql

commit f74b942c24d5e9c33a4ec0e5ac706a0e347eb1a7
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 02:07:22 2009 +0000

    Now hides the name on the detail screen too

commit 53c80dbef88e360a4bbb78ecff3a6ca6ec401398
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 01:35:19 2009 +0000

    Allowing the librarians to choose to hide the borrowers name on holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3485: fixed updatedatbase (also DBRev 043->044)
Galen Charlton [Sun, 23 Aug 2009 17:23:21 +0000 (13:23 -0400)]
bug 3485: fixed updatedatbase (also DBRev 043->044)

* Fixed case of copy-and-pastitis in DBrev descrieption
* Inserted description for new syspref

NOTE: Please do not leave the system preference description blank
in the updatedatabase entry - even for non-English users, an English
description is more useful than a blank one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3485: Clear Borrower record after checkout.
PTFS Contractor [Sun, 26 Jul 2009 18:56:01 +0000 (19:56 +0100)]
bug 3485: Clear Borrower record after checkout.

Button added to clear the last Borrower record after transaction is complete
To enable, turn on the syspref DisplayClearScreenButton.

This work was sponsored by Middletown Township Public Library, Middletown, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3481: imporve cart_to_shelf.pl
Galen Charlton [Sun, 23 Aug 2009 17:06:00 +0000 (13:06 -0400)]
bug 3481: imporve cart_to_shelf.pl

Use revised CartToShelf() to insure that indexer
knows to reindex affected bib records.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3481 followup - ensure permanent location is stored when updating item
Galen Charlton [Sun, 23 Aug 2009 16:53:06 +0000 (12:53 -0400)]
bug 3481 followup - ensure permanent location is stored when updating item

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3481 followup - improve CartToShelf
Galen Charlton [Sun, 23 Aug 2009 16:51:12 +0000 (12:51 -0400)]
bug 3481 followup - improve CartToShelf

* added POD
* removed optional $barcode argument - in all cases,
  itemnumber is known, and we should stick with
  itemnumber when retrieving an existing item
* use ModItem to do the update so that indexer
  will know to reindex bib - otherwise, can't
  do an accurate search of items that are on
  the shelving cart.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3481 followup - set temporary processing location
Galen Charlton [Sun, 23 Aug 2009 16:49:17 +0000 (12:49 -0400)]
bug 3481 followup - set temporary processing location

Ensure that the temporary processing location is always
set regardless of whether one item is added or multiple
copies are added at once.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agocosmetic fix - use $itemnumber as argument to GetItems when available
Galen Charlton [Sun, 23 Aug 2009 16:48:34 +0000 (12:48 -0400)]
cosmetic fix - use $itemnumber as argument to GetItems when available

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3481 followup - add new sysprefs to circulation section
Galen Charlton [Sun, 23 Aug 2009 16:47:52 +0000 (12:47 -0400)]
bug 3481 followup - add new sysprefs to circulation section

15 years agobug 3481 followup - fix database update
Galen Charlton [Sun, 23 Aug 2009 16:46:28 +0000 (12:46 -0400)]
bug 3481 followup - fix database update

Set items.permanent_location to the current value
of items.location - otherwise, the item shelving location
could get blanked as existing items are checked in.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3481: Allow Item Temporary Locations for Processing and Shelving.
Colin Campbell [Mon, 27 Jul 2009 15:33:00 +0000 (16:33 +0100)]
bug 3481: Allow Item Temporary Locations for Processing and Shelving.

Allows temporary locations corresponding to 'in processing' and 'shelving'
so that newly-created items, and newly-returned items do not show
immediately as a available. Three new system preferences govern the usage
of these features.

NewItemsDefaultLocation. If system pref NewItemsDefaultLocation is set to a location code,
 all newly catalogued items will be set to the location set in this preference.
 Location code must be a valid LOC authorized value type.

InProcessingToShelvingCart. if the system pref InProcessingToShelvingCart is turned on,
any items run through returns.pl with a location code for 'PROC', will be modified to
have a new location code of 'CART'.

ReturnToShelvingCart.  If the syspref ReturnToShelvingCart is turned on,
all items returned other than confirmed holds will have a new location code of 'CART'.
Any item issued is automatically taken of the shelving cart.

Adds a cron script shelf_to_cart.pl which should be run hourly.
Updates all items with a location of CART to the item's permanent location.

The original location code is stored in the new items column 'permanent_location'.

Original Author: PTFS Contractor <dbavousett@ptfs.com>

This work co-sponsored by
  Middletown Township Public Library, Middletown, NJ USA  and
  East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofix how patron_flagged gets set for opac-user.tmpl
Galen Charlton [Sun, 23 Aug 2009 15:26:35 +0000 (11:26 -0400)]
fix how patron_flagged gets set for opac-user.tmpl

Remove unneeded variable and get value from $borr->{'flagged'}
directly, avoiding glitch where $borr->{'flagged'} could be
set after old $patron_flagged variable was set.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3493: DBrev 041->042 (added OPACFineNoRenewals)
Galen Charlton [Sun, 23 Aug 2009 14:16:41 +0000 (10:16 -0400)]
bug 3493: DBrev 041->042 (added OPACFineNoRenewals)

Also changed default value of OPACFineNoRenewals to 99999
when upgrading existing databases so that there's no (likely)
sudden change in OPAC behavior.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoPrevent OPAC renewals if fines are over limit
Jesse Weaver [Sun, 26 Jul 2009 12:28:47 +0000 (13:28 +0100)]
Prevent OPAC renewals if fines are over limit

This introduces a new system preference, OPACFineNoRenewals, that sets a
limit on the total fines a patron can have before they can no longer
renew their own books. opac-user.pl has been updated to obey this limit.

This work sponsered by East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoimplement bailing out of AddReturn if IndependantBranches is on
Galen Charlton [Sun, 23 Aug 2009 14:01:19 +0000 (10:01 -0400)]
implement bailing out of AddReturn if IndependantBranches is on

If IndependantBranches is ON and user attempts to return an
item at a library other than the item's home library, bail out.
This action, which was previously just a suggestion in the code,
is now required to ensure that the item doesn't get its
holdingbranch set to the library at which the attempt to return
the item was made.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3409 followup - fix use of $hbr
Galen Charlton [Sun, 23 Aug 2009 13:53:56 +0000 (09:53 -0400)]
bug 3409 followup - fix use of $hbr

$hbr in this context is a branch code, not an
item field.

Also added use of C4::Debug;

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAddReturn now always updates holdingbranch
Galen Charlton [Sun, 23 Aug 2009 13:51:50 +0000 (09:51 -0400)]
AddReturn now always updates holdingbranch

Prior to this patch, this was done only when returning
an item after it had been out on loan.  Even if the
item had not been on loan, the fact that it was checked
in means that it is now in fact at the new holding library.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3409 follow: fix crash if holdingbranch is undef
Galen Charlton [Sun, 23 Aug 2009 13:19:49 +0000 (09:19 -0400)]
bug 3409 follow: fix crash if holdingbranch is undef

Make _GetCircControlBranch() default to the item's home library
in the case where it otherwise would have returned the item's
holding library but that field is null.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3409 followup: renamed _GetCirculationBranch
Galen Charlton [Sun, 23 Aug 2009 13:03:11 +0000 (09:03 -0400)]
bug 3409 followup: renamed _GetCirculationBranch

New name is  _GetCircControlBranch so as not to confuse
the library that a circulation transaction is taking
place at with the library that is supposed to control
circulation policy lookup.

Also fixed formatting errors in _GetCircControlBranch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3409 followup: always set holdinglibrary to library last seen at
Galen Charlton [Sun, 23 Aug 2009 12:53:39 +0000 (08:53 -0400)]
bug 3409 followup: always set holdinglibrary to library last seen at

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug fix 3409 : Adding an internal function to C4::Circulation
Henri-Damien LAURENT [Thu, 13 Aug 2009 12:58:26 +0000 (14:58 +0200)]
Bug fix 3409 : Adding an internal function to C4::Circulation

This patch add the use of CircControl and HomeOrHoldingBranch for return and transfert rules.
* ItemHomeLibrary goes to item{HomeOrHoldingBranch}
* PatronLibrary goes to the borrower library
* PickupLibrary depends where the items was checked out, and the actual library.

This add a little improvment that does not re-request each time the circcontrol syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago(bug #2829) fix some mistakes extracting editor segment
Nahuel ANGELINETTI [Wed, 19 Aug 2009 13:22:24 +0000 (15:22 +0200)]
(bug #2829) fix some mistakes extracting editor segment

This patch fix how to extract the editor segment, and improve ISBN10/13 support.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBUG 3371: ISBN no longer shows twice when more options on
Nicole Engard [Sat, 22 Aug 2009 14:30:36 +0000 (10:30 -0400)]
BUG 3371: ISBN no longer shows twice when more options on

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBUG #3533: Fix documentation link in news for new installs
Nicole Engard [Sat, 22 Aug 2009 14:05:49 +0000 (10:05 -0400)]
BUG #3533: Fix documentation link in news for new installs

This patch only fixes the link for new installs, not for
updates.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoCleaned up display on reports page
Nicole Engard [Wed, 19 Aug 2009 01:31:03 +0000 (21:31 -0400)]
Cleaned up display on reports page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAdds helpful note to Home Phone and Home Email fields to remind staff which fields...
Liz Rea [Tue, 18 Aug 2009 14:47:08 +0000 (09:47 -0500)]
Adds helpful note to Home Phone and Home Email fields to remind staff which fields are shown on transit slips.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2652 - This patch is an extension of the slip printing feature
Darrell Ulm [Wed, 19 Aug 2009 16:39:32 +0000 (12:39 -0400)]
Bug 2652 - This patch is an extension of the slip printing feature

and will print a SHORT SLIP of today's checkouts only.
 I also enhanced the normal slip to print the overdues separately as well as today's
 checkouts. There is another button on the print CIRC menu. Easily another quick key
 can be added, one for the regular slip and one for the short slip, i.e. today's
 only.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAvoid numeric comparisons with leading zeroes
Colin Campbell [Thu, 20 Aug 2009 10:12:57 +0000 (11:12 +0100)]
Avoid numeric comparisons with leading zeroes

Numbers in perl with leading zeros are interpreted in octal
Ensure that comparisons are done using string operators
or where appropriate use the MARC::Field method

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAdding Katrin to the tranlsation tab on the about page
Chris Cormack [Thu, 20 Aug 2009 10:40:19 +0000 (22:40 +1200)]
Adding Katrin to the tranlsation tab on the about page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3420: Revised follow-up patch for 'patrons with no checkouts'
Garry Collum [Thu, 20 Aug 2009 19:22:57 +0000 (15:22 -0400)]
Bug 3420: Revised follow-up patch for 'patrons with no checkouts'

Comments out all warnings that were used for debugging.

Enables warnigns and fixes the resulting warnings.

This patch replaces the previous follow-up patch for bug 3420.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2889: Adds table highlighting to the Authority search results.
Garry Collum [Thu, 20 Aug 2009 22:07:08 +0000 (18:07 -0400)]
Bug 2889: Adds table highlighting to the Authority search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoEdits to the about page : Adding a couple of missing developers, and adding ohloh...
Chris Cormack [Thu, 20 Aug 2009 22:27:42 +0000 (10:27 +1200)]
Edits to the about page : Adding a couple of missing developers, and adding ohloh links, still more links to go

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enables warnings in reserveratios.pl
Garry Collum [Thu, 20 Aug 2009 23:32:18 +0000 (19:32 -0400)]
Bug 2505: Enables warnings in reserveratios.pl

Also fixes resulting warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoRemove utility script replaced by a test case
Frédéric Demians [Mon, 17 Aug 2009 18:35:27 +0000 (20:35 +0200)]
Remove utility script replaced by a test case

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3532 show lost, damaged statuses on patron record
Jane Wagner [Mon, 17 Aug 2009 14:14:44 +0000 (10:14 -0400)]
Bug 3532 show lost, damaged statuses on patron record

The patron record Details tab list of checkouts does not show lost, long overdue, claims returned, or damaged status, only that an item is overdue.  Added a check for lost and damaged statuses and a display of any matching statuses to the patron Details tab.

(revised version to drop unneeded lines from moremember.tmpl file)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoTest case identifying incoherences between 'en' sysprefs and translated ones
Frédéric Demians [Mon, 17 Aug 2009 18:35:26 +0000 (20:35 +0200)]
Test case identifying incoherences between 'en' sysprefs and translated ones

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoFollow up patch for the about patch, changing management team to release team
Chris Cormack [Mon, 17 Aug 2009 10:52:04 +0000 (22:52 +1200)]
Follow up patch for the about patch, changing management team to release team

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoUpdating about page, some are bound to be missed, please send additional patches
Chris Cormack [Sat, 15 Aug 2009 22:18:16 +0000 (10:18 +1200)]
Updating about page, some are bound to be missed, please send additional patches

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3420: Fixes 'Patrons with no checkouts' report.
Garry Collum [Sat, 15 Aug 2009 13:50:24 +0000 (09:50 -0400)]
Bug 3420: Fixes 'Patrons with no checkouts' report.

Fixed typo in SQL statement.  Commented out some unused SQL statements.

Removed limit for itemtype (column not available in results) and added limit for branchcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofixed glitch in display of current time filter in OPAC top issues
Galen Charlton [Sat, 15 Aug 2009 13:45:38 +0000 (09:45 -0400)]
fixed glitch in display of current time filter in OPAC top issues

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoTranslating unimarc_leader plugin in english
Henri-Damien LAURENT [Thu, 13 Aug 2009 13:07:03 +0000 (15:07 +0200)]
Translating unimarc_leader plugin in english

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobugfix invalid comparison to ceilingDueDate in CalcDateDue()
Michael Hafen [Thu, 13 Aug 2009 22:12:33 +0000 (16:12 -0600)]
bugfix invalid comparison to ceilingDueDate in CalcDateDue()

The comparison to check the ceilingDueDate is done in the syspref format,
which isn't a good comparison.  This changes to code so the comparison is done
using iso format.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac-topissues.pl
Garry Collum [Fri, 14 Aug 2009 00:31:39 +0000 (20:31 -0400)]
Bug 2505: Enabled warnings in opac-topissues.pl

Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box.  It would not retain its value on subsequent pages if 'no Limit' was selected as an option.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.
Garry Collum [Fri, 14 Aug 2009 20:14:48 +0000 (16:14 -0400)]
Bug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.

Form - Fixes alphabetization of dropdowns.

Results - Fixes format of "Date last seen" to be the system date preference.  Adds highlighting to the table.

Enables warnings. Pages generated no warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoUpdated Help Files - Part 4
Nicole Engard [Sat, 15 Aug 2009 01:00:33 +0000 (20:00 -0500)]
Updated Help Files - Part 4

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoUpdated help files - Part 3
Nicole Engard [Sat, 15 Aug 2009 00:47:13 +0000 (19:47 -0500)]
Updated help files - Part 3

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoMore Updated Help Files
Nicole Engard [Fri, 14 Aug 2009 00:30:42 +0000 (19:30 -0500)]
More Updated Help Files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoUpdates and adds new help files
Nicole Engard [Thu, 13 Aug 2009 21:38:35 +0000 (16:38 -0500)]
Updates and adds new help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoMerge branch 'translation' of git://git.workbuffer.org/git/koha into test
Galen Charlton [Sat, 15 Aug 2009 13:24:28 +0000 (09:24 -0400)]
Merge branch 'translation' of git://git.workbuffer.org/git/koha into test

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoStarting work on translations for 3.2
Chris Cormack [Sat, 15 Aug 2009 06:36:22 +0000 (18:36 +1200)]
Starting work on translations for 3.2

15 years agoadded new module dep Digest::SHA to about.pl
Galen Charlton [Thu, 13 Aug 2009 13:29:28 +0000 (09:29 -0400)]
added new module dep Digest::SHA to about.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: tweaks to AWS request signing
Galen Charlton [Thu, 13 Aug 2009 13:25:34 +0000 (09:25 -0400)]
bug 3204: tweaks to AWS request signing

* Add AWSPrivateKey system preference to the
  Enhanced Content tab in the syspref editor
* Now warns to log if attempting to use
  the Amazon API without setting AWSPrivateKey

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: add AWSPrivateKey syspref (DBrev 040->041)
Galen Charlton [Thu, 13 Aug 2009 13:16:32 +0000 (09:16 -0400)]
bug 3204: add AWSPrivateKey syspref (DBrev 040->041)

The AWSPrivateKey syspref is describe more fully
in a previous commit, but to summarize, it should
contain the Amazon Web Services Secret Access Key
required by Amazon to sign requests to their
Product Advertising API.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: followup to fix AWS request signing
Galen Charlton [Thu, 13 Aug 2009 12:55:25 +0000 (08:55 -0400)]
bug 3204: followup to fix AWS request signing

[1] There were some ersataz spaces in the string
    being signed.
[2] AWS expects a trailing '=' in the Base64 signature

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: implement request signing for Amazon Web Services
Henri-Damien LAURENT [Tue, 7 Jul 2009 13:44:26 +0000 (15:44 +0200)]
bug 3204: implement request signing for Amazon Web Services

After 2009-08-15, Amazon Web Services will expect that
all requests to the Product Advertising API, which is what
Koha uses for retrieving reviews and other enhanced content
from Amazon, include signatures.  This patch and
subsequenct patches implement this functionality.

What this means in practice (assuming the user has elected
to use any enhanced content from Amazon) is that

[1] The user must get a Amazon Secret Access Key.  This can
    be done by logging in to the user's AWS account
    at (e.g.) http://aws.amazon.com/, going to the 'Access Identifiers'
    page, and from there retrieving and/or creating a new Secret
    Access Key.

[2] The contents of the Secret Access Key should then be
    entered into the new AWSPrivateKey system preference.

Once that is done, grabbing reviews and table of contents from Amazon
should work as normal.  If the user doesn't do this before 2009-08-15,
reviews and TOCs will no longer be supplied from Amazon, although there
should be no crashes - the content will simply not show up.

Note that the requirement to sign requests does *NOT* appear to apply
to simply displaying book covers from Amazon.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoENH: 3525 - Link to OPAC View from Staff Bib
Nicole Engard [Wed, 12 Aug 2009 22:38:08 +0000 (17:38 -0500)]
ENH: 3525 - Link to OPAC View from Staff Bib

This patch adds a link to the OPAC view for a bib
record from the staff client so catalogers can
preview changes as the patrons see them.

This patch only shows the link is the OPACBaseURL
system preference has a value.

[RM note re bug 2152: this is probably enough to keep
 OPACBaseURL after all - the staff interface has
 no other way of reliably knowing where the OPAC
 is.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago(Bug 3527) Removed unnecessary WHERE from UPDATE statement
James Winter [Wed, 12 Aug 2009 15:07:54 +0000 (11:07 -0400)]
(Bug 3527) Removed unnecessary WHERE from UPDATE statement

The WHERE in this statement selected a bunch of different accounttypes, mostly legacy items.
But for sub writeoff to be called in the first place, it must have been an account with a
positive amountoustanding already, and we have the borrowernumber and accountnumber, so this
WHERE was un-needed, and prevented writeoff of locally-defined manual invoice types.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoModified write in fines.pl to silence message unless verbose is set.
James Winter [Wed, 12 Aug 2009 15:24:30 +0000 (11:24 -0400)]
Modified write in fines.pl to silence message unless verbose is set.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac-export.pl and opac-sendbasket.pl
Garry Collum [Wed, 12 Aug 2009 17:12:37 +0000 (13:12 -0400)]
Bug 2505: Enabled warnings in opac-export.pl and opac-sendbasket.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enable warnings in opac-passwd.pl an opac-renew.pl.
Garry Collum [Wed, 12 Aug 2009 18:09:02 +0000 (14:09 -0400)]
Bug 2505: Enable warnings in opac-passwd.pl an opac-renew.pl.

Fixed resulting warnings in opac-renew.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoTerminology correction: we now use the term "hold" instead of "reserve"
Owen Leonard [Wed, 12 Aug 2009 13:44:46 +0000 (08:44 -0500)]
Terminology correction: we now use the term "hold" instead of "reserve"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoTerminology correction: we now use the term "hold" instead of "reserve"
Owen Leonard [Wed, 12 Aug 2009 13:54:52 +0000 (08:54 -0500)]
Terminology correction: we now use the term "hold" instead of "reserve"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoHide z39.50 search button for users without cataloging privileges.
Owen Leonard [Wed, 12 Aug 2009 14:57:51 +0000 (09:57 -0500)]
Hide z39.50 search button for users without cataloging privileges.

This also simplifies the display of the z39.50 search button on the search results page. It's overkill to use a YUI button when there are already simpler standard buttons in use in the same area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAdding some style to the OPAC search results page's "highlight" link
Owen Leonard [Wed, 12 Aug 2009 16:19:20 +0000 (11:19 -0500)]
Adding some style to the OPAC search results page's "highlight" link

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoFix for Bug 3256, "Long email address cut off in patron windows"
Owen Leonard [Wed, 12 Aug 2009 17:07:08 +0000 (12:07 -0500)]
Fix for Bug 3256, "Long email address cut off in patron windows"

This fix tweaks the overflow settings for the email address and adds an image of an elipsis as the background, giving the appearance that the text is being truncated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac-userupdate.pl
Garry Collum [Wed, 12 Aug 2009 00:46:21 +0000 (20:46 -0400)]
Bug 2505: Enabled warnings in opac-userupdate.pl

Enabled warnings.  Corrected all resulting warnings by initializing variables.

Some fixes and enhancements possibly related to Bug: 1153 - Existing B_address now shows in the resulting email. Birthdate now appears in the email using the System's default format. If the patron changes data in the form data took place the FIELD name now appears as uppercase in the resulting email.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago3519 : mergeauthority and authority edition were not synched
Henri-Damien LAURENT [Tue, 11 Aug 2009 12:55:49 +0000 (14:55 +0200)]
3519 : mergeauthority and authority edition were not synched

mergeauthority and ModAuthority were working on two separate directories.
So that no authority would ever be merged via cronjob or commandline script
when MergeAuthoritiesOnUpdate is disable

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofuture hold request followup 4 - date controls
Galen Charlton [Tue, 11 Aug 2009 23:21:36 +0000 (19:21 -0400)]
future hold request followup 4 - date controls

Fixed the calendar control for selecting the request
date in staff and OPAC so that user can explicitly
select current date and all days in the future.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofuture hold request followup 3 - build_holdsqueue
Galen Charlton [Tue, 11 Aug 2009 23:20:48 +0000 (19:20 -0400)]
future hold request followup 3 - build_holdsqueue

Fixed the holds queue job so that it correctly
ignores hold requests that are not yet scheduled
to be filled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofuture hold request followup 2 - fix queries
Galen Charlton [Tue, 11 Aug 2009 23:19:50 +0000 (19:19 -0400)]
future hold request followup 2 - fix queries

Clarify when it is necessary to add a
'reservedate <= CURRENT_DATE()' clause.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofuture hold request followup 1 - updatedatabase
Galen Charlton [Tue, 11 Aug 2009 23:18:56 +0000 (19:18 -0400)]
future hold request followup 1 - updatedatabase

Fix so that syspref description is populated after
a database updated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAllow the reserve date to be set on holds - sysprefs
Michael Hafen [Mon, 10 Aug 2009 23:17:29 +0000 (17:17 -0600)]
Allow the reserve date to be set on holds - sysprefs

This is the two system preferences controlling this feature, and the
updatedatabase addition using db verion 3.01.00.040

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAllow the reserve date to be set on holds
Michael Hafen [Tue, 11 Aug 2009 15:03:22 +0000 (09:03 -0600)]
Allow the reserve date to be set on holds

This adds to the interface and code the ability to set the reserve date when
requesting a hold.

Resubmit.  Sorry, I formatted it from the wrong branch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3522 Refactor Create Update Delete letter for consistency and readability
Colin Campbell [Tue, 11 Aug 2009 16:43:02 +0000 (17:43 +0100)]
Bug 3522 Refactor Create Update Delete letter for consistency and readability

Fixed inconsistent usuage of primary key in delete
Refactored:
Moved operations to separate subroutines to clarify data flow
Removed unnecessary redirects to self
Renamed confusingly named else variable passed to template
Other changes for code clarity
NB Outstanding:
database reading/writing should live in appropriate module
not duplicate it here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3520: fix crash when adding or editing items
Galen Charlton [Tue, 11 Aug 2009 14:46:20 +0000 (10:46 -0400)]
bug 3520: fix crash when adding or editing items

Fix the following crash when adding or editing an
item record in the staff interface:

Can't call method "append_fields" on an undefined value at
/usr/local/share/perl/5.10.0/MARC/File/SAX.pm line 92.
 at /usr/local/share/perl/5.10.0/MARC/File/SAX.pm line 92

This crash appears only if a version of MARC::File::XML
greater than 0.88 is installed, and was triggered by
C4::Biblio::TransformHtmlToXml() failing to create a valid
MARCXML blob, which must include a <record> element.

This patch also fixes the indicator values generated by
TransformHtmlToXml(), setting them to " " instead of
"" when no indicator value is supplied.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 2157: add ability to 'clean' staged record batches
Galen Charlton [Mon, 10 Aug 2009 04:18:08 +0000 (00:18 -0400)]
bug 2157: add ability to 'clean' staged record batches

batches, it is now possible to 'clean' a batch by
removing all bib and item records staged in the batch.  This
has the effect of helping to reduce database space used
by old import batches as well as removing staged records
from the cataloging reservoir search.  Note that 'cleaning'
a batch affects only the copies of the records that were staged;
if the batch was committed, cleaning the batch does not
affect any bibs and items that were committed into the catalog.

Also note that once you clean a committed batch of records, it is
impossible to undo the previous commit operation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 2505: enable warnings in tools/manage-marc-import.pl
Galen Charlton [Mon, 10 Aug 2009 04:18:07 +0000 (00:18 -0400)]
bug 2505: enable warnings in tools/manage-marc-import.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobugfix opac-user stomps mylibraryfirst value in quick search label
Michael Hafen [Mon, 10 Aug 2009 17:24:05 +0000 (11:24 -0600)]
bugfix opac-user stomps mylibraryfirst value in quick search label

the system preference mylibraryfirst is exported by Auth containing the logged
in users branchcode.  It is also exported as the value of the syspref by
opac-user.pl.  The effect is that when mylibraryfirst is on and the user
logged in the text label for the OPAC quick search instead of displaying
'Search (in [branchcode] only)' shows 'Search (in 1 only)'.  Other user pages
are uneffected.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoShowing "more searches" menu options when JavaScript is disabled (Bug 3517)
Owen Leonard [Mon, 10 Aug 2009 18:54:48 +0000 (13:54 -0500)]
Showing "more searches" menu options when JavaScript is disabled (Bug 3517)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAdding the koha-commits list to the history
Chris Cormack [Mon, 10 Aug 2009 10:25:15 +0000 (22:25 +1200)]
Adding the koha-commits list to the history

15 years agoReverse Payment - Allows any payment to be 'undone' while retaining a record of said...
Kyle M Hall [Wed, 29 Jul 2009 17:27:11 +0000 (17:27 +0000)]
Reverse Payment - Allows any payment to be 'undone' while retaining a record of said payment. Useful for accidental double-payments.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3292: Fix to display Branch names instead of branch codes in opac serial's displays.
Garry Collum [Sun, 9 Aug 2009 20:28:08 +0000 (16:28 -0400)]
Bug 3292: Fix to display Branch names instead of branch codes in opac serial's displays.

Fixes display of branch name in opac-full-serial-issues.tmpl and opac-serial-issues.tmpl.  Also enables zebra striping in opac-serial-issues.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>