]> git.koha-community.org Git - koha.git/log
koha.git
16 years ago(bugfix, CRI) Permission needed is acquisition, not acquisitionS
Paul POULAIN [Tue, 13 May 2008 08:19:20 +0000 (10:19 +0200)]
(bugfix, CRI) Permission needed is acquisition, not acquisitionS

+ i've added 'intranet' to reach intranet error page, not OPAC one (which is the default when no type specified)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2017: ensure MARC21 $9 are in correct bib editor tab
Galen Charlton [Mon, 12 May 2008 21:59:35 +0000 (16:59 -0500)]
kohabug 2017: ensure MARC21 $9 are in correct bib editor tab

Update MARC21 bib framework to ensure that subfield $9 in  110,
110, 111, 130, 240, 243, 440, 410, 411, and 440 remain
in same bib editing tab as rest of subfields in those fields.

This helps ensure that authority-controlled fields are not
mangled when editing a bib record.

Change also fixes editing tab for subfields in the 037, 584, and
760.

This is DB rev 085.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding RenewalAddsSuggestion systempreference to sql files.
Henri-Damien LAURENT [Mon, 12 May 2008 21:59:34 +0000 (16:59 -0500)]
Adding RenewalAddsSuggestion systempreference to sql files.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMARC21 frameworks: keep a tag's subfields in the same tab
Galen Charlton [Mon, 12 May 2008 21:59:31 +0000 (16:59 -0500)]
MARC21 frameworks: keep a tag's subfields in the same tab

Changed default mandatory and optional MARC21 frameworks
to ensure that all the subfields of 037, 100, 110, 111, 130,
240, 243, 400, 410, 411, 440, 584, and 760 are all either
ignored (tab = -1) or assigned to the same editing tab.

Most of these changes involve the subfield $9 in authority-controlled
fields, which for the affected 1xx, 2xx, and 4xx fields was assigned
to tab 6, not 1, 2, or 4.  Because of this, any such field with a
$9 was effectively split, leading to record corruption.

This is part of the fix for bug 2017.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed typo in MARC framework test: "Codek" => "Code"
Galen Charlton [Mon, 12 May 2008 21:59:30 +0000 (16:59 -0500)]
fixed typo in MARC framework test: "Codek" => "Code"

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMARC framework test - tests all frameworks
Galen Charlton [Mon, 12 May 2008 21:59:29 +0000 (16:59 -0500)]
MARC framework test - tests all frameworks

Changed some of the tests so that all frameworks
are tested, not just the first row.

This patch has turned up a reported error in the
unimarc_lecture_pub - items.homebranch
and items.holdinbranch for the WEB framework are
in tab -1 (i.e., ignored), but the check is expecting
them in tab 10.  Not sure if this is a real error or not:
perhaps no items should be created for bibs in that framework;
on the other hand, it is still possible to do so, in which
case the branches need to be set.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIncrementing to 084 -- adding GoogleJackets syspref
Joshua Ferraro [Tue, 13 May 2008 21:56:23 +0000 (16:56 -0500)]
Incrementing to 084 -- adding GoogleJackets syspref

16 years agoAdding RenewalAddsSuggestion systempreference to sql files.
Henri-Damien LAURENT [Mon, 12 May 2008 20:48:15 +0000 (22:48 +0200)]
Adding RenewalAddsSuggestion systempreference to sql files.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding Optionnal suggestion creation when renewing subscription.
Henri-Damien LAURENT [Mon, 12 May 2008 20:48:14 +0000 (22:48 +0200)]
Adding Optionnal suggestion creation when renewing subscription.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIncrement DB update 083
Joshua Ferraro [Mon, 12 May 2008 20:50:26 +0000 (15:50 -0500)]
Increment DB update 083

16 years agoyuipath : sysprefs changes only 2a/2
Henri-Damien LAURENT [Mon, 12 May 2008 20:33:48 +0000 (22:33 +0200)]
yuipath : sysprefs changes only 2a/2

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agochange in yuipath management 1/2 Noupdatedatabase.pl
Henri-Damien LAURENT [Mon, 12 May 2008 20:27:49 +0000 (22:27 +0200)]
change in yuipath management 1/2 Noupdatedatabase.pl

now yuipath is added in C4::Output and uses themelang
In my opinion, all the general variables that are used in output should get in C4::Output (since there is theme lang computed.)
rather than in C4::Auth

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1953: fixing potential SQL injection problems in C4::Branch::GetBranches
Andrew Moore [Mon, 12 May 2008 19:34:44 +0000 (14:34 -0500)]
bug 1953: fixing potential SQL injection problems in C4::Branch::GetBranches

I moved C4::Branch::GetBranches to use bind parameters and wrote some tests to demonstrate functionality.

No functional or documentation changes here.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed potential SQL error in fr-FR sample itemtypes
Galen Charlton [Mon, 12 May 2008 16:41:59 +0000 (11:41 -0500)]
fixed potential SQL error in fr-FR sample itemtypes

There is nothing to prevent a user from loading the
sample itemtypes from both 3-LecturePub and 4-Conservation.

To avoid an SQL error (and to let the installer tests
pass), made two of the SQL inserts "INSERT IGNORE" for
sample item types that have the same key.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed SQL error in sample labels scripts
Galen Charlton [Mon, 12 May 2008 16:41:58 +0000 (11:41 -0500)]
fixed SQL error in sample labels scripts

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix SQL error in unimarc_lecture_pub fr-FR MARC framework
Galen Charlton [Mon, 12 May 2008 16:41:57 +0000 (11:41 -0500)]
fix SQL error in unimarc_lecture_pub fr-FR MARC framework

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed installer test
Galen Charlton [Mon, 12 May 2008 16:41:56 +0000 (11:41 -0500)]
fixed installer test

Now handles cases where two SQL scripts in different
directories have the same name, e.g., fr-FR sample_itemtypes.sql.
Bug was masked by existing failure when attempting to load
both sample_itemtypes.sql.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug Fixing 2081
Henri-Damien LAURENT [Tue, 6 May 2008 15:27:32 +0000 (17:27 +0200)]
bug Fixing 2081

Editing authorisedvalue now checks if OTHER value has the same authorised_value
before storing
id is now passed to the form so that it is used when editing authorised_value
when imageurl it is passed as '' not empty parameter

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofrench translation updated
Paul POULAIN [Mon, 12 May 2008 12:56:51 +0000 (14:56 +0200)]
french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfix : librarian name was libxxx, not lib.xxx
Paul POULAIN [Mon, 12 May 2008 12:56:50 +0000 (14:56 +0200)]
bugfix : librarian name was libxxx, not lib.xxx

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfix : ship utf-8 encoding in mail header
Paul POULAIN [Mon, 12 May 2008 12:56:49 +0000 (14:56 +0200)]
bugfix : ship utf-8 encoding in mail header

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years ago(bugfix) focusing on barcode for returns
Paul POULAIN [Mon, 12 May 2008 12:56:48 +0000 (14:56 +0200)]
(bugfix) focusing on barcode for returns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoHiding empty results table when there are no results (prevents js error from tablesor...
Owen Leonard [Mon, 12 May 2008 12:58:27 +0000 (07:58 -0500)]
Hiding empty results table when there are no results (prevents js error from tablesorter). Now links back to search form. Also includes minor CSS tweak for IE/Opera general layout problems.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding check all/none controls to opac suggestions, following opac shelves interface.
Owen Leonard [Mon, 12 May 2008 12:58:10 +0000 (07:58 -0500)]
Adding check all/none controls to opac suggestions, following opac shelves interface.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding checks for dateformat preference so that tablesorter script can be passed...
Owen Leonard [Mon, 12 May 2008 12:58:00 +0000 (07:58 -0500)]
Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug Fixing : overduenotices wrote a file on disk before sending to browser
Henri-Damien LAURENT [Wed, 7 May 2008 14:32:49 +0000 (16:32 +0200)]
Bug Fixing : overduenotices wrote a file on disk before sending to browser

this script had quite serious issues :
- it would not use mindays and maxdays variables
- It would send latin1 where utf8 was expected
- It would send data without text delimiters (; was chosen if title contains ; it would have been a problem " used as delimiters now)
- It would write a file when it was not asked
Now stores the results in a string before printing it.
New option added to store result into a file : -o filename

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug fixing on overdues.tmpl : branchnames were not displayed
Henri-Damien LAURENT [Wed, 7 May 2008 09:19:24 +0000 (11:19 +0200)]
Bug fixing on overdues.tmpl : branchnames were not displayed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoclose security holes in patron search autocompletion
Galen Charlton [Mon, 12 May 2008 15:01:10 +0000 (10:01 -0500)]
close security holes in patron search autocompletion

* Added authorization check - user must have a valid
  session cookie to use this feature; before this change,
  anybody could use circ/ysearch.pl to retrieve the entire
  patron directory without authorization.
* (bug 1953) now uses SQL placeholders

Note: this does, unfortunately, noticeably slow down automcompletion;
this indicates a need for factoring of C4::Auth to make authentication
for AJAX scripts as fast as possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug Fixing 1782 patch
Henri-Damien LAURENT [Mon, 12 May 2008 14:29:45 +0000 (16:29 +0200)]
Bug Fixing 1782 patch

Adding a new routine GetBorrowercategoryList in C4/Member
Displaying categoryname when listing categories in memberentrygen.pl
using categorytype returned with GetMember wherever it is possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIncrementing DB revision 081
Joshua Ferraro [Mon, 12 May 2008 14:36:13 +0000 (09:36 -0500)]
Incrementing DB revision 081

16 years agoDB Update 77 : add lastincrement column to accountlines
Ryan Higgins [Mon, 12 May 2008 10:29:37 +0000 (05:29 -0500)]
DB Update 77 : add lastincrement column to accountlines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix error on lastincrement.
Ryan Higgins [Mon, 12 May 2008 10:41:25 +0000 (05:41 -0500)]
fix error on lastincrement.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Circulation::FixOverduesOnReturn now handles dropbox mode.
Ryan Higgins [Mon, 12 May 2008 10:29:38 +0000 (05:29 -0500)]
C4::Circulation::FixOverduesOnReturn now handles dropbox mode.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMake dropbox mode obey Calendar module according to CircControl branch.
Ryan Higgins [Mon, 12 May 2008 10:29:36 +0000 (05:29 -0500)]
Make dropbox mode obey Calendar module according to CircControl branch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAlter Overdues::CalcFine to use Dates objects.
Ryan Higgins [Mon, 12 May 2008 10:29:35 +0000 (05:29 -0500)]
Alter Overdues::CalcFine to use Dates objects.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoshow correct effective checkin date in dropbox mode.
Ryan Higgins [Mon, 12 May 2008 10:29:34 +0000 (05:29 -0500)]
show correct effective checkin date in dropbox mode.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadjust dropboxdate to allow for holidays calendar.
Ryan Higgins [Mon, 12 May 2008 10:29:33 +0000 (05:29 -0500)]
adjust dropboxdate to allow for holidays calendar.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Calendar::addDate now handles negative offsets properly.
Ryan Higgins [Mon, 12 May 2008 10:29:32 +0000 (05:29 -0500)]
C4::Calendar::addDate now handles negative offsets properly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAlter C4::Calendar::daysBetween() to take C4::Dates objects.
Ryan Higgins [Mon, 12 May 2008 10:29:31 +0000 (05:29 -0500)]
Alter C4::Calendar::daysBetween() to take C4::Dates objects.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUGFIX (bloquing) moredetail & item edition
Paul POULAIN [Wed, 7 May 2008 17:15:53 +0000 (19:15 +0200)]
BUGFIX (bloquing) moredetail & item edition

this patch introduce the same behaviour as for additem.pl, ie : edit only own homebranch items, except for superlibrarians

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUGFIX : script to fix & fill onloan field in items table.
Paul POULAIN [Wed, 7 May 2008 17:15:52 +0000 (19:15 +0200)]
BUGFIX : script to fix & fill onloan field in items table.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadjusted new C4::Scrubber test cases
Galen Charlton [Mon, 12 May 2008 14:18:04 +0000 (09:18 -0500)]
adjusted new C4::Scrubber test cases

Removed reference to override_context_prefs that
Andrew Moore had just factored out.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agopatron attributes - batch import
Galen Charlton [Mon, 12 May 2008 13:32:57 +0000 (08:32 -0500)]
patron attributes - batch import

When ExtendedPatronAttributes is ON, the batch
patron import tool's behavior changes as follows:

[1] A new (required) column is added to the input CSV
    format.  This column should contain a list of
    attributes to set for the record, each value
    preceded by its type code.  For example, if
    the superlibrarian has defined two types,
    a unique identifier INSTID and a repeatable
    BASEBALL, this field could contain:

    "INSTID:12345,BASEBALL:Cubs"

    This field must be wrapped in quotes if multiple
    values are defined.  Since values can contain
    spaces, additional doubled-quotes may be required:

    "INSTID:12345,BASEBALL:Cubs,""BASEBALL:White Sox"""

    When replacing a patron record, any attributes specified
    in the input file replace all of the attribute values
    of any type that were previously assigned to the patron
    record.

[2] It is possible to specify a field other than the
    cardnumber to use for looking for matching patrons.
    Specifically, any attribute marked as a unique ID
    can be used.  The operator is asked to specify
    which ID type to use; if an input record has an
    attribute value of that type, and exactly one patron
    record in the database has that value, then the
    record will be overlaid or ignored according to the
    overlay setting.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agopatron attributes - staff search and display
Galen Charlton [Mon, 12 May 2008 13:32:56 +0000 (08:32 -0500)]
patron attributes - staff search and display

If ExtendedPatronAttributes is ON, patron attributes
can be displayed and edited by staff members.

The patron attributes are displayed and edited
in a new section (step 4) of the patron details page.  Each
attribute is identified by its type (including type code
and type description) and value (included value description
if the attribute is controlled by an authorised value category).

Note: if, for a repeatable attribute type, the staff member
enters multiple copies of that type with the same value, duplicates
are removed when the patron record is saved.  Also, if the type
is repeatable, a JavaScript link allows the staff member to
create new attributes of that type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agotemplate changes for OPAC display of patron attributes
Galen Charlton [Mon, 12 May 2008 13:32:55 +0000 (08:32 -0500)]
template changes for OPAC display of patron attributes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agopatron attributes - OPAC display
Galen Charlton [Mon, 12 May 2008 13:32:54 +0000 (08:32 -0500)]
patron attributes - OPAC display

If ExtendedPatronAttributes is ON, any patron attributes
whose type is marked as displayble in the OPAC are now
displayed in the 'my details' page in the OPAC (assuming
that the patron is logged in).  These appear in the
'Library Use' section.

Currently, it is not possible for a patron to suggest
changes to any of their extended attributes using
opac-userupdate.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agocorrected base class of a test
Galen Charlton [Mon, 12 May 2008 13:32:53 +0000 (08:32 -0500)]
corrected base class of a test

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Members::SearchMember - support attributes
Galen Charlton [Mon, 12 May 2008 13:32:52 +0000 (08:32 -0500)]
C4::Members::SearchMember - support attributes

Modified SearchMember() so that if the patron attributes
feature is on (i.e., ExtendedPatronAttributes is ON), it
is possible to search for patrons on any attributes whose
type is set as staff searchable.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agonew editor for patron attribute types
Galen Charlton [Mon, 12 May 2008 13:32:51 +0000 (08:32 -0500)]
new editor for patron attribute types

Added new script under the Administration menu
to create, update, and delete patron attribute types.

Some things to note:

- once an attribute is created, its code cannot be changed
- the repeatibility and unique_id settings of an
  attribute type cannot be changed after creation -
  this is to avoid having to deal with changing
  constraints if an attribute type is already in use
  by patron records
- an attribute type cannot be deleted if it is
  used by any patron records
- this administration page is always displayed regardless
  of the value of the ExtendedPatronAttributes syspref.  If
  the syspref is off, the page will prompt the superlibrarian
  to turn it on if desired.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Koha - added GetAuthorisedValueCategories
Galen Charlton [Mon, 12 May 2008 13:32:50 +0000 (08:32 -0500)]
C4::Koha - added GetAuthorisedValueCategories

New convenience function to get list of authorised
value categories.

No user-visible changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agonew C4 modules for patron attributes
Galen Charlton [Mon, 12 May 2008 13:32:49 +0000 (08:32 -0500)]
new C4 modules for patron attributes

Two new modules to support patron attributes:

- C4::Members::AttributeTypes

  OO-module for managing patron attribute types.

- C4::Members::Attributes

  Procedural module for retrieving and setting
  extended attributes belonging to a patron.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoextended patron attributes tables & syspref (DB rev 081)
Galen Charlton [Mon, 12 May 2008 13:32:48 +0000 (08:32 -0500)]
extended patron attributes tables & syspref (DB rev 081)

Added two tables and system preference to support
a new patron alternate ID and attributes feature.

A patron attribute (or extended patron attribute) is an
additional piece of information associated with a patron
record.  Each attribute has a type that specifies
whether the attribute is repeatable, can serve as
a unique identifier, can take a password, and
whether it can be used to search for patron records
in the staff interface.

The list of attribute types is controlled by the
superlibrarian.  Once an attribute type is defined,
values for that attribute can be added to the patron record
via the staff interface or the batch patron import.

Two uses of extended attributes are:

- defining additional unique identifiers, such as
  a campus student ID number, a library staff
  HR number, and so on.  These IDs can be used
  for searching or matching and overlaying records
  during a batch import.
- additional statistical categories.  For example,
  a library could define an attribute type for
  tracking the academic major of a student patron.
  Any number of attributes of this sort could be
  defined.

The extended attributes feature is completely optional.  If
the new syspref, ExtendPatronAttributes, is OFF, the patron
attributes tables will be ignored; it will not be possible
to display, edit, search for, or match on extended
attributes.

The tables are:

[1] borrower_attribute_types - store attribute types
    defined by the administrator.

    - code
    - description
    - repeatable (whether a patron record can have
      more than value of a given attribute type)
    - unique_id (whether values of this type
      must be unique within the database)
    - opac_display (whether values of this type
      can display in the patron details page in the OPAC)
    - staff_searchable (whether values of this type
      can be used to retrieve patron records in circulation)
    - password_allowed (if set, staff patron editor will
      allow a password to be associated with a value; this
      is mostly a hook for functionality to be implemented
      in the future.
    - authorised_value_category (code of an authorised_value
      category.  If one is specified, the staff patron
      editor will use a dropdown for setting values of this type)
[2] borrower_attributes - the actual attributes.
    - code (attribute type code, FK)
    - borrowernumber (link to patron, FK)
    - attribute (the value)
    - password (password associated with value)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076: more reconciliation of DB schema (DB rev 080)
Galen Charlton [Mon, 12 May 2008 13:32:47 +0000 (08:32 -0500)]
kohabug 2076: more reconciliation of DB schema (DB rev 080)

Adjustments to updatedatabase.pl to help ensure that a
DB upgraded from 2.2.9, 3.0-alpha, or 3.0-beta has a schema
identical to a fresh installation.

The changes to the following columns and indexes are to
default values, field widths, position relative to other
columns or index names.

virtualshelfcontents.biblionumber
virtualshelfcontents_ibfk_1 (virtualshelfcontents)
shelfcontents_ibfk_2 (virtualshelfcontents)
sessions.id
deletedbiblioitems.marc
branchcategories.categorycode
branchrelations.categorycode
items.damaged
deleteditems.notforloan
deleteditems.damaged
deleteditems.itemlost
deleteditems.wthdrawn
currency.symbol
subscription.numberlength
subscription.weeklength
serialidx (serialitems)
items.more_subfields_xml
z3950servers.type
deleteditems.more_subfields_xml
opac_news.lang
labels_conf.formatstring

The following missing columns were added:

deletedbiblioitems.marcxml
deleteditems.itype

The 080 DB rev is specifically for syncing the schema
for users of 3.0-alpha, 3.0-beta, and 3.0-beta2, and should
be a no-op for anybody who has followed git HEAD for
the past few months:

subscription.monthlength
deleteditems.marc
aqbooksellers.name

NOTE: this patch does not handle the case of syncing
the DB of a developer or user who has been following
git HEAD since before 3.0-alpha.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAlter itemBarcodeInputFilter T-Prefix.
Ryan Higgins [Sat, 10 May 2008 19:03:48 +0000 (14:03 -0500)]
Alter itemBarcodeInputFilter T-Prefix.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoonly pass needsconfirmation to template if issuing is possible
Ryan HIggins [Sat, 10 May 2008 18:19:15 +0000 (13:19 -0500)]
only pass needsconfirmation to template if issuing is possible

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFinishing adding additional markup for increased flexibility in stylesheet customizat...
Owen Leonard [Sat, 10 May 2008 15:18:02 +0000 (10:18 -0500)]
Finishing adding additional markup for increased flexibility in stylesheet customization. Patch also includes some markup corrections, but shouldn't result in any visual changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoChanges to enable more flexibility in template customization. Container divs allow...
Owen Leonard [Sat, 10 May 2008 15:17:54 +0000 (10:17 -0500)]
Changes to enable more flexibility in template customization. Container divs allow for graphical deliniation of logical screen areas.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agotest suite: new tests for installer
Galen Charlton [Fri, 9 May 2008 23:08:13 +0000 (18:08 -0500)]
test suite: new tests for installer

Added tests of loading the DB initialization and
sampple data SQL scripts for every language
and MARC flavour combination defined in
installer/data/{dbms}.  Errors that the
new test class should catch include:

* SQL syntax errors in kohastructure.sql
* SQL errors in the sample data

For each language and MARC flavour combination,
all mandatory and optional scripts are loaded.

As of this commit, several errors are reported
by this test class; these will be fixed separately.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agotest suite refactoring
Galen Charlton [Fri, 9 May 2008 23:08:12 +0000 (18:08 -0500)]
test suite refactoring

Moved routines to clear and create database and manage
zebraqueue_daemon.pl to KohaTest.pm so that they're
available to test classes - needed for installation
and upgrade tests in particular.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Installer - new method to get available MARC frameworks
Galen Charlton [Fri, 9 May 2008 23:08:11 +0000 (18:08 -0500)]
C4::Installer - new method to get available MARC frameworks

For use by test suite; not a user-visible change.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2094: fixing two bugs in lost items report
Andrew Moore [Fri, 9 May 2008 20:06:26 +0000 (15:06 -0500)]
Bug 2094: fixing two bugs in lost items report

* I guess the limit by item type was never working. I made it look for the right database column
* I fixed the error that was returned with no items were returned.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2094: cleanup of lost items report
Andrew Moore [Fri, 9 May 2008 19:03:28 +0000 (14:03 -0500)]
Bug 2094: cleanup of lost items report

Just some code cleanup of C4::Items::GetLostItems and reports/itemslist.pl.
Some whitespace changes, perltidy, and documentation improvements.
Also, I rewrote and SQL statement to try to reduce possibilities of SQL injection attacks.

No documentation or functional changes necessary with this patch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2094: implementing ability to select particular lost status in the lost items...
Andrew Moore [Fri, 9 May 2008 19:03:27 +0000 (14:03 -0500)]
Bug 2094: implementing ability to select particular lost status in the lost items report

This patch adds a drop-down to the lost items report to let the user select a
particular lost status to display. Only items with that particluar lost status
will be dispolayed.

The documentation for the lost items report on the staff client will need to be slightly adjusted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2047: another fix for error during search when there is no MARC::Record
Andrew Moore [Fri, 9 May 2008 17:28:56 +0000 (12:28 -0500)]
Bug 2047: another fix for error during search when there is no MARC::Record

This is another fix for a bug that was introduced while adding this feature.
I believe that either this patch or the one at:
http://lists.koha.org/pipermail/koha-patches/2008-May/000309.html
should be applied.

In the case that GetMarcBiblio or GetMarcStructure does not return a true value,
this returns without further processing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2088: test suite refactoring to deal with t/override_context_prefs.pm
Andrew Moore [Thu, 8 May 2008 13:10:37 +0000 (08:10 -0500)]
bug 2088: test suite refactoring to deal with t/override_context_prefs.pm

Some minor changes to get the test suite working a bit better:
I removed a superfluous method from t/lib/KohaTest.pm.
I made each barcode for the items added in KohaTest.pm unique so that they would actually get inserted.

Then, I removed t/override_context_prefs.pm. If you need that functionality, you're a database
dependent test and should be a module in t/lib.
So, I deleted all of the trivial .t tests that just 'use'd their modules and had no other
tests and replaced them with lib/KohaTest/*pm modules that do a little bit more checking
on those modules.
I removed the references to override_context_prefs.pm in all of the other .t modules.
They all pass now with no override_context_prefs.pm module.

The database_depenedent.pl test script still does not pass entirely. There's a problem with the zebra index
not being reset each time that the tables are truncated. I'll get to that.

no functional or documentation changes here.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTweaking display of "action" links in search results
Owen Leonard [Thu, 8 May 2008 10:12:35 +0000 (05:12 -0500)]
Tweaking display of "action" links in search results

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing a couple of bugs, including Bug 2080, OPAC Lists : No way to remove biblios...
Owen Leonard [Thu, 8 May 2008 10:12:26 +0000 (05:12 -0500)]
Fixing a couple of bugs, including Bug 2080, OPAC Lists : No way to remove biblios from list.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for Bug 2086, Filter Button Misleading. This moves the filter form into the left...
Owen Leonard [Thu, 8 May 2008 10:12:18 +0000 (05:12 -0500)]
Fix for Bug 2086, Filter Button Misleading. This moves the filter form into the left-hand sidebar.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding RSS icon to search results (Fix for Bug 2078, RSS Icon on OPAC)
Owen Leonard [Thu, 8 May 2008 10:12:09 +0000 (05:12 -0500)]
Adding RSS icon to search results (Fix for Bug 2078, RSS Icon on OPAC)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemoving table sorting pending change to this page to allow paged display
Owen Leonard [Thu, 8 May 2008 10:11:58 +0000 (05:11 -0500)]
Removing table sorting pending change to this page to allow paged display

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoWrapper for Koha's use of HTML::Scrubber, with test script on usage.
Joe Atzberger [Thu, 8 May 2008 06:06:44 +0000 (01:06 -0500)]
Wrapper for Koha's use of HTML::Scrubber, with test script on usage.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2083: requiring that the test database have a different name from the production...
Andrew Moore [Wed, 7 May 2008 20:23:25 +0000 (15:23 -0500)]
bug 2083: requiring that the test database have a different name from the production database

This patch requires that the test database name be different from the production database name.
The object here is to prevent people from specifying the same database for both, and then
losing all of their data in the production database.

This may cause problems for people who want to do that, though I consider that bad practice.
It may also cause problems for people if they have two different servers, each with identically
named database, and they want to use one for testing and the other for production. If we ever
find that someone like that exists, we can deal with that case.

I don't think there are any necessary documentation changes here yet since we're recommending
that users answer "no" to the question about setting up a test database.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoguided reports: make it possible to delete saved reports
Galen Charlton [Wed, 7 May 2008 19:38:43 +0000 (14:38 -0500)]
guided reports: make it possible to delete saved reports

Fixed JavaScript error that prevented user from deleting
a saved SQL.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2087: test cases for misc/cronjobs/longoverdue.pl
Andrew Moore [Wed, 7 May 2008 18:50:37 +0000 (13:50 -0500)]
bug 2087: test cases for misc/cronjobs/longoverdue.pl

I'm adding some functional tests that demonstrate that long_overdue.pl does what we think it does.
These tests don't actually work since override_context_prefs.pm gets in the way of C4::Context::preference. I opened up bug 2088 to address that.

There are no functional or documentation changes due to this patch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076: more reconciliation of DB schema (DB rev 080)
Galen Charlton [Mon, 5 May 2008 15:04:26 +0000 (10:04 -0500)]
kohabug 2076: more reconciliation of DB schema (DB rev 080)

Adjustments to updatedatabase.pl to help ensure that a
DB upgraded from 2.2.9, 3.0-alpha, or 3.0-beta has a schema
identical to a fresh installation.

The changes to the following columns and indexes are to
default values, field widths, position relative to other
columns or index names.

virtualshelfcontents.biblionumber
virtualshelfcontents_ibfk_1 (virtualshelfcontents)
shelfcontents_ibfk_2 (virtualshelfcontents)
sessions.id
deletedbiblioitems.marc
branchcategories.categorycode
branchrelations.categorycode
items.damaged
deleteditems.notforloan
deleteditems.damaged
deleteditems.itemlost
deleteditems.wthdrawn
currency.symbol
subscription.numberlength
subscription.weeklength
serialidx (serialitems)
items.more_subfields_xml
z3950servers.type
deleteditems.more_subfields_xml
opac_news.lang
labels_conf.formatstring

The following missing columns were added:

deletedbiblioitems.marcxml
deleteditems.itype

The 080 DB rev is specifically for syncing the schema
for users of 3.0-alpha, 3.0-beta, and 3.0-beta2, and should
be a no-op for anybody who has followed git HEAD for
the past few months:

subscription.monthlength
deleteditems.marc
aqbooksellers.name

NOTE: this patch does not handle the case of syncing
the DB of a developer or user who has been following
git HEAD since before 3.0-alpha.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAddressing bug 1782
Henri-Damien LAURENT [Wed, 7 May 2008 09:04:14 +0000 (11:04 +0200)]
Addressing bug 1782

Adding New Systempreference AddPatronLists
This systempreference allow administrator to choose if patrons are created on categorycode lists or category_type ones.

Overloading GetBorrowerCategory so that if no parameter provided, it returns the list of category records
Changing memberentry.pl in order to use the categorycode when provided.
Bug Fixing Circulation.pl so that doesnot come up with Error 500
with no category selected for GetBorrowerCategory

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076: add DB schema creation scripts from past versions
Galen Charlton [Mon, 5 May 2008 15:04:29 +0000 (10:04 -0500)]
kohabug 2076: add DB schema creation scripts from past versions

For test cases to be written soon, added kohastructure.sql (or equivalent)
from the following versions:

2.2.9
3.0-alpha
3.0-beta (note that schema for 3.0-beta2 is the same)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076: updated 2.2 -> 3.0 upgrade
Galen Charlton [Mon, 5 May 2008 15:04:28 +0000 (10:04 -0500)]
kohabug 2076: updated 2.2 -> 3.0 upgrade

Numerous changes to update22to30.pl to help ensure
that a database upgraded from 2.2.9 to 3.0 will have
a DB schema identical to that of a new installation.

These changes were testing by starting from an empty database,
loading koha.mysql from the 2.2.9 package, then running

update22to30.pl
move_marc_to_authheader.pl
move_marc_to_biblioitems.pl
dropping the following tables:
  marc_subfield_table
  auth_subfield_table
  marc_biblio
  marc_blob_subfield
  auth_word
  biblioanalysis
  borexp
  catalogueentry
  charges
  itemsprices
  marc_word
  marcrecorddone
  sessionqueries
  uploadedmarc
  users
  websites
  z3950queue
  z3950results
updatedatabase.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076: more reconciliation of kohastructure.sql
Galen Charlton [Mon, 5 May 2008 15:04:27 +0000 (10:04 -0500)]
kohabug 2076: more reconciliation of kohastructure.sql

Changes to kohastructure.sql to sync with changes
made via updatedatabase.pl:

aqbooksellers.name (DB rev 042)
subscription.serialsadditems (DB rev 071)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076: more reconciliation of DB schema (DB rev 080)
Galen Charlton [Mon, 5 May 2008 15:04:26 +0000 (10:04 -0500)]
kohabug 2076: more reconciliation of DB schema (DB rev 080)

Adjustments to updatedatabase.pl to help ensure that a
DB upgraded from 2.2.9, 3.0-alpha, or 3.0-beta has a schema
identical to a fresh installation.

The changes to the following columns and indexes are to
default values, field widths, position relative to other
columns or index names.

virtualshelfcontents.biblionumber
virtualshelfcontents_ibfk_1 (virtualshelfcontents)
shelfcontents_ibfk_2 (virtualshelfcontents)
sessions.id
deletedbiblioitems.marc
branchcategories.categorycode
branchrelations.categorycode
items.damaged
deleteditems.notforloan
deleteditems.damaged
deleteditems.itemlost
deleteditems.wthdrawn
currency.symbol
subscription.numberlength
subscription.weeklength
serialidx (serialitems)
items.more_subfields_xml
z3950servers.type
deleteditems.more_subfields_xml
opac_news.lang
labels_conf.formatstring

The following missing columns were added:

deletedbiblioitems.marcxml
deleteditems.itype

The 080 DB rev is specifically for syncing the schema
for users of 3.0-alpha, 3.0-beta, and 3.0-beta2, and should
be a no-op for anybody who has followed git HEAD for
the past few months:

subscription.monthlength
deleteditems.marc
aqbooksellers.name

NOTE: this patch does not handle the case of syncing
the DB of a developer or user who has been following
git HEAD since before 3.0-alpha.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076 - make biblioitems.marc longblob during upgrade
Galen Charlton [Mon, 5 May 2008 15:04:25 +0000 (10:04 -0500)]
kohabug 2076 - make biblioitems.marc longblob during upgrade

Change to match 3.0 definition of that column.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing RSS <link>
NCE [Tue, 6 May 2008 11:30:17 +0000 (07:30 -0400)]
Fixing RSS <link>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemoving obsolete RSS <link> tags and the scripts
Joshua Ferraro [Tue, 6 May 2008 11:24:50 +0000 (06:24 -0500)]
Removing obsolete RSS <link> tags and the scripts

16 years agoTab fix
Owen Leonard [Fri, 2 May 2008 19:20:47 +0000 (14:20 -0500)]
Tab fix

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agosynch'ing opac display with staff for scanIndexes
Paul POULAIN [Fri, 2 May 2008 17:03:28 +0000 (19:03 +0200)]
synch'ing opac display with staff for scanIndexes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug fixing : loading page macles would not load existing values for macles
Henri-Damien LAURENT [Fri, 2 May 2008 17:03:27 +0000 (19:03 +0200)]
Bug fixing : loading page macles would not load existing values for macles

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding subfield filter to ISBD
Paul POULAIN [Fri, 2 May 2008 17:03:26 +0000 (19:03 +0200)]
Adding subfield filter to ISBD

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoDebugging Macles
Henri-Damien LAURENT [Fri, 2 May 2008 17:03:24 +0000 (19:03 +0200)]
Debugging Macles

say you want to edit 6 fields 630:
Provided you have those in your catalogue frameworks, you just selet 6 values and it puts values into that.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoordering by biblioitemnumber for best performance
Paul POULAIN [Fri, 2 May 2008 17:03:23 +0000 (19:03 +0200)]
ordering by biblioitemnumber for best performance

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoreserve at itemlevel was displayed only if item-level_itype
Paul POULAIN [Fri, 2 May 2008 17:03:22 +0000 (19:03 +0200)]
reserve at itemlevel was displayed only if item-level_itype

This patch just moves the checkbox out of the <tmpl_if item-level_itypes>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofrench translation (updated)
Paul POULAIN [Fri, 2 May 2008 17:03:21 +0000 (19:03 +0200)]
french translation (updated)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofrench translation updated
Paul POULAIN [Fri, 2 May 2008 17:03:20 +0000 (19:03 +0200)]
french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfix : html mistake
Paul POULAIN [Fri, 2 May 2008 17:03:19 +0000 (19:03 +0200)]
bugfix : html mistake

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIntranet callnumber search link simple fix
Darrell Ulm [Thu, 1 May 2008 16:37:51 +0000 (12:37 -0400)]
Intranet callnumber search link simple fix

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoLink to Intranet Similar Items Fixed (simple), pointed to OPAC
Darrell Ulm [Thu, 1 May 2008 14:42:19 +0000 (10:42 -0400)]
Link to Intranet Similar Items Fixed (simple), pointed to OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agomissing )
Paul POULAIN [Thu, 1 May 2008 15:24:32 +0000 (17:24 +0200)]
missing )

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUGFIX : bump to 056 was wrong when marcflavour = UNIMARC
Paul POULAIN [Thu, 1 May 2008 15:24:31 +0000 (17:24 +0200)]
BUGFIX : bump to 056 was wrong when marcflavour = UNIMARC

The 652 field don't exist in UNIMARC. So linking the new enumchron to a 952 field automatically should be done only for marc21

For UNIMARC, i map it to 995$v, which has been introduced in the last release of the "recommandation 995"
adding the 995$v as well for installer

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076 - add browser if necessary (DB rev 078)
Galen Charlton [Thu, 1 May 2008 17:17:06 +0000 (12:17 -0500)]
kohabug 2076 - add browser if necessary (DB rev 078)

Ensure that the browser table is added during an upgrade
from 2.2.9.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076 - add authorised_values.imageurl
Galen Charlton [Thu, 1 May 2008 16:52:30 +0000 (11:52 -0500)]
kohabug 2076 - add authorised_values.imageurl

The column was added in updatedatabase.pl rev 075
but not added to kohastructure.sql.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076 - remove three tables (DB rev 077)
Galen Charlton [Thu, 1 May 2008 16:41:33 +0000 (11:41 -0500)]
kohabug 2076 - remove three tables (DB rev 077)

Removed the categorytable, mediatypetable, and subcategorytable
tables.  These three tables appear to be from an incomplete
patch from pre-git that defined these tables to implement
additional search limits, and are not present in the 2.2.9
package.  In 3.0, these tables did nothing - the only code that
referred to them are incomplete admin editors that lack HTML
templates and are not referred to anywhere.

The updatedatabase.pl logic to remove these tables is conservative;
the tables are dropped only if they exist and are all empty.  Effectively,
this means that they'll be dropped if you've been running a fresh install
of 3.0 from git or the alphas or betas; if you've upgraded your database
from 2.2.9, these tables likely weren't in your database to begin with.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>