]> git.koha-community.org Git - koha.git/commit
Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP...
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 28 Jun 2019 18:07:39 +0000 (14:07 -0400)
committerJoy Nelson <joy@bywatersolutions.com>
Wed, 15 Jan 2020 00:02:18 +0000 (00:02 +0000)
commit5476e77021e8abd0c733780bb825938a7608ff76
treedef4101472771b335df8c7c4e3cbb1632c45f30a
parenta3ace8143a601f8f546f9384affbba55b77fa8b6
Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only

The system preference AllowItemsOnHoldCheckout only affects SIP based checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it matches AllowItemsOnHoldCheckoutSCO. We should also update the description as well.

As far as I know AllowItemsOnHoldCheckout has never affected anything except SIP traffic. That does not preclude the addition of another AllowItemsOnHoldCheckout syspref that would affect the staff interface, but that would be an enhancement and is outside the scope of this bug report.

Test Plan:
1) Test AllowItemsOnHoldCheckout via SIP
2) Apply this patch
3) Test AllowItemsOnHoldCheckoutSIP via SIP
4) Note there is no difference!
5) Note the syspref description has been update to mention SIP

Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
C4/Items.pm
C4/SIP/ILS/Transaction/Checkout.pm
C4/UsageStats.pm
Koha/Item.pm
installer/data/mysql/atomicupdate/bug_23233.perl [new file with mode: 0644]
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref