Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 28 Apr 2022 07:43:06 +0000 (09:43 +0200)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 6 May 2022 17:49:23 +0000 (13:49 -0400)
commit73a2e3558944effbdb4a19e6c8a331679d41fcf8
tree0338e64b780a14a6d802f598009850b6df7fb5ba
parent333b698d6264859d6cae3ab112cca6c4ce52c623
Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON

RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item

Test plan:
1 - Enable HoldsAutoFill
2 - Place a title level hold
3 - Check in an item and confirm hold
4 - Switch to another branch
5 - Checkin the item
Without this patch you got
Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577.
 at /kohadevbox/koha/C4/Reserves.pm line 1576
With this patch applied the operation succeeds

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
circ/returns.pl