Bug 33597: Fix deleting cookie for holdfor(club)
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 24 Apr 2023 10:35:26 +0000 (10:35 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 5 May 2023 12:13:30 +0000 (09:13 -0300)
commit7e5e311cb0c88b9223ce98d685668962edc7baee
treebd2c2f52cf45c5acd5613b185a62c1595065e1ac
parent95de1f3e92947f157dbbbf789d88beb48645648b
Bug 33597: Fix deleting cookie for holdfor(club)

Resolve:
Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it.

Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax.

Test plan:
Similar to previous patch. Check console on logout page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/js/pages/results.js
koha-tmpl/intranet-tmpl/prog/js/staff-global.js