]> git.koha-community.org Git - koha.git/commit
Bug 28516: Prevent failures if borrower_attribute_types.mandatory=1
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 4 Jun 2021 13:36:59 +0000 (15:36 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 9 Jul 2021 12:28:45 +0000 (08:28 -0400)
commit7fef05b641520c08dbc14361fc813b62e220bbdc
tree08d72664e104ea99ba91f964b2fff5be94020a8e
parent58e71739b0ba598c083cbf5ae0655d03274b87a6
Bug 28516: Prevent failures if borrower_attribute_types.mandatory=1

TestBuilder will generate an integer for the
Koha::Patron::Attribute::Type object, but if 1 is picked some tests are
failing randomly
At least t/db_dependent/Koha/Patrons.t and t/db_dependent/Koha/Patrons/Import.t
The expection "Missing mandatory extended attribute" is raised when the
patron is stored.

Test plan:
The following script should return 0 when the patch is applied:

"""
use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
my $x = $builder->build_object(
    {
        class => 'Koha::Patron::Attribute::Types',
    }
);
say $x->mandatory;
"""

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/lib/TestBuilder.pm