From 143b757cfe0eed322bcc220070b9e683e16cb793 Mon Sep 17 00:00:00 2001 From: Joe Atzberger Date: Fri, 19 Sep 2008 16:24:22 -0500 Subject: [PATCH] Unravelling links in masthead. Regularize logic and improve readability. Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF. This was due to unnecessary duplicative code for Adv. Search vs. other pages. Note: with this revision, the link to "Advanced Search" will display on all pages, even on the Advanced Search page itself. This is in fact desirable, rather than the set of links collapsing and changing position depending on page being viewed. If the old premise were to be followed (that Adv. Search link should not display on its own page), then the same interface sensibility should apply to ALL links in the masthead: i.e., Tag Cloud link should not display on its own page, same for Browse by Subject, Most Popular, etc. I would argue even this is undesirable. At most, give the links in moresearches some IDs and let each page unlink/restyle the "current" link with jquery. IMHO, masthead itself should not be engage in such trifling interface polishes. Signed-off-by: Galen Charlton --- .../opac-tmpl/prog/en/includes/masthead.inc | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc index 3d62280778..e46ac13fc6 100644 --- a/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc +++ b/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc @@ -67,14 +67,22 @@ Lists - - - - - + +
Your cart is empty.
-- 2.39.2