From 1ca96457b33861d9e96f8f395a3f1722a26e097b Mon Sep 17 00:00:00 2001
From: Paul Poulain <paul.poulain@biblibre.com>
Date: Mon, 9 Nov 2009 19:35:02 +0100
Subject: [PATCH] Displaying serial call-number on receive.

when the subscription has item creation, the callnumber is inside the item creation.
But when it doesn't have, the callnumber is not displayed, but is useful to be put on physical item.
This patch display the callnumber after the title
---
 .../prog/en/modules/serials/serials-edit.tmpl      |  4 ++--
 serials/serials-edit.pl                            | 14 +++++++++-----
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl
index a65284ae80..90bc9fa659 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl
@@ -154,7 +154,7 @@ function CloneSubfield(index){
 <!-- TMPL_INCLUDE NAME="header.inc" -->
 <!-- TMPL_INCLUDE NAME="serials-search.inc" -->
 
-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> &rsaquo;  Serial Edition <i><!-- TMPL_VAR name="bibliotitle" --></i></div>
+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> &rsaquo;  Serial Edition <i><!-- TMPL_VAR name="bibliotitle" --> <!-- TMPL_IF name="callnumber" -->(<!-- TMPL_VAR name="callnumber" -->)<!-- /TMPL_IF --></i></div>
 
 <div id="doc3" class="yui-t2">
    
@@ -162,7 +162,7 @@ function CloneSubfield(index){
 	<div id="yui-main">
 	<div class="yui-b">
 
-<h1>Serial Edition <i><!-- TMPL_VAR name="bibliotitle" --></i></h1>
+<h1>Serial Edition <i><!-- TMPL_VAR name="bibliotitle" --> <!-- TMPL_IF name="callnumber" -->(<!-- TMPL_VAR name="callnumber" -->)<!-- /TMPL_IF --></i></h1>
 <form method="post" name="f" action="serials-edit.pl" id="serials_edit">
 <!--onsubmit="return barcode_check()">-->
 
diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl
index 08eae33f88..d6b129a453 100755
--- a/serials/serials-edit.pl
+++ b/serials/serials-edit.pl
@@ -140,12 +140,13 @@ my @subscriptionloop;
 my %processedsubscriptionid;
 foreach my $subscriptionid (@subscriptionids){
     #Donot process subscriptionid twice if it was already processed.
+    my $subscriptiondetail = GetSubscription($subscriptionid);
     next unless (defined($subscriptionid) && !$processedsubscriptionid{$subscriptionid});
     my $cell;
     if ($serialdatalist[0]->{'serialsadditems'}){
     #Create New empty item
         $cell =
-        PrepareItemrecordDisplay( $serialdatalist[0]->{'biblionumber'},'', GetSubscription($subscriptionid));
+        PrepareItemrecordDisplay( $serialdatalist[0]->{'biblionumber'},'', $subscriptiondetail);
         $cell->{serialsadditems} = 1;
     }
     $cell->{'subscriptionid'}=$subscriptionid;
@@ -158,6 +159,10 @@ foreach my $subscriptionid (@subscriptionids){
                             'subscriptionexpired'=>HasSubscriptionExpired($subscriptionid),
     };
     $processedsubscriptionid{$subscriptionid}=1;
+    $template->param(bibliotitle  => $subscriptiondetail->{'bibliotitle'},
+                        callnumber => $subscriptiondetail->{'callnumber'},
+                );
+
 }
 $template->param(newserialloop=>\@newserialloop);
 $template->param(subscriptions=>\@subscriptionloop);
@@ -293,9 +298,8 @@ if ($op and $op eq 'serialchangestatus') {
 }
 
 $template->param(
-	serialsadditems => $serialdatalist[0]->{'serialsadditems'},
-	bibliotitle  => $bibdata->{'title'},
-	biblionumber => $serialdatalist[0]->{'biblionumber'},
-	serialslist  => \@serialdatalist,
+    serialsadditems => $serialdatalist[0]->{'serialsadditems'},
+    biblionumber => $serialdatalist[0]->{'biblionumber'},
+    serialslist  => \@serialdatalist,
 );
 output_html_with_http_headers $query, $cookie, $template->output;
-- 
2.20.1