From 20226a8082a1e7bd5908f13945e4a1fca58a1d13 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 1 Jul 2022 15:30:33 +0000 Subject: [PATCH] Bug 31086: Update existing unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit bf2a9b5279151b61bb149c318505e2d5e5ca8df8) Signed-off-by: Lucas Gass --- t/db_dependent/Holds.t | 8 +++++--- t/db_dependent/Reserves.t | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t index 41e652c733..6f87d43533 100755 --- a/t/db_dependent/Holds.t +++ b/t/db_dependent/Holds.t @@ -155,6 +155,7 @@ is( $hold->suspend_until, '2013-01-01 00:00:00', "Test ModReserve, suspend until ModReserve({ # call without reserve_id rank => '3', + branchcode => $branch_1, biblionumber => $biblio->biblionumber, itemnumber => $itemnumber, borrowernumber => $borrowernumber, @@ -348,6 +349,7 @@ $hold = Koha::Hold->new( borrowernumber => $borrowernumbers[0], itemnumber => $itemnumber, biblionumber => $biblio->biblionumber, + branchcode => $branch_1, } )->store(); is( CanItemBeReserved( $patrons[0], $damaged_item )->{status}, @@ -527,7 +529,7 @@ subtest 'CanItemBeReserved' => sub { # Biblio-level hold AddReserve({ - branch => $branch_1, + branchcode => $branch_1, borrowernumber => $borrowernumbers[0], biblionumber => $biblionumber_1, }); @@ -543,7 +545,7 @@ subtest 'CanItemBeReserved' => sub { Koha::Holds->search({borrowernumber => $borrowernumbers[0]})->delete; # Item-level hold AddReserve({ - branch => $branch_1, + branchcode => $branch_1, borrowernumber => $borrowernumbers[0], biblionumber => $biblionumber_1, itemnumber => $item_11->itemnumber, @@ -597,7 +599,7 @@ subtest 'CanItemBeReserved' => sub { ); AddReserve({ - branch => $branch_1, + branchcode => $branch_1, borrowernumber => $borrowernumbers[0], biblionumber => $biblionumber_2, itemnumber => $item_21->itemnumber diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index 91ebbf3f3b..e309ecfd55 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -559,14 +559,14 @@ my $borrowernumber_tmp_2 = $bor_tmp_2->borrowernumber; my $date_in_future = dt_from_string(); $date_in_future = $date_in_future->add_duration(DateTime::Duration->new(days => 1)); AddReserve({ - branch => 'CPL', + branchcode => 'CPL', borrowernumber => $borrowernumber_tmp_1, biblionumber => $bibnum, priority => 3, reservation_date => output_pref($date_in_future) }); AddReserve({ - branch => 'CPL', + branchcode => 'CPL', borrowernumber => $borrowernumber_tmp_2, biblionumber => $bibnum, priority => 4, -- 2.20.1