From 53ccbc7b61ec715f120b80723d669b9c164a8b54 Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Thu, 2 Nov 2023 13:16:52 +0000
Subject: [PATCH] Bug 35231: Resolve crash on unexisting patron in Auth

Test plan:
Without this patch:
Logout from OPAC. Crash.
Try to login. Crash.

With this patch:
Enable login in tracking triggers. Clear lastseen.
Flush memcache.
Login. Check lastseen.
Logout.
Login.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 C4/Auth.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/C4/Auth.pm b/C4/Auth.pm
index a73d0c92b6..90c028b270 100644
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -1318,8 +1318,8 @@ sub checkauth {
             ));
         }
 
-        my $patron = Koha::Patrons->find({ userid => $userid });
-        $patron->update_lastseen('login');
+        my $patron = $userid ? Koha::Patrons->find({ userid => $userid }) : undef;
+        $patron->update_lastseen('login') if $patron;
 
         # In case, that this request was a login attempt, we want to prevent that users can repost the opac login
         # request. We therefore redirect the user to the requested page again without the login parameters.
-- 
2.39.5