From 5810b72af96a032fcf3d41b39eb0ad582117d2c1 Mon Sep 17 00:00:00 2001 From: Phil Ringnalda Date: Sun, 19 Apr 2020 02:37:49 +0000 Subject: [PATCH] Bug 20501: Don't cut strings when unhighlighting in intranet search results When you click Unhighlight on the search results of a search in the staff client when the search terms contain the same word twice, like "ma ma", the highlighted words disappear, and don't reappear if you click Highlight. This patch makes the same change to the intranet copy of jquery.highlight-3.js that bug 5844 made to the OPAC copy. Test plan: 1) Without this patch, search in the intranet for ma ma and verify you have at least two matching records. 2) Notice that the Ma in Material type: Book is highlighted. 3) Click Unhighlight, and notice that it has become terial type: Book 4) Apply this patch, repeat the search with a shift+reload to reload the .js 5) Click Unhighlight, and verify that Material type: Book remains Material Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson --- .../lib/jquery/plugins/jquery.highlight-3.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.highlight-3.js b/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.highlight-3.js index 69bb52d3b1..8eabca4bfd 100644 --- a/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.highlight-3.js +++ b/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.highlight-3.js @@ -44,10 +44,6 @@ jQuery.fn.highlight = function(pat) { jQuery.fn.removeHighlight = function() { return this.find("span.term").each(function() { - this.parentNode.firstChild.nodeName; - with (this.parentNode) { - replaceChild(this.firstChild, this); - normalize(); - } - }).end(); + $(this).contents().unwrap(); + }); }; -- 2.39.2