From 61b81d56bfdb8e9f7689bb2c677e4c5b43dc3dc8 Mon Sep 17 00:00:00 2001
From: doxulting <doxulting>
Date: Fri, 15 Apr 2005 14:31:51 +0000
Subject: [PATCH] The search query was returning all records when  was empty

---
 C4/Bull.pm | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/C4/Bull.pm b/C4/Bull.pm
index 3b1a5556e3..d7ef65e64d 100755
--- a/C4/Bull.pm
+++ b/C4/Bull.pm
@@ -228,8 +228,25 @@ sub getsubscriptions {
 		$sth = $dbh->prepare("select subscription.subscriptionid,biblio.title,biblioitems.issn,subscription.notes from subscription,biblio,biblioitems where  biblio.biblionumber = biblioitems.biblionumber and biblio.biblionumber=subscription.biblionumber and biblio.biblionumber=?");
 		$sth->execute($biblionumber);
 	} else {
-		$sth = $dbh->prepare("select subscription.subscriptionid,biblio.title,biblioitems.issn,subscription.notes from subscription,biblio,biblioitems where  biblio.biblionumber = biblioitems.biblionumber and biblio.biblionumber=subscription.biblionumber and (biblio.title like ? or biblioitems.issn = ? )");
-		$sth->execute("%$title%",$ISSN);
+		if ($ISSN and $title)
+		{
+			$sth = $dbh->prepare("select subscription.subscriptionid,biblio.title,biblioitems.issn,subscription.notes from subscription,biblio,biblioitems where  biblio.biblionumber = biblioitems.biblionumber and biblio.biblionumber=subscription.biblionumber and (biblio.title like ? or biblioitems.issn = ? )");
+			$sth->execute("%$title%",$ISSN);
+		}
+		else
+		{
+			if ($ISSN)
+			{
+				$sth = $dbh->prepare("select subscription.subscriptionid,biblio.title,biblioitems.issn,subscription.notes from subscription,biblio,biblioitems where  biblio.biblionumber = biblioitems.biblionumber and biblio.biblionumber=subscription.biblionumber and biblioitems.issn = ?");
+				$sth->execute($ISSN);
+			}
+			else
+			{
+				$sth = $dbh->prepare("select subscription.subscriptionid,biblio.title,biblioitems.issn,subscription.notes from subscription,biblio,biblioitems where  biblio.biblionumber = biblioitems.biblionumber and
+ biblio.biblionumber=subscription.biblionumber and biblio.title like ? ");
+				$sth->execute("%$title%");
+			}
+		}
 	}
 		my @results;
 	while (my $line = $sth->fetchrow_hashref) {
-- 
2.39.5