From 6fdc9f035dd7b07cfdfc9023b9f667975964a86b Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 21 Jan 2020 16:08:12 +0100 Subject: [PATCH] Bug 24441: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson --- t/db_dependent/Circulation/Returns.t | 32 +++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t index 25ce71849c..5def587366 100644 --- a/t/db_dependent/Circulation/Returns.t +++ b/t/db_dependent/Circulation/Returns.t @@ -17,7 +17,7 @@ use Modern::Perl; -use Test::More tests => 5; +use Test::More tests => 6; use Test::MockModule; use Test::Warn; @@ -364,4 +364,34 @@ subtest 'Checkin of an item claimed as returned should generate a message' => su ok( $messages->{ReturnClaims}, "ReturnClaims is in messages for return of a claimed as returned itm" ); }; +subtest 'BranchTransferLimitsType' => sub { + plan tests => 2; + + t::lib::Mocks::mock_preference('AutomaticItemReturn', 0); + t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1); + t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'ccode'); + + my $biblio = $builder->build_object( { class => 'Koha::Biblios' } ); + my $item = $builder->build_object( + { + class => 'Koha::Items', + value => { + biblionumber => $biblio->biblionumber, + notforloan => 0, + itemlost => 0, + withdrawn => 0, + } + } + ); + my $patron = $builder->build_object({class => 'Koha::Patrons'}); + my $checkout = AddIssue( $patron->unblessed, $item->barcode ); + my ( $doreturn, $messages, $issue ) = AddReturn($item->barcode); + is( $doreturn, 1, 'AddReturn should have checkin the item if BranchTransferLimitsType=ccode'); + + t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype'); + $checkout = AddIssue( $patron->unblessed, $item->barcode ); + ( $doreturn, $messages, $issue ) = AddReturn($item->barcode); + is( $doreturn, 1, 'AddReturn should have checkin the item if BranchTransferLimitsType=itemtype'); +}; + $schema->storage->txn_rollback; -- 2.39.2