From 878b0d0e0f08939e8e5a77e07c838bc6cd8c1c6d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 15 May 2023 11:43:04 +0000 Subject: [PATCH] Bug 33553: Remove unecessary GetCategories calls in templates This patch removes unnecessary references to AuthorisedValues.GetCategories: SET AuthorisedValuesCategories = AuthorisedValues.GetCategories The AuthorisedValuesCategories variable is not used. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, create a club template with "Allow public enrollment" enabled. - Create a new club. The club creation process should work correctly. - Open a patron account for checkout and confirm that you can enroll the patron in the new club via the "Clubs" tab. - Log in to the OPAC and confirm that you can successfully enroll yourself in the new club via the "Clubs" tab on your patron summary page. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- .../intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt | 1 - koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt | 1 - koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt | 1 - 3 files changed, 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt index 1633f42d32..ebbb27897a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt @@ -3,7 +3,6 @@ [% USE KohaDates %] [% USE Branches %] [% USE AuthorisedValues %] -[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt index 13f209ba46..d120da0d07 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt @@ -1,5 +1,4 @@ [% USE AuthorisedValues %] -[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] <h1> Enroll in <em>[% club.name | html %]</em> diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt index 6f6d62ee82..b83e1e3156 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt @@ -1,5 +1,4 @@ [% USE AuthorisedValues %] -[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] <h2> Enroll in <em>[% club.name | html %]</em> -- 2.39.5