From 8b0a44dcb597d039b03e4f0529a2af6326f3afbf Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 18 Aug 2021 12:57:51 +0200
Subject: [PATCH] Bug 25078: Explicitely return from DB revs to avoid warnings

% perl -wc installer/data/mysql/atomicupdate/skeleton.pl
Useless use of anonymous hash ({}) in void context at installer/data/mysql/atomicupdate/skeleton.pl

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 installer/data/mysql/atomicupdate/skeleton.pl | 2 +-
 installer/data/mysql/db_revs/210600000.pl     | 2 +-
 installer/data/mysql/db_revs/210600001.pl     | 2 +-
 installer/data/mysql/db_revs/210600002.pl     | 2 +-
 installer/data/mysql/db_revs/210600004.pl     | 2 +-
 installer/data/mysql/db_revs/210600005.pl     | 2 +-
 installer/data/mysql/db_revs/210600006.pl     | 2 +-
 installer/data/mysql/db_revs/210600007.pl     | 2 +-
 installer/data/mysql/db_revs/210600008.pl     | 2 +-
 installer/data/mysql/db_revs/210600009.pl     | 2 +-
 installer/data/mysql/db_revs/210600010.pl     | 2 +-
 installer/data/mysql/db_revs/210600011.pl     | 2 +-
 installer/data/mysql/db_revs/210600012.pl     | 2 +-
 installer/data/mysql/db_revs/210600013.pl     | 2 +-
 installer/data/mysql/db_revs/210600014.pl     | 2 +-
 installer/data/mysql/db_revs/210600015.pl     | 2 +-
 installer/data/mysql/db_revs/210600016.pl     | 2 +-
 17 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/installer/data/mysql/atomicupdate/skeleton.pl b/installer/data/mysql/atomicupdate/skeleton.pl
index 082f47e024..5709cd56f2 100755
--- a/installer/data/mysql/atomicupdate/skeleton.pl
+++ b/installer/data/mysql/atomicupdate/skeleton.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "BUG_NUMBER",
     description => "A single line description",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600000.pl b/installer/data/mysql/db_revs/210600000.pl
index a9d08fef02..aa0fdb5160 100755
--- a/installer/data/mysql/db_revs/210600000.pl
+++ b/installer/data/mysql/db_revs/210600000.pl
@@ -2,7 +2,7 @@ use Modern::Perl;
 use utf8;
 use Encode qw( encode_utf8 );
 
-{
+return {
     bug_number => undef,
     description => 'Increase DBRev for 21.06',
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600001.pl b/installer/data/mysql/db_revs/210600001.pl
index ee84b39907..41064b351f 100755
--- a/installer/data/mysql/db_revs/210600001.pl
+++ b/installer/data/mysql/db_revs/210600001.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "28489",
     description => "Modify sessions.a_session from longtext to longblob",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600002.pl b/installer/data/mysql/db_revs/210600002.pl
index 25e0f6d9e7..c847d7f5b3 100755
--- a/installer/data/mysql/db_revs/210600002.pl
+++ b/installer/data/mysql/db_revs/210600002.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "28490",
     description => "Bring back accidentally deleted relationship columns",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600004.pl b/installer/data/mysql/db_revs/210600004.pl
index e8a08841f0..5729dcbad3 100755
--- a/installer/data/mysql/db_revs/210600004.pl
+++ b/installer/data/mysql/db_revs/210600004.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "15788",
     description => "Split edit_borrowers permission",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600005.pl b/installer/data/mysql/db_revs/210600005.pl
index 8386af8878..883fd0e3ed 100755
--- a/installer/data/mysql/db_revs/210600005.pl
+++ b/installer/data/mysql/db_revs/210600005.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "26205",
     description => "Add new system preference NewsLog to log news changes",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600006.pl b/installer/data/mysql/db_revs/210600006.pl
index 38536485a7..d2ea29de94 100755
--- a/installer/data/mysql/db_revs/210600006.pl
+++ b/installer/data/mysql/db_revs/210600006.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "14237",
     description => "Add individual bibliographic records to course reserves",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600007.pl b/installer/data/mysql/db_revs/210600007.pl
index 7bef60a8cd..56ff03d567 100755
--- a/installer/data/mysql/db_revs/210600007.pl
+++ b/installer/data/mysql/db_revs/210600007.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "11879",
     description => "Add a new field to patron record: main contact method",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600008.pl b/installer/data/mysql/db_revs/210600008.pl
index 1c82f5c94e..431d7f85ce 100755
--- a/installer/data/mysql/db_revs/210600008.pl
+++ b/installer/data/mysql/db_revs/210600008.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "20310",
     description => "Add new system preference ArticleRequestsOpacHostRedirection",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600009.pl b/installer/data/mysql/db_revs/210600009.pl
index 174e2048d1..b0bd5a2b42 100755
--- a/installer/data/mysql/db_revs/210600009.pl
+++ b/installer/data/mysql/db_revs/210600009.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "20472",
     description => "Add columns format and urls in article_requests table",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600010.pl b/installer/data/mysql/db_revs/210600010.pl
index 484ee395e0..8af6bb6fe3 100755
--- a/installer/data/mysql/db_revs/210600010.pl
+++ b/installer/data/mysql/db_revs/210600010.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "20472",
     description => "Add new system preference ArticleRequestsSupportedFormats",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600011.pl b/installer/data/mysql/db_revs/210600011.pl
index 12f7dd29ba..d3c35b345f 100755
--- a/installer/data/mysql/db_revs/210600011.pl
+++ b/installer/data/mysql/db_revs/210600011.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "28567",
     description => "Set to NULL empty branches fields",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600012.pl b/installer/data/mysql/db_revs/210600012.pl
index c46644f887..fef986078b 100755
--- a/installer/data/mysql/db_revs/210600012.pl
+++ b/installer/data/mysql/db_revs/210600012.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "15067",
     description => "Add missing languages",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600013.pl b/installer/data/mysql/db_revs/210600013.pl
index c73edc7cbb..a8e52eaaf6 100755
--- a/installer/data/mysql/db_revs/210600013.pl
+++ b/installer/data/mysql/db_revs/210600013.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "22435",
     description => "Update existing offsets",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600014.pl b/installer/data/mysql/db_revs/210600014.pl
index 76017c718e..c56acf6fe4 100755
--- a/installer/data/mysql/db_revs/210600014.pl
+++ b/installer/data/mysql/db_revs/210600014.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "28813",
     description => "Update delivery_note to failure_code in message_queue",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600015.pl b/installer/data/mysql/db_revs/210600015.pl
index 9b53ba0e3a..af3b8b8bf6 100755
--- a/installer/data/mysql/db_revs/210600015.pl
+++ b/installer/data/mysql/db_revs/210600015.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "12561",
     description => "Remove system preferences HighlightOwnItemsOnOPAC and HighlightOwnItemsOnOPACWhich",
     up => sub {
diff --git a/installer/data/mysql/db_revs/210600016.pl b/installer/data/mysql/db_revs/210600016.pl
index 27aa7d07b0..05b0544250 100755
--- a/installer/data/mysql/db_revs/210600016.pl
+++ b/installer/data/mysql/db_revs/210600016.pl
@@ -1,6 +1,6 @@
 use Modern::Perl;
 
-{
+return {
     bug_number => "24387",
     description => "Rename opac_news with additional_contents",
     up => sub {
-- 
2.39.2