From a0072fa491e8607a9aad54d8e07db5d20fefbbfe Mon Sep 17 00:00:00 2001
From: Liz Rea <liz@catalyst.net.nz>
Date: Tue, 19 Sep 2017 15:29:22 +1200
Subject: [PATCH] Bug 19338: Fix sorting by dates in opac-account.tt

To test:
Find an account with lots of fines/payments
load up the borrower's account in the OPAC
note that the sort on the dates sorts by day, and not by date.
apply this patch
reload the page, note that the sort on the dates is now correct.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 .../opac-tmpl/bootstrap/en/modules/opac-account.tt     | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt
index 44c8555178..7e2d7b91c5 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt
@@ -71,7 +71,7 @@
                             <thead>
                                 <tr>
                                     [% IF ENABLE_OPAC_PAYMENTS %]<th>&nbsp;</th>[% END %]
-                                    <th>Date</th>
+                                    <th class="title-string">Date</th>
                                     <th>Description</th>
                                     <th>Fine amount</th>
                                     <th>Amount outstanding</th>
@@ -102,7 +102,7 @@
                                                 [% END %]
                                             </td>
                                         [% END %]
-                                        <td>[% ACCOUNT_LINE.date | $KohaDates %]</td>
+                                        <td><span title="[% ACCOUNT_LINE.date %]">[% ACCOUNT_LINE.date | $KohaDates %]</span></td>
                                         <td>
                                             [% SWITCH ACCOUNT_LINE.accounttype %]
                                             [% CASE 'Pay' %]Payment, thanks
@@ -186,7 +186,11 @@
 <script type="text/javascript">
 $( document ).ready(function() {
 
-    $("#finestable").dataTable($.extend(true, {}, dataTablesDefaults ));
+    $("#finestable").dataTable($.extend(true, {}, dataTablesDefaults, {
+        "aoColumnDefs": [
+             { "sType": "title-string", "aTargets" : [ "title-string" ] }
+         ]
+    } ));
 
     $(".paypal").on("click", function() {
         window.open('https://www.paypal.com/webapps/mpp/paypal-popup','WIPaypal','toolbar=no, location=no, directories=no, status=no, menubar=no, scrollbars=yes, resizable=yes, width=1060, height=700');
-- 
2.20.1