From a2fa4fcc03583ef3e6a6a299b4c0e0f3145ca32d Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 3 Mar 2023 20:41:21 +0000 Subject: [PATCH] Bug 3831: Add a warning to about page when there is no FA framework The feature is effectively disab;ed throughout Koha when this framework is deleted. There do not appear to be any other side effects. We should report this on the about page for informatinal purposes To test: 1 - Apply patch 2 - Check about page, no change 3 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FB' WHERE frameworkcode = 'FA' 4 - Refresh about page 5 - Note new warning 6 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FA' WHERE frameworkcode = 'FB' 7 - Refresh about page 8 - No warning Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- about.pl | 3 +++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/about.pl b/about.pl index f4d1c7a959..1296996041 100755 --- a/about.pl +++ b/about.pl @@ -588,7 +588,9 @@ $template->param( 'bad_yaml_prefs' => \@bad_yaml_prefs ) if @bad_yaml_prefs; my @frameworkcodes = Koha::BiblioFrameworks->search->get_column('frameworkcode'); my @hidden_biblionumbers; push @frameworkcodes, ""; # it's not in the biblio_frameworks table! + my $no_FA_framework = 1; for my $frameworkcode ( @frameworkcodes ) { + $no_FA_framework = 0 if $frameworkcode eq 'FA'; my $shouldhidemarc_opac = Koha::Filter::MARC::ViewPolicy->should_hide_marc( { frameworkcode => $frameworkcode, @@ -608,6 +610,7 @@ $template->param( 'bad_yaml_prefs' => \@bad_yaml_prefs ) if @bad_yaml_prefs; if $shouldhidemarc_intranet->{biblionumber}; } $template->param( warnHiddenBiblionumbers => \@hidden_biblionumbers ); + $template->param( warnFastCataloging => $no_FA_framework ); } { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt index bfde0eca10..81ddc19e61 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt @@ -382,10 +382,16 @@ Contact your system administrator. [% END # /IF warnConnectBroker %] - [% IF warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || warnXSLT || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size %] + [% IF warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || warnXSLT || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnFastCataloging %]

Warnings regarding the system configuration

+ [% IF (warnFastCataloging) %] + + + + + [% END %] [% IF (warnPrefRequireChoosingExistingAuthority) %] -- 2.39.5
Preferences and parameters
Warning There is no "Fast add" (FA) framework defined in administration->MARC frameworks. This disables the 'Fast cataloging' feature in cataloging/circulation.
Warning