From f8df1953c887bdedd1645a121b420e96e5bf9b67 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Wed, 1 Mar 2023 14:55:38 +0000 Subject: [PATCH] Bug 32450: (QA follow-up) Fix QA test errors Exec flag added to atomic update file, trailing whitespaces removed Unit tests patched to remove duplicate variable names Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi --- .../mysql/atomicupdate/bug_32450-add_debit_type_flag.pl | 0 t/db_dependent/Accounts.t | 8 ++++---- 2 files changed, 4 insertions(+), 4 deletions(-) mode change 100644 => 100755 installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl diff --git a/installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl b/installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl old mode 100644 new mode 100755 diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t index 7b8fbcf3bd..df53e0704b 100755 --- a/t/db_dependent/Accounts.t +++ b/t/db_dependent/Accounts.t @@ -835,16 +835,16 @@ subtest "Koha::Account::non_issues_charges tests" => sub { } )->store; - my ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges ); - my $other_charges = $total - $non_issues_charges; + my ( $new_total, $new_non_issues_charges ) = ( $account->balance, $account->non_issues_charges ); + my $new_other_charges = $new_total - $new_non_issues_charges; is( $account->balance, $res + $rent + $manual + $print, 'Total charges should be Res + Rent + Manual + Print' ); - is( $non_issues_charges, 15, + is( $new_non_issues_charges, 15, 'All types except Print should count towards the non issue charge' ); - is( $other_charges, 4, 'There should be non-included charges for Print' ); + is( $new_other_charges, 4, 'There should be non-included charges for Print' ); }; -- 2.39.5