From ff14b726eeff0f7c97f07f54788a6ab7ef54fdc5 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 1 Aug 2008 11:33:11 -0500
Subject: [PATCH] Correcting structure and markup.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
---
 .../prog/en/modules/members/messaging.tmpl    | 113 ++++--------------
 1 file changed, 21 insertions(+), 92 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/messaging.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/members/messaging.tmpl
index 3353c0e938..64c045e6cf 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/messaging.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/messaging.tmpl
@@ -1,73 +1,6 @@
 <!-- TMPL_INCLUDE NAME="doc-head-open.inc" -->
 <title>Koha &rsaquo; Patrons &rsaquo; <!-- TMPL_IF NAME="unknowuser" -->Patron does not exist<!-- TMPL_ELSE -->Patron Details for <!-- TMPL_VAR NAME="firstname" --> <!-- TMPL_VAR NAME="surname" --> (<!-- TMPL_VAR NAME="cardnumber" -->)<!-- /TMPL_IF --></title>
 <!-- TMPL_INCLUDE NAME="doc-head-close.inc" -->
-<!-- TMPL_INCLUDE NAME="calendar.inc" -->
-<script type="text/javascript" src="<!-- TMPL_VAR name="themelang" -->/lib/jquery/plugins/jquery.tablesorter.min.js"></script>
-<script type="text/javascript" src="<!-- TMPL_VAR name="themelang" -->/lib/jquery/plugins/jquery.checkboxes.pack.js"></script>
-<script type="text/JavaScript" language="JavaScript">
-//<![CDATA[
-$.tablesorter.addParser({
-    id: 'articles', 
-    is: function(s) {return false;  }, 
-    format: function(s) { return s.toLowerCase().replace(/^(the|an|a) /,''); }, 
-    type: 'text' 
-});
-$(document).ready(function() {
-	$('#finesholdsissues > ul').tabs();
-	$("#issuest").tablesorter({<!-- TMPL_IF EXPR="dateformat eq 'metric'" -->
-		dateFormat: 'uk',<!-- /TMPL_IF -->
-		sortList: [[1,0]],
-		headers: { 1: { sorter: 'articles' },4:{sorter:false},5: { sorter: false },6:{sorter:false},7:{sorter:false}}
-	}); 
-	$("#holdst").tablesorter({<!-- TMPL_IF EXPR="dateformat eq 'metric'" -->
-		dateFormat: 'uk',<!-- /TMPL_IF -->
-		sortList: [[0,0]],
-		headers: { 1: { sorter: 'articles' },6: { sorter: false }}
-	}); 
-	$('#manage-patron-image').find("input[@value*=Delete]").click(function(){
-		 return confirm('Are you sure you want to delete this patron image? This cannot be undone.');
-	});<!-- TMPL_IF NAME="picture" -->
-	$('#manage-patron-image').find("input[@value*=Upload]").click(function(){
-		if($("#uploadfile").val() == ""){
-			alert("Please choose a file to upload");
-			return false;
-			} else {
-		 return confirm('Are you sure you want to replace the current patron image? This cannot be undone.');
-		 }
-	});<!-- /TMPL_IF -->
-	$("#renew_all").click(function(){ $(".checkboxed").checkCheckboxes(":not(input[@name*=barcodes])"); $(".checkboxed").unCheckCheckboxes(":not(input[@name*=items])"); });
-	$("#return_all").click(function(){ $(".checkboxed").checkCheckboxes(":not(input[@name*=items])"); $(".checkboxed").unCheckCheckboxes(":not(input[@name*=barcodes])"); });
-	$("#CheckAllitems").click(function(){ $(".checkboxed").checkCheckboxes(":not(input[@name*=barcodes])"); $(".checkboxed").unCheckCheckboxes(":not(input[@name*=items])"); return false; });
-    $("#CheckNoitems").click(function(){ $(".checkboxed").unCheckCheckboxes(":not(input[@name*=barcodes])"); return false; });
-	$("#CheckAllreturns").click(function(){ $(".checkboxed").checkCheckboxes(":not(input[@name*=items])"); $(".checkboxed").unCheckCheckboxes(":not(input[@name*=barcodes])"); return false; });
-    $("#CheckNoreturns").click(function(){ $(".checkboxed").unCheckCheckboxes(":not(input[@name*=items])"); return false; });
- });
-function uncheck_sibling(me){
-nodename=me.getAttribute("name");
-if (nodename =="barcodes[]"){
-    var Node=me.parentNode.previousSibling;
-    while (Node.nodeName!="TD"){Node=Node.previousSibling}
-    var Nodes=Node.childNodes;
-    for (var i=0;i<Nodes.length;i++){
-      if (Nodes[i].nodeName=="INPUT" && Nodes[i].getAttribute("type")=="checkbox"){
-        Nodes[i].checked=false;
-      }     
-   }   
-
-}else {
-    var Node=me.parentNode.nextSibling;
-    while (Node.nodeName!="TD"){Node=Node.nextSibling}
-    var Nodes=Node.childNodes;
-    for (var i=0;i<Nodes.length;i++){
-      if (Nodes[i].nodeName=="INPUT" && Nodes[i].getAttribute("type")=="checkbox"){
-        Nodes[i].checked=false;
-      }     
-   }   
-}
-}
-//]]>
-</script>
-
 </head>
 <body>
 <!-- TMPL_INCLUDE NAME="header.inc" -->
@@ -75,7 +8,7 @@ if (nodename =="barcodes[]"){
 
 <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a>  &rsaquo; <!-- TMPL_IF NAME="unknowuser" -->Patron does not exist<!-- TMPL_ELSE -->Patron Details for <!-- TMPL_VAR NAME="firstname" --> <!-- TMPL_VAR NAME="surname" --> (<!-- TMPL_VAR NAME="cardnumber" -->)<!-- /TMPL_IF --> </div>
 
-<div id="doc3" class="yui-t1">
+<div id="doc3" class="yui-t2">
    
    <div id="bd">
 	<div id="yui-main">
@@ -109,37 +42,39 @@ if (nodename =="barcodes[]"){
    </div>
 <!-- TMPL_ELSE -->
 
- <div class="yui-u first">
-
-<form method="get" name="messaging">
+ <form method="get" name="messaging" action="/cgi-bin/koha/members/messaging.pl">
 
 <input type="hidden" name="modify" value="yes" />
 <input type="hidden" name="borrowernumber" value="<!-- TMPL_VAR NAME="borrowernumber" -->" />
-<fieldset class="brief"><legend>Manage patron messaging settings</legend>
   <!-- TMPL_IF NAME= "settings_updated" -->
-  <div class="dialog message"><h1>Settings Updated</h1>
+  <div class="dialog message"><h4>Settings Updated</h4>
     The patron settings have been updated</div>
   <!-- /TMPL_IF -->
+ 
+ <h3>Manage patron messaging settings</h3>
+
   <table>
-    <tr><TH></TH><TH># days in advance</TH><TH>sms</TH><TH>email</TH><TH>Digests only?</TH><TH>rss</TH><TH>do not notify</TH></tr>
+    <tr><th></th><th># days in advance</th><th>sms</th><th>email</th><th>Digests only?</th><th>rss</th><th>do not notify</th></tr>
     <!-- TMPL_LOOP name="messaging_preferences" -->
     <tr>
-      <td><label for="firstname"><!-- TMPL_VAR NAME="message_name" --></label></td>
+      <td><!-- TMPL_VAR NAME="message_name" --></td>
       <!-- TMPL_IF NAME="takes_days" -->
-      <td><SELECT name="<!-- TMPL_VAR NAME="message_attribute_id" -->-DAYS" id="<!-- TMPL_VAR NAME="message_name" -->-DAYS" >
+      <td><select name="<!-- TMPL_VAR NAME="message_attribute_id" -->-DAYS" id="<!-- TMPL_VAR NAME="message_name" -->-DAYS" >
           <!-- TMPL_LOOP name="select_days" -->
-          <OPTION VALUE="<!-- TMPL_VAR NAME="day" -->"  <!-- TMPL_VAR NAME="selected"  --> ><!-- TMPL_VAR NAME="day" --></OPTION>
+          <!-- TMPL_IF NAME="selected" --><option value="<!-- TMPL_VAR NAME="day" -->" selected="selected"><!-- TMPL_VAR NAME="day" --></option><!-- TMPL_ELSE -->
+          <option value="<!-- TMPL_VAR NAME="day" -->"><!-- TMPL_VAR NAME="day" --></option>
+      <!-- /TMPL_IF -->
           <!-- /TMPL_LOOP -->
-        </SELECT>
+        </select>
       </td>
       <!-- TMPL_ELSE -->
       <td>-</td>
       <!-- /TMPL_IF -->
       <!-- TMPL_IF NAME="transport-sms" -->
-      <td><input type="checkbox"
+      <td><input type="radio"
                  id="sms<!-- TMPL_VAR NAME="message_attribute_id" -->"
                  name="<!-- TMPL_VAR NAME="message_attribute_id" -->"
-                 value="sms" <!-- TMPL_VAR NAME="transport-sms"   --> onclick = "document.messaging.none<!-- TMPL_VAR NAME="message_attribute_id" -->.checked=false;">
+                 value="sms" <!-- TMPL_VAR NAME="transport-sms"   --> onclick = "document.messaging.none<!-- TMPL_VAR NAME="message_attribute_id" -->.checked=false;" />
       </td>
       <!-- TMPL_ELSE -->
       <td>-</td>
@@ -149,7 +84,7 @@ if (nodename =="barcodes[]"){
       <td><input type="checkbox"
                  id="email<!-- TMPL_VAR NAME="message_attribute_id" -->"
                  name="<!-- TMPL_VAR NAME="message_attribute_id" -->"
-                 value="email"   <!-- TMPL_VAR NAME="transport-email"   --> onclick = "document.messaging.none<!-- TMPL_VAR NAME="message_attribute_id" -->.checked=false;">
+                 value="email"   <!-- TMPL_VAR NAME="transport-email"   --> onclick = "document.messaging.none<!-- TMPL_VAR NAME="message_attribute_id" -->.checked=false;" />
       </td>
       <!-- TMPL_ELSE -->
       <td>-</td>
@@ -159,7 +94,7 @@ if (nodename =="barcodes[]"){
       <td><input type="checkbox"
                  id="digest<!-- TMPL_VAR NAME="message_attribute_id" -->"
                  value="<!-- TMPL_VAR NAME="message_attribute_id" -->"
-                 name="digest"   <!-- TMPL_VAR NAME="digest" --> onclick = "document.messaging.none<!-- TMPL_VAR NAME="message_attribute_id" -->.checked=false;">
+                 name="digest"   <!-- TMPL_VAR NAME="digest" --> onclick = "document.messaging.none<!-- TMPL_VAR NAME="message_attribute_id" -->.checked=false;" />
       </td>
       <!-- TMPL_ELSE -->
       <td>-</td>
@@ -169,7 +104,7 @@ if (nodename =="barcodes[]"){
       <td><input type="checkbox"
                  id="rss<!-- TMPL_VAR NAME="message_attribute_id" -->"
                  name="<!-- TMPL_VAR NAME="message_attribute_id" -->"
-                 value="rss"  <!-- TMPL_VAR NAME="transport-rss"   --> onclick = "document.messaging.none<!-- TMPL_VAR NAME="message_attribute_id" -->.checked=false;">
+                 value="rss"  <!-- TMPL_VAR NAME="transport-rss"   --> onclick = "document.messaging.none<!-- TMPL_VAR NAME="message_attribute_id" -->.checked=false;" />
       </td>
       <!-- TMPL_ELSE -->
       <td>-</td>
@@ -184,20 +119,18 @@ if (nodename =="barcodes[]"){
     </tr>
     <!-- /TMPL_LOOP -->
   </table>
-SMS number: <input type="text" name="SMSnumber" value="<!-- TMPL_VAR NAME="SMSnumber"  -->" />
+<!-- TMPL_IF NAME="transport-sms" --><p><label for="SMSnumber">SMS number:</label> <input type="text" id="SMSnumber" name="SMSnumber" value="<!-- TMPL_VAR NAME="SMSnumber"  -->" /></p><!-- /TMPL_IF -->
 
-</fieldset>
 
 
 <fieldset class="action">
   <input type="submit" value="Submit Changes" /> <a class="cancel" href="/cgi-bin/koha/opac-user.pl">Cancel</a>
 </fieldset>
-<br />
 
 <!-- TMPL_IF NAME="message_queue" -->
 <table>
-  <CAPTION>Message Queue</CAPTION>
-  <tr><tH>Type</TH><TH>Subject</TH><TH>Status</TH><TH>Time Prepared</TH></tr>
+  <caption>Message Queue</caption>
+  <tr><th>Type</th><th>Subject</th><th>Status</th><th>Time Prepared</th></tr>
 <!-- TMPL_LOOP name="message_queue" -->
   <tr><td><!-- TMPL_VAR NAME="message_transport_type" --></td><td><!-- TMPL_VAR NAME="subject" --></td><td><!-- TMPL_VAR NAME="status" --></td><td><!-- TMPL_VAR NAME="time_queued" --></td></tr>
 <!-- /TMPL_LOOP -->
@@ -206,10 +139,6 @@ SMS number: <input type="text" name="SMSnumber" value="<!-- TMPL_VAR NAME="SMSnu
 
 </form>
 
-<!--  -->
-
-
-</div>
 </div>
 
 <!-- /TMPL_IF --> <!-- unknowuser -->
-- 
2.39.2