6 use t::lib::TestBuilder;
10 use Test::More tests => 54;
17 use Koha::DateUtils qw( dt_from_string output_pref );
24 use lib $FindBin::Bin;
25 use_ok('C4::Reserves');
28 my $schema = Koha::Database->new->schema;
29 $schema->storage->txn_begin;
31 my $builder = t::lib::TestBuilder->new();
32 my $dbh = C4::Context->dbh;
34 # Create two random branches
35 my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
36 my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
38 my $category = $builder->build({ source => 'Category' });
40 my $borrowers_count = 5;
42 $dbh->do('DELETE FROM itemtypes');
43 $dbh->do('DELETE FROM reserves');
44 my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)');
45 $insert_sth->execute('CAN');
46 $insert_sth->execute('CANNOT');
47 $insert_sth->execute('DUMMY');
48 $insert_sth->execute('ONLY1');
50 # Setup Test------------------------
51 # Create a biblio instance for testing
52 my ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY');
54 # Create item instance for testing.
55 my ($item_bibnum, $item_bibitemnum, $itemnumber)
56 = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $bibnum);
58 # Create some borrowers
60 foreach (1..$borrowers_count) {
61 my $borrowernumber = AddMember(
62 firstname => 'my firstname',
63 surname => 'my surname ' . $_,
64 categorycode => $category->{categorycode},
65 branchcode => $branch_1,
67 push @borrowernumbers, $borrowernumber;
70 my $biblionumber = $bibnum;
72 # Create five item level holds
73 foreach my $borrowernumber ( @borrowernumbers ) {
79 my $priority = C4::Reserves::CalculatePriority( $biblionumber ),
84 my $checkitem = $itemnumber,
89 my $biblio = Koha::Biblios->find( $biblionumber );
90 my $holds = $biblio->holds;
91 is( $holds->count, $borrowers_count, 'Test GetReserves()' );
92 is( $holds->next->priority, 1, "Reserve 1 has a priority of 1" );
93 is( $holds->next->priority, 2, "Reserve 2 has a priority of 2" );
94 is( $holds->next->priority, 3, "Reserve 3 has a priority of 3" );
95 is( $holds->next->priority, 4, "Reserve 4 has a priority of 4" );
96 is( $holds->next->priority, 5, "Reserve 5 has a priority of 5" );
98 my $item = Koha::Items->find( $itemnumber );
99 $holds = $item->current_holds;
100 my $first_hold = $holds->next;
101 my $reservedate = $first_hold->reservedate;
102 my $borrowernumber = $first_hold->borrowernumber;
103 my $branch_1code = $first_hold->branchcode;
104 my $reserve_id = $first_hold->reserve_id;
105 is( $reservedate, output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), "holds_placed_today should return a valid reserve date");
106 is( $borrowernumber, $borrowernumbers[0], "holds_placed_today should return a valid borrowernumber");
107 is( $branch_1code, $branch_1, "holds_placed_today should return a valid branchcode");
108 ok($reserve_id, "Test holds_placed_today()");
110 my $hold = Koha::Holds->find( $reserve_id );
111 ok( $hold, "Koha::Holds found the hold" );
112 my $hold_biblio = $hold->biblio();
113 ok( $hold_biblio, "Got biblio using biblio() method" );
114 ok( $hold_biblio == $hold->biblio(), "biblio method returns stashed biblio" );
115 my $hold_item = $hold->item();
116 ok( $hold_item, "Got item using item() method" );
117 ok( $hold_item == $hold->item(), "item method returns stashed item" );
118 my $hold_branch = $hold->branch();
119 ok( $hold_branch, "Got branch using branch() method" );
120 ok( $hold_branch == $hold->branch(), "branch method returns stashed branch" );
121 my $hold_found = $hold->found();
122 $hold->set({ found => 'W'})->store();
123 is( Koha::Holds->waiting()->count(), 1, "Koha::Holds->waiting returns waiting holds" );
124 is( Koha::Holds->unfilled()->count(), 4, "Koha::Holds->unfilled returns unfilled holds" );
126 my $patron = Koha::Patrons->find( $borrowernumbers[0] );
127 $holds = $patron->holds;
128 is( $holds->next->borrowernumber, $borrowernumbers[0], "Test Koha::Patron->holds");
131 $holds = $item->current_holds;
132 $first_hold = $holds->next;
133 $borrowernumber = $first_hold->borrowernumber;
134 $branch_1code = $first_hold->branchcode;
135 $reserve_id = $first_hold->reserve_id;
138 reserve_id => $reserve_id,
140 branchcode => $branch_1,
141 itemnumber => $itemnumber,
142 suspend_until => output_pref( { dt => dt_from_string( "2013-01-01", "iso" ), dateonly => 1 } ),
145 $hold = Koha::Holds->find( $reserve_id );
146 ok( $hold->priority eq '4', "Test ModReserve, priority changed correctly" );
147 ok( $hold->suspend, "Test ModReserve, suspend hold" );
148 is( $hold->suspend_until, '2013-01-01 00:00:00', "Test ModReserve, suspend until date" );
150 ToggleSuspend( $reserve_id );
151 $hold = Koha::Holds->find( $reserve_id );
152 ok( ! $hold->suspend, "Test ToggleSuspend(), no date" );
154 ToggleSuspend( $reserve_id, '2012-01-01' );
155 $hold = Koha::Holds->find( $reserve_id );
156 is( $hold->suspend_until, '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
158 AutoUnsuspendReserves();
159 $hold = Koha::Holds->find( $reserve_id );
160 ok( ! $hold->suspend, "Test AutoUnsuspendReserves()" );
163 borrowernumber => $borrowernumber,
164 biblionumber => $biblionumber,
166 suspend_until => '2012-01-01',
168 $hold = Koha::Holds->find( $reserve_id );
169 is( $hold->suspend, 1, "Test SuspendAll()" );
170 is( $hold->suspend_until, '2012-01-01 00:00:00', "Test SuspendAll(), with date" );
173 borrowernumber => $borrowernumber,
174 biblionumber => $biblionumber,
177 $hold = Koha::Holds->find( $reserve_id );
178 is( $hold->suspend, 0, "Test resuming with SuspendAll()" );
179 is( $hold->suspend_until, undef, "Test resuming with SuspendAll(), should have no suspend until date" );
181 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
195 $patron = Koha::Patrons->find( $borrowernumber );
196 $holds = $patron->holds;
197 my $reserveid = Koha::Holds->search({ biblionumber => $bibnum, borrowernumber => $borrowernumbers[0] })->next->reserve_id;
198 ModReserveMinusPriority( $itemnumber, $reserveid );
199 $holds = $patron->holds;
200 is( $holds->next->itemnumber, $itemnumber, "Test ModReserveMinusPriority()" );
202 $holds = $biblio->holds;
203 $hold = $holds->next;
204 AlterPriority( 'top', $hold->reserve_id );
205 $hold = Koha::Holds->find( $reserveid );
206 is( $hold->priority, '1', "Test AlterPriority(), move to top" );
208 AlterPriority( 'down', $hold->reserve_id );
209 $hold = Koha::Holds->find( $reserveid );
210 is( $hold->priority, '2', "Test AlterPriority(), move down" );
212 AlterPriority( 'up', $hold->reserve_id );
213 $hold = Koha::Holds->find( $reserveid );
214 is( $hold->priority, '1', "Test AlterPriority(), move up" );
216 AlterPriority( 'bottom', $hold->reserve_id );
217 $hold = Koha::Holds->find( $reserveid );
218 is( $hold->priority, '6', "Test AlterPriority(), move to bottom" );
220 # Regression test for bug 2394
222 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
223 # a patron is not permittedo to request an item whose homebranch (i.e.,
224 # owner of the item) is different from the patron's own library.
225 # However, if canreservefromotherbranches is turned ON, the patron can
226 # create such hold requests.
228 # Note that canreservefromotherbranches has no effect if
229 # IndependentBranches is OFF.
231 my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio('DUMMY');
232 my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
233 = AddItem({ homebranch => $branch_2, holdingbranch => $branch_2 } , $foreign_bibnum);
234 $dbh->do('DELETE FROM issuingrules');
236 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
237 VALUES (?, ?, ?, ?, ?)},
239 '*', '*', '*', 25, 99
242 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
243 VALUES (?, ?, ?, ?, ?)},
245 '*', '*', 'CANNOT', 0, 99
248 # make sure some basic sysprefs are set
249 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
250 t::lib::Mocks::mock_preference('item-level_itypes', 1);
252 # if IndependentBranches is OFF, a $branch_1 patron can reserve an $branch_2 item
253 t::lib::Mocks::mock_preference('IndependentBranches', 0);
255 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
256 '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)'
259 # if IndependentBranches is OFF, a $branch_1 patron cannot reserve an $branch_2 item
260 t::lib::Mocks::mock_preference('IndependentBranches', 1);
261 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
263 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'cannotReserveFromOtherBranches',
264 '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)'
267 # ... unless canreservefromotherbranches is ON
268 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
270 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
271 '... unless canreservefromotherbranches is ON (bug 2394)'
275 # Regression test for bug 11336 # Test if ModReserve correctly recalculate the priorities
276 ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY');
277 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $bibnum);
278 my $reserveid1 = AddReserve($branch_1, $borrowernumbers[0], $bibnum, '', 1);
279 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $bibnum);
280 my $reserveid2 = AddReserve($branch_1, $borrowernumbers[1], $bibnum, '', 2);
281 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $bibnum);
282 my $reserveid3 = AddReserve($branch_1, $borrowernumbers[2], $bibnum, '', 3);
283 my $hhh = Koha::Holds->search({ biblionumber => $bibnum });
284 my $hold3 = Koha::Holds->find( $reserveid3 );
285 is( $hold3->priority, 3, "The 3rd hold should have a priority set to 3" );
286 ModReserve({ reserve_id => $reserveid1, rank => 'del' });
287 ModReserve({ reserve_id => $reserveid2, rank => 'del' });
288 is( $hold3->discard_changes->priority, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
291 ModItem({ damaged => 1 }, $item_bibnum, $itemnumber);
292 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 1 );
293 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber), 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
294 ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
296 $hold = Koha::Hold->new(
298 borrowernumber => $borrowernumbers[0],
299 itemnumber => $itemnumber,
300 biblionumber => $item_bibnum,
303 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ),
305 "Patron cannot place a second item level hold for a given item" );
308 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 0 );
309 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
310 ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
312 # Regression test for bug 9532
313 ($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
314 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $bibnum);
323 CanItemBeReserved( $borrowernumbers[0], $itemnumber), 'tooManyReserves',
324 "cannot request item if policy that matches on item-level item type forbids it"
326 ModItem({ itype => 'CAN' }, $item_bibnum, $itemnumber);
328 CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK',
329 "can request item if policy that matches on item type allows it"
332 t::lib::Mocks::mock_preference('item-level_itypes', 0);
333 ModItem({ itype => undef }, $item_bibnum, $itemnumber);
335 CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves',
336 "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
340 # Test branch item rules
342 $dbh->do('DELETE FROM issuingrules');
344 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
345 VALUES (?, ?, ?, ?)},
349 $dbh->do('DELETE FROM branch_item_rules');
350 $dbh->do('DELETE FROM default_branch_circ_rules');
351 $dbh->do('DELETE FROM default_branch_item_rules');
352 $dbh->do('DELETE FROM default_circ_rules');
354 INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
356 }, {}, $branch_1, 'CANNOT', 0, 'homebranch');
358 INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
360 }, {}, $branch_1, 'CAN', 1, 'homebranch');
361 ($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
362 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
363 { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $bibnum);
364 is(CanItemBeReserved($borrowernumbers[0], $itemnumber), 'notReservable',
365 "CanItemBeReserved should returns 'notReservable'");
367 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
368 { homebranch => $branch_2, holdingbranch => $branch_1, itype => 'CAN' } , $bibnum);
369 is(CanItemBeReserved($borrowernumbers[0], $itemnumber),
370 'cannotReserveFromOtherBranches',
371 "CanItemBeReserved should returns 'cannotReserveFromOtherBranches'");
373 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
374 { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CAN' } , $bibnum);
375 is(CanItemBeReserved($borrowernumbers[0], $itemnumber), 'OK',
376 "CanItemBeReserved should returns 'OK'");
379 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
380 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
382 $dbh->do('DELETE FROM reserves');
383 $dbh->do('DELETE FROM issues');
384 $dbh->do('DELETE FROM items');
385 $dbh->do('DELETE FROM biblio');
387 ( $bibnum, $title, $bibitemnum ) = create_helper_biblio('ONLY1');
388 ( $item_bibnum, $item_bibitemnum, $itemnumber )
389 = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $bibnum );
392 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
393 VALUES (?, ?, ?, ?, ?)},
395 '*', '*', 'ONLY1', 1, 99
397 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ),
398 'OK', 'Patron can reserve item with hold limit of 1, no holds placed' );
400 my $res_id = AddReserve( $branch_1, $borrowernumbers[0], $bibnum, '', 1, );
402 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ),
403 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
406 # Helper method to set up a Biblio.
407 sub create_helper_biblio {
408 my $itemtype = shift;
409 my $bib = MARC::Record->new();
410 my $title = 'Silence in the library';
412 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
413 MARC::Field->new('245', ' ', ' ', a => $title),
414 MARC::Field->new('942', ' ', ' ', c => $itemtype),
416 return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');