]> git.koha-community.org Git - koha.git/commit
Bug 27835: (follow-up) Update language, remove warn, add feedback
authorNick Clemens <nick@bywatersolutions.com>
Tue, 16 Mar 2021 13:22:26 +0000 (13:22 +0000)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Tue, 23 Mar 2021 19:03:14 +0000 (19:03 +0000)
commit104c886213301ce77507571f5cbc8b79ceaa3598
tree4f69d04a6ba3ee08b2d15d31e80f64f0b19de01a
parent54b35cab23d4c8f5892ab2f42cdf324efc38f4ff
Bug 27835: (follow-up) Update language, remove warn, add feedback

This patch:
 - Updates lanugage to be clearer 'ChargeFinesOnClosedDays' vs 'ChargeFinesOnCloseDay'
 - Removes a stary warn
 - Add an 'updated' counter and provides feedback in fines.pl

Test plan:
 0 - Apply patches, updatedatabase
 1 - set finesCalendar to 'ignore', ChargeFinesOnClosedDays to "Don't charge"
 2 - Checkout an item due yesterday
 3 - Ensure circ rules have a fine amount and interval set
 4 - Make today a holiday
 5 - perl misc/cronjobs/fines.pl -v
 6 - 0 updated
 7 - ChargeFinesOnClosedDays to "Charge"
 8 - perl misc/cronjobs/fines.pl -v
 9 - 1 updated
10 - set fines calendar to 'use'
11 - perl misc/cronjobs/fines.pl -v
12 - 1 updated (NOTE: This is wrong maybe, but handle on another bug)
13 - set ChargeFinesOnClosedDays to "Don't charge"
14 - perl misc/cronjobs/fines.pl -v
12 - 0 updated

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit deb2f6317a10ec202b2c45dbab663d7a61a43de2)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 3c73048dbc77781c390f454e7f0b61d4886c5f3b)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
installer/data/mysql/atomicupdate/bug_27835.perl
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
misc/cronjobs/fines.pl