Bug 32426: Throw InvalidUserid exception in Patron->store
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 8 Dec 2022 15:02:35 +0000 (16:02 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 27 Mar 2023 10:49:51 +0000 (12:49 +0200)
commit6b2e92e576a502876e9de5ffbd418b1d48603c76
tree7f25930f105c3aa24f2b6f4539b23cf345e3df7f
parentc0260e4501c74739da14599d510e4f6cc71dd2b4
Bug 32426: Throw InvalidUserid exception in Patron->store

When creating we still call generate_userid and verify the result.
When modifying we do not accept an invalid userid. When needed,
we recreate the userid; this should be very exceptional.

Test plan:
Run t/db_dependent/Koha/Patrons.t
Go to staff interface. Try changing userid of a patron to an
existing one.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Exceptions/Patron.pm
Koha/Patron.pm
t/db_dependent/Koha/Patrons.t