]> git.koha-community.org Git - koha.git/commit
Bug 7607: Remove empty inputs when submitting search form
authorNick Clemens <nick@bywatersolutions.com>
Tue, 3 Nov 2020 11:19:23 +0000 (11:19 +0000)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Thu, 10 Dec 2020 22:00:17 +0000 (22:00 +0000)
commitb460a630ef6772671454ea6ea25d8d4d672f3571
treeab01634c508773024c94c22b82ed8b2e3b282a5f
parent49159304220be24efed37715a066abe2cff5cd14
Bug 7607: Remove empty inputs when submitting search form

This patch surrounds the operator, index, and query fields on the advanced search
page wtih a 'search_set' class.

This allows us to process them as a group and confirm the query is populated before submitting
the other parts to the form

TO test:
1 - Go to advanced search
2 - Use search boxes to search like:
    Title: (leave blank)
    Author: clinton
    keyword: shuffle
3 - Perform search
4 - Note no results as you searched for title:clinton etc.
5 - apply patch
6 - refresh and repeat
7 - search is now correct
8 - Try vaeious searches with 'more options' and selecting different operators

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit cc970464ec7c881aaa9d8a33931a29a5951e6103)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
koha-tmpl/intranet-tmpl/prog/js/staff-global.js