Bug 26963: (QA follow-up) Migrate unit tests into pickup_location
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 11 Nov 2020 16:06:21 +0000 (16:06 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 13 Nov 2020 13:20:11 +0000 (14:20 +0100)
commitb6a7a3c8a8fa040409f4c42d10149b72a427cf54
tree6415b75fbe57e799198bd39f65f386afa3aaeaee
parent7179a29feaf994f35de871d06084f71dfc9eebcc
Bug 26963: (QA follow-up) Migrate unit tests into pickup_location

We wrote unit tests for _can_pickup_locations as part of this patchset,
but then I inlined the method whilst golfing. This patch moves those
tests into the existing pickup_locations test so we more thoroughly
cover the case where branch transfer limits are in play.

NOTE: The tests all assume that all items have an effective_itemtype and
ccode. I'm pretty sure items all have a type at this point, but I'm less
sure we enforce collection codes?

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
t/db_dependent/Koha/Item.t