Bug 19097: Remove wantarray from GetMarcSubfieldStructureFromKohaField
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 30 Oct 2023 13:20:14 +0000 (13:20 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Mon, 29 Apr 2024 07:35:46 +0000 (09:35 +0200)
commitd24ec0e26de5c9c58c0be566ecdea061577edfee
treea2c8618c752860827e3e524014f7549e2ab5a066
parent2b58f18f64fd75aab037786f77c6c235265a7122
Bug 19097: Remove wantarray from GetMarcSubfieldStructureFromKohaField

Replacing wantarray by always returning all mappings.
In a few cases only we expect multiple ones.
Changing two calls to pick the first hit, and add comment about
the implicit assumption being made (as before, no behavior change).

Test plan:
Look at results of git grep GetMarcSubfieldStructureFromKohaField
Run t/db_dependent/Biblio.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
C4/Biblio.pm
reports/acquisitions_stats.pl
reports/catalogue_stats.pl
t/db_dependent/Biblio.t